| Message ID | 20180120032651.GA14512@embeddedgus |
|---|---|
| State | Accepted |
| Headers | show |
| Series | PCI: altera: Fix bool initialization in tlp_read_packet | expand |
On Fri, 2018-01-19 at 21:26 -0600, Gustavo A. R. Silva wrote: > Bool initializations should use true and false. > > This issue was detected with the help of Coccinelle. > > Fixes: eaa6111b70a7 ("PCI: altera: Add Altera PCIe host controller > driver") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/pci/host/pcie-altera.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie- > altera.c > index 5cc4f59..f9ee090 100644 > --- a/drivers/pci/host/pcie-altera.c > +++ b/drivers/pci/host/pcie-altera.c > @@ -156,7 +156,7 @@ static bool altera_pcie_valid_device(struct > altera_pcie *pcie, > static int tlp_read_packet(struct altera_pcie *pcie, u32 *value) > { > int i; > - bool sop = 0; > + bool sop = false; > u32 ctrl; > u32 reg0, reg1; > u32 comp_status = 1; > -- > 2.7.4 Acked-by: Ley Foon Tan <ley.foon.tan@intel.com>
On Fri, Jan 19, 2018 at 09:26:51PM -0600, Gustavo A. R. Silva wrote: > Bool initializations should use true and false. > > This issue was detected with the help of Coccinelle. > > Fixes: eaa6111b70a7 ("PCI: altera: Add Altera PCIe host controller driver") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/pci/host/pcie-altera.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to pci/altera for v4.17, thanks. Lorenzo > diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c > index 5cc4f59..f9ee090 100644 > --- a/drivers/pci/host/pcie-altera.c > +++ b/drivers/pci/host/pcie-altera.c > @@ -156,7 +156,7 @@ static bool altera_pcie_valid_device(struct altera_pcie *pcie, > static int tlp_read_packet(struct altera_pcie *pcie, u32 *value) > { > int i; > - bool sop = 0; > + bool sop = false; > u32 ctrl; > u32 reg0, reg1; > u32 comp_status = 1; > -- > 2.7.4 >
diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c index 5cc4f59..f9ee090 100644 --- a/drivers/pci/host/pcie-altera.c +++ b/drivers/pci/host/pcie-altera.c @@ -156,7 +156,7 @@ static bool altera_pcie_valid_device(struct altera_pcie *pcie, static int tlp_read_packet(struct altera_pcie *pcie, u32 *value) { int i; - bool sop = 0; + bool sop = false; u32 ctrl; u32 reg0, reg1; u32 comp_status = 1;
Bool initializations should use true and false. This issue was detected with the help of Coccinelle. Fixes: eaa6111b70a7 ("PCI: altera: Add Altera PCIe host controller driver") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/pci/host/pcie-altera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)