From patchwork Sat May 10 15:02:35 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Williamson X-Patchwork-Id: 347687 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 38737140083 for ; Sun, 11 May 2014 01:06:36 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753276AbaEJPCl (ORCPT ); Sat, 10 May 2014 11:02:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22342 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753226AbaEJPCj (ORCPT ); Sat, 10 May 2014 11:02:39 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4AF2a58025586 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 10 May 2014 11:02:36 -0400 Received: from bling.home (ovpn-113-44.phx2.redhat.com [10.3.113.44]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4AF2Zij017550; Sat, 10 May 2014 11:02:35 -0400 Subject: [PATCH v3 02/15] PCI: quirk pci_for_each_dma_alias() From: Alex Williamson To: linux-pci@vger.kernel.org, iommu@lists.linux-foundation.org Cc: bhelgaas@google.com, acooks@gmail.com, linux-kernel@vger.kernel.org, linux@horizon.com Date: Sat, 10 May 2014 09:02:35 -0600 Message-ID: <20140510150235.2997.88101.stgit@bling.home> In-Reply-To: <20140510145619.2997.429.stgit@bling.home> References: <20140510145619.2997.429.stgit@bling.home> User-Agent: StGit/0.17-dirty MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org There are a few broken devices that use the requester ID of a different function in the slot for their DMA. To handle these, add a bitmap to struct pci_dev (using an alignment gap) that quirks can populate. As we iterate over the device and bus DMA aliases, also iterate over any bits in the map. Signed-off-by: Alex Williamson --- drivers/pci/search.c | 21 +++++++++++++++++++++ include/linux/pci.h | 2 ++ 2 files changed, 23 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/search.c b/drivers/pci/search.c index 5601cdb..ad698b2 100644 --- a/drivers/pci/search.c +++ b/drivers/pci/search.c @@ -37,6 +37,27 @@ int pci_for_each_dma_alias(struct pci_dev *pdev, if (ret) return ret; + /* + * dma_func_alias provides a bitmap of other function numbers on + * this same PCI slot to use as DMA aliases. + */ + if (unlikely(pdev->dma_func_alias)) { + u8 map = pdev->dma_func_alias & ~(1 << PCI_FUNC(pdev->devfn)); + int func; + + for (func = 0; map && func < 8; func++, map >>= 1) { + if (!(map & 1)) + continue; + + ret = fn(pdev, + PCI_DEVID(pdev->bus->number, + PCI_DEVFN(PCI_SLOT(pdev->devfn), + func)), data); + if (ret) + return ret; + } + } + for (bus = pdev->bus; !pci_is_root_bus(bus); bus = bus->parent) { struct pci_dev *tmp; diff --git a/include/linux/pci.h b/include/linux/pci.h index 14b074b..b4c97d2 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -268,6 +268,8 @@ struct pci_dev { u8 rom_base_reg; /* which config register controls the ROM */ u8 pin; /* which interrupt pin this device uses */ u16 pcie_flags_reg; /* cached PCIe Capabilities Register */ + u8 dma_func_alias; /* bitmap of functions used as DMA + aliases for this device */ struct pci_driver *driver; /* which driver has allocated this device */ u64 dma_mask; /* Mask of the bits of bus address this