Message ID | 20120514202147.GA20652@google.com |
---|---|
State | Accepted |
Headers | show |
> > > > Thanks for the quick response Meelis (unlike myself; I've been consumed > > > > with a hard deadline task recently - sorry). > > > > Not so quick this time - I had to replace the HDD and then recreate the > > failing config. Took 2.4-rc7 as a base. This gives us another data point > > - it does not warn on SMP but warns only on UP. > > I think that's the critical point; thanks for mentioning it :) > > The following patch should fix it. Can you confirm? Yes, that fixes it, thanks!
On Mon, May 14, 2012 at 1:53 PM, Meelis Roos <mroos@linux.ee> wrote: >> > > > Thanks for the quick response Meelis (unlike myself; I've been consumed >> > > > with a hard deadline task recently - sorry). >> > >> > Not so quick this time - I had to replace the HDD and then recreate the >> > failing config. Took 2.4-rc7 as a base. This gives us another data point >> > - it does not warn on SMP but warns only on UP. >> >> I think that's the critical point; thanks for mentioning it :) >> >> The following patch should fix it. Can you confirm? > > Yes, that fixes it, thanks! I applied this to my "next" branch. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/x86/pci/i386.c b/arch/x86/pci/i386.c index 831971e..dd8ca6f 100644 --- a/arch/x86/pci/i386.c +++ b/arch/x86/pci/i386.c @@ -57,7 +57,7 @@ static struct pcibios_fwaddrmap *pcibios_fwaddrmap_lookup(struct pci_dev *dev) { struct pcibios_fwaddrmap *map; - WARN_ON(!spin_is_locked(&pcibios_fwaddrmap_lock)); + WARN_ON_SMP(!spin_is_locked(&pcibios_fwaddrmap_lock)); list_for_each_entry(map, &pcibios_fwaddrmappings, list) if (map->dev == dev)