| Message ID | 1510591074-59346-1-git-send-email-biju.das@bp.renesas.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: PCI: rcar: Add device tree support for r8a7743 | expand |
Hi Biju, On Mon, Nov 13, 2017 at 5:37 PM, Biju Das <biju.das@bp.renesas.com> wrote: > Add support for r8a7743. The Renesas RZ/G1M(R8A7743)PCIe controller > is identical to the R-Car Gen2 family. > > No driver change is needed due to the fallback compatible value > "renesas,pcie-rcar-gen2". > Adding the SoC-specific compatible values here has three purposes: > 1. Document which SoCs have this hardware module, > 2. Allow checkpatch to validate compatible values. > 3. Allow the driver to support SoC specific implementations in future > as necessary. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Thanks for your patch! With the below fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt > +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt > @@ -1,13 +1,15 @@ > * Renesas R-Car PCIe interface > > Required properties: > -compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC; > +compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC; > + "renesas,pcie-r8a7779" for the R8A7779 SoC; > "renesas,pcie-r8a7790" for the R8A7790 SoC; > "renesas,pcie-r8a7791" for the R8A7791 SoC; > "renesas,pcie-r8a7793" for the R8A7793 SoC; > "renesas,pcie-r8a7795" for the R8A7795 SoC; > "renesas,pcie-r8a7796" for the R8A7796 SoC; > - "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device. > + "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 or > + RZ-G1 compatible device. RZ/G1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hello! On 11/13/2017 7:37 PM, Biju Das wrote: > Add support for r8a7743. The Renesas RZ/G1M(R8A7743)PCIe controller > is identical to the R-Car Gen2 family. > > No driver change is needed due to the fallback compatible value > "renesas,pcie-rcar-gen2". > Adding the SoC-specific compatible values here has three purposes: > 1. Document which SoCs have this hardware module, > 2. Allow checkpatch to validate compatible values. > 3. Allow the driver to support SoC specific implementations in future > as necessary. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > --- > Documentation/devicetree/bindings/pci/rcar-pci.txt | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt b/Documentation/devicetree/bindings/pci/rcar-pci.txt > index 76ba3a6..2c43e38 100644 > --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt > +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt > @@ -1,13 +1,15 @@ > * Renesas R-Car PCIe interface > > Required properties: > -compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC; > +compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC; > + "renesas,pcie-r8a7779" for the R8A7779 SoC; > "renesas,pcie-r8a7790" for the R8A7790 SoC; > "renesas,pcie-r8a7791" for the R8A7791 SoC; > "renesas,pcie-r8a7793" for the R8A7793 SoC; > "renesas,pcie-r8a7795" for the R8A7795 SoC; > "renesas,pcie-r8a7796" for the R8A7796 SoC; > - "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device. > + "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 or > + RZ-G1 compatible device. It's called RZ/G1. [...] MBR, Sergei
Thanks. I will send a V2 for fixing this. Regards, Biju > -----Original Message----- > From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com] > On Behalf Of Geert Uytterhoeven > Sent: 13 November 2017 19:11 > To: Biju Das <biju.das@bp.renesas.com> > Cc: Bjorn Helgaas <bhelgaas@google.com>; Rob Herring > <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Simon > Horman <horms@verge.net.au>; Chris Paterson > <Chris.Paterson2@renesas.com>; Fabrizio Castro > <fabrizio.castro@bp.renesas.com>; linux-pci <linux-pci@vger.kernel.org>; > Linux-Renesas <linux-renesas-soc@vger.kernel.org> > Subject: Re: [PATCH ] dt-bindings: PCI: rcar: Add device tree support for > r8a7743 > > Hi Biju, > > On Mon, Nov 13, 2017 at 5:37 PM, Biju Das <biju.das@bp.renesas.com> wrote: > > Add support for r8a7743. The Renesas RZ/G1M(R8A7743)PCIe controller is > > identical to the R-Car Gen2 family. > > > > No driver change is needed due to the fallback compatible value > > "renesas,pcie-rcar-gen2". > > Adding the SoC-specific compatible values here has three purposes: > > 1. Document which SoCs have this hardware module, 2. Allow checkpatch > > to validate compatible values. > > 3. Allow the driver to support SoC specific implementations in future > > as necessary. > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Thanks for your patch! > > With the below fixed: > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt > > +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt > > @@ -1,13 +1,15 @@ > > * Renesas R-Car PCIe interface > > > > Required properties: > > -compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC; > > +compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC; > > + "renesas,pcie-r8a7779" for the R8A7779 SoC; > > "renesas,pcie-r8a7790" for the R8A7790 SoC; > > "renesas,pcie-r8a7791" for the R8A7791 SoC; > > "renesas,pcie-r8a7793" for the R8A7793 SoC; > > "renesas,pcie-r8a7795" for the R8A7795 SoC; > > "renesas,pcie-r8a7796" for the R8A7796 SoC; > > - "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device. > > + "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 or > > + RZ-G1 compatible device. > > RZ/G1 > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But when > I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt b/Documentation/devicetree/bindings/pci/rcar-pci.txt index 76ba3a6..2c43e38 100644 --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt @@ -1,13 +1,15 @@ * Renesas R-Car PCIe interface Required properties: -compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC; +compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC; + "renesas,pcie-r8a7779" for the R8A7779 SoC; "renesas,pcie-r8a7790" for the R8A7790 SoC; "renesas,pcie-r8a7791" for the R8A7791 SoC; "renesas,pcie-r8a7793" for the R8A7793 SoC; "renesas,pcie-r8a7795" for the R8A7795 SoC; "renesas,pcie-r8a7796" for the R8A7796 SoC; - "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device. + "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 or + RZ-G1 compatible device. "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 compatible device. When compatible with the generic version, nodes must list the