| Message ID | 1509120687-7352-3-git-send-email-gabriele.paoloni@huawei.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | LPC: legacy ISA I/O support | expand |
> PCI: remove unused __weak attribute in pci_register_io_range() Please capitalize to follow drivers/pci convention, e.g., PCI: Remove __weak attribute from pci_register_io_range() (Also do the same for the other PCI patches.) On Fri, Oct 27, 2017 at 05:11:20PM +0100, Gabriele Paoloni wrote: > From: gabriele paoloni <gabriele.paoloni@huawei.com> > > Currently pci_register_io_range() has only one definition; > therefore there is no use of the __weak attribute. > > Signed-off-by: Gabriele Paoloni <gabriele.paoloni@huawei.com> > Acked-by: Bjorn Helgaas <helgaas@kernel.org> > --- > drivers/pci/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index af0cc34..eee967c 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -3270,7 +3270,7 @@ static DEFINE_SPINLOCK(io_range_lock); > * Record the PCI IO range (expressed as CPU physical address + size). > * Return a negative value if an error has occured, zero otherwise > */ > -int __weak pci_register_io_range(phys_addr_t addr, resource_size_t size) > +int pci_register_io_range(phys_addr_t addr, resource_size_t size) > { > int err = 0; > > -- > 2.7.4 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Oct 27, 2017 at 05:11:20PM +0100, Gabriele Paoloni wrote: > From: gabriele paoloni <gabriele.paoloni@huawei.com> > > Currently pci_register_io_range() has only one definition; > therefore there is no use of the __weak attribute. > > Signed-off-by: Gabriele Paoloni <gabriele.paoloni@huawei.com> > Acked-by: Bjorn Helgaas <helgaas@kernel.org> Also, I normally use this (Google address instead of kernel.org): Acked-by: Bjorn Helgaas <bhelgaas@google.com> (Also affects your other PCI patches.) > --- > drivers/pci/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index af0cc34..eee967c 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -3270,7 +3270,7 @@ static DEFINE_SPINLOCK(io_range_lock); > * Record the PCI IO range (expressed as CPU physical address + size). > * Return a negative value if an error has occured, zero otherwise > */ > -int __weak pci_register_io_range(phys_addr_t addr, resource_size_t size) > +int pci_register_io_range(phys_addr_t addr, resource_size_t size) > { > int err = 0; > > -- > 2.7.4 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: Bjorn Helgaas [mailto:helgaas@kernel.org] > Sent: 07 November 2017 00:25 > To: Gabriele Paoloni > Cc: catalin.marinas@arm.com; will.deacon@arm.com; robh+dt@kernel.org; > frowand.list@gmail.com; bhelgaas@google.com; rafael@kernel.org; > arnd@arndb.de; linux-arm-kernel@lists.infradead.org; > lorenzo.pieralisi@arm.com; mark.rutland@arm.com; brian.starkey@arm.com; > olof@lixom.net; benh@kernel.crashing.org; linux-kernel@vger.kernel.org; > linux-acpi@vger.kernel.org; Linuxarm; linux-pci@vger.kernel.org; > minyard@acm.org; John Garry; xuwei (O) > Subject: Re: [PATCH v10 2/9] PCI: remove unused __weak attribute in > pci_register_io_range() > > On Fri, Oct 27, 2017 at 05:11:20PM +0100, Gabriele Paoloni wrote: > > From: gabriele paoloni <gabriele.paoloni@huawei.com> > > > > Currently pci_register_io_range() has only one definition; > > therefore there is no use of the __weak attribute. > > > > Signed-off-by: Gabriele Paoloni <gabriele.paoloni@huawei.com> > > Acked-by: Bjorn Helgaas <helgaas@kernel.org> > > Also, I normally use this (Google address instead of kernel.org): > > Acked-by: Bjorn Helgaas <bhelgaas@google.com> > > (Also affects your other PCI patches.) Ok no probs, we'll change all the Acked-by in the next patchset Many Thanks Gab > > > --- > > drivers/pci/pci.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > > index af0cc34..eee967c 100644 > > --- a/drivers/pci/pci.c > > +++ b/drivers/pci/pci.c > > @@ -3270,7 +3270,7 @@ static DEFINE_SPINLOCK(io_range_lock); > > * Record the PCI IO range (expressed as CPU physical address + > size). > > * Return a negative value if an error has occured, zero otherwise > > */ > > -int __weak pci_register_io_range(phys_addr_t addr, resource_size_t > size) > > +int pci_register_io_range(phys_addr_t addr, resource_size_t size) > > { > > int err = 0; > > > > -- > > 2.7.4 > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-acpi" > in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: Bjorn Helgaas [mailto:helgaas@kernel.org] > Sent: 07 November 2017 00:23 > To: Gabriele Paoloni > Cc: catalin.marinas@arm.com; will.deacon@arm.com; robh+dt@kernel.org; > frowand.list@gmail.com; bhelgaas@google.com; rafael@kernel.org; > arnd@arndb.de; linux-arm-kernel@lists.infradead.org; > lorenzo.pieralisi@arm.com; mark.rutland@arm.com; brian.starkey@arm.com; > olof@lixom.net; benh@kernel.crashing.org; linux-kernel@vger.kernel.org; > linux-acpi@vger.kernel.org; Linuxarm; linux-pci@vger.kernel.org; > minyard@acm.org; John Garry; xuwei (O) > Subject: Re: [PATCH v10 2/9] PCI: remove unused __weak attribute in > pci_register_io_range() > > > PCI: remove unused __weak attribute in pci_register_io_range() > > Please capitalize to follow drivers/pci convention, e.g., > > PCI: Remove __weak attribute from pci_register_io_range() > > (Also do the same for the other PCI patches.) Agreed, many thanks Gab > > On Fri, Oct 27, 2017 at 05:11:20PM +0100, Gabriele Paoloni wrote: > > From: gabriele paoloni <gabriele.paoloni@huawei.com> > > > > Currently pci_register_io_range() has only one definition; > > therefore there is no use of the __weak attribute. > > > > Signed-off-by: Gabriele Paoloni <gabriele.paoloni@huawei.com> > > Acked-by: Bjorn Helgaas <helgaas@kernel.org> > > --- > > drivers/pci/pci.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > > index af0cc34..eee967c 100644 > > --- a/drivers/pci/pci.c > > +++ b/drivers/pci/pci.c > > @@ -3270,7 +3270,7 @@ static DEFINE_SPINLOCK(io_range_lock); > > * Record the PCI IO range (expressed as CPU physical address + > size). > > * Return a negative value if an error has occured, zero otherwise > > */ > > -int __weak pci_register_io_range(phys_addr_t addr, resource_size_t > size) > > +int pci_register_io_range(phys_addr_t addr, resource_size_t size) > > { > > int err = 0; > > > > -- > > 2.7.4 > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-acpi" > in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index af0cc34..eee967c 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -3270,7 +3270,7 @@ static DEFINE_SPINLOCK(io_range_lock); * Record the PCI IO range (expressed as CPU physical address + size). * Return a negative value if an error has occured, zero otherwise */ -int __weak pci_register_io_range(phys_addr_t addr, resource_size_t size) +int pci_register_io_range(phys_addr_t addr, resource_size_t size) { int err = 0;