| Message ID | 1454889644-27830-4-git-send-email-paul.gortmaker@windriver.com |
|---|---|
| State | Not Applicable |
| Headers | show |
On Sunday 07 February 2016 19:00:42 Paul Gortmaker wrote: > After converting the drivers who select PCI_DW from bool to tristate, > the following symbols need to be exported, simply based on the output > from modpost failures. > > Cc: Jingoo Han <jingoohan1@gmail.com> > Cc: Pratyush Anand <pratyush.anand@gmail.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Stanimir Varbanov <svarbanov@mm-sol.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: linux-pci@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > Looks good in principle, but maybe use EXPORT_SYMBOL_GPL? These are just meant to be used internally by the drivers after all. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[Re: [PATCH 3/5] drivers/pci: export dw syms enabling board specific PCI code to be tristate] On 08/02/2016 (Mon 10:57) Arnd Bergmann wrote: > On Sunday 07 February 2016 19:00:42 Paul Gortmaker wrote: > > After converting the drivers who select PCI_DW from bool to tristate, > > the following symbols need to be exported, simply based on the output > > from modpost failures. > > > > Cc: Jingoo Han <jingoohan1@gmail.com> > > Cc: Pratyush Anand <pratyush.anand@gmail.com> > > Cc: Bjorn Helgaas <bhelgaas@google.com> > > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > > Cc: Stanimir Varbanov <svarbanov@mm-sol.com> > > Cc: Thierry Reding <thierry.reding@gmail.com> > > Cc: Arnd Bergmann <arnd@arndb.de> > > Cc: linux-pci@vger.kernel.org > > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > > > > Looks good in principle, but maybe use EXPORT_SYMBOL_GPL? These > are just meant to be used internally by the drivers after all. Sure, I can make that restriction. P. -- > > Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c index 21716827847a..65c0c81b8852 100644 --- a/drivers/pci/host/pcie-designware.c +++ b/drivers/pci/host/pcie-designware.c @@ -91,6 +91,7 @@ int dw_pcie_cfg_read(void __iomem *addr, int size, u32 *val) return PCIBIOS_SUCCESSFUL; } +EXPORT_SYMBOL(dw_pcie_cfg_read); int dw_pcie_cfg_write(void __iomem *addr, int size, u32 val) { @@ -108,6 +109,7 @@ int dw_pcie_cfg_write(void __iomem *addr, int size, u32 val) return PCIBIOS_SUCCESSFUL; } +EXPORT_SYMBOL(dw_pcie_cfg_write); static inline void dw_pcie_readl_rc(struct pcie_port *pp, u32 reg, u32 *val) { @@ -201,6 +203,7 @@ irqreturn_t dw_handle_msi_irq(struct pcie_port *pp) return ret; } +EXPORT_SYMBOL(dw_handle_msi_irq); void dw_pcie_msi_init(struct pcie_port *pp) { @@ -215,6 +218,7 @@ void dw_pcie_msi_init(struct pcie_port *pp) dw_pcie_wr_own_conf(pp, PCIE_MSI_ADDR_HI, 4, (u32)(msi_target >> 32 & 0xffffffff)); } +EXPORT_SYMBOL(dw_pcie_msi_init); static void dw_pcie_msi_clear_irq(struct pcie_port *pp, int irq) { @@ -387,6 +391,7 @@ int dw_pcie_link_up(struct pcie_port *pp) return 0; } +EXPORT_SYMBOL(dw_pcie_link_up); static int dw_pcie_msi_map(struct irq_domain *domain, unsigned int irq, irq_hw_number_t hwirq) @@ -562,6 +567,7 @@ int dw_pcie_host_init(struct pcie_port *pp) pci_bus_add_devices(bus); return 0; } +EXPORT_SYMBOL(dw_pcie_host_init); static int dw_pcie_rd_other_conf(struct pcie_port *pp, struct pci_bus *bus, u32 devfn, int where, int size, u32 *val) @@ -771,6 +777,7 @@ void dw_pcie_setup_rc(struct pcie_port *pp) PCI_COMMAND_MASTER | PCI_COMMAND_SERR; dw_pcie_writel_rc(pp, val, PCI_COMMAND); } +EXPORT_SYMBOL(dw_pcie_setup_rc); MODULE_AUTHOR("Jingoo Han <jg1.han@samsung.com>"); MODULE_DESCRIPTION("Designware PCIe host controller driver");
After converting the drivers who select PCI_DW from bool to tristate, the following symbols need to be exported, simply based on the output from modpost failures. Cc: Jingoo Han <jingoohan1@gmail.com> Cc: Pratyush Anand <pratyush.anand@gmail.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Stanimir Varbanov <svarbanov@mm-sol.com> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: linux-pci@vger.kernel.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- drivers/pci/host/pcie-designware.c | 7 +++++++ 1 file changed, 7 insertions(+)