From patchwork Thu Sep 10 23:43:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 516492 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5099F140783 for ; Fri, 11 Sep 2015 09:43:49 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=bfJ3xRyt; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751069AbbIJXns (ORCPT ); Thu, 10 Sep 2015 19:43:48 -0400 Received: from mail-yk0-f178.google.com ([209.85.160.178]:36153 "EHLO mail-yk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751018AbbIJXnr (ORCPT ); Thu, 10 Sep 2015 19:43:47 -0400 Received: by ykdt18 with SMTP id t18so54897816ykd.3 for ; Thu, 10 Sep 2015 16:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=e8oUDEBIugw3LysxiOq6WeFoAQH+cScFb5Mz2bIa7i0=; b=bfJ3xRytEJYb+cVvCNaDY40dxwyC5BSGoehHTlhO0Vqpf2Trl22y9tdCS1W2yFAF3U LiV8V0jhsPXM43tnWowAEJTR1D31DhB1voPkvQrSafyWZFpPvqpPh2/FRuAmH9S8VQPo sTHgjxvTIrPh6Pbz7OcUwYHWZC2x8pf2Mkq4nbOa1vEp6FHE+MaOP+nlFU+uK4xIW5XR fBTAOos27YNsUg1brLE3YrIMugNnACBIg65LtI/WKGInsjfVOj2PHdEtZdaV/mPEb50b DLLoHtLwv2mqln/u+gbMFNAC0Va8ADJlOo0Suf1ka8BQpKeYTGxgNfyyJvvQI+7u6Iqs unnQ== X-Received: by 10.170.204.151 with SMTP id v145mr50128283yke.95.1441928626942; Thu, 10 Sep 2015 16:43:46 -0700 (PDT) Received: from localhost.localdomain ([179.159.191.85]) by smtp.gmail.com with ESMTPSA id u184sm10998953ywd.23.2015.09.10.16.43.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 10 Sep 2015 16:43:46 -0700 (PDT) From: Fabio Estevam To: bhelgaas@google.com Cc: l.stach@pengutronix.de, linux-pci@vger.kernel.org, Fabio Estevam Subject: [PATCH 1/2] PCI: imx6: Return the real error code Date: Thu, 10 Sep 2015 20:43:28 -0300 Message-Id: <1441928609-21921-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Fabio Estevam When devm_request_irq() fails we should better return the real error code instead of returning a 'fake' one. Signed-off-by: Fabio Estevam Reviewed-by: Lucas Stach --- drivers/pci/host/pci-imx6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c index 8f3a981..2d0d0fe 100644 --- a/drivers/pci/host/pci-imx6.c +++ b/drivers/pci/host/pci-imx6.c @@ -539,7 +539,7 @@ static int __init imx6_add_pcie_port(struct pcie_port *pp, IRQF_SHARED, "mx6-pcie-msi", pp); if (ret) { dev_err(&pdev->dev, "failed to request MSI irq\n"); - return -ENODEV; + return ret; } }