| Message ID | 1403070985-31373-1-git-send-email-jiang.liu@linux.intel.com |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, Jun 18, 2014 at 01:56:21PM +0800, Jiang Liu wrote: > For hot-added PCIe ports, it always generates a warning message on x86 > platforms when binding to portdrv as: > "device [8086:0e0b] has invalid IRQ; check vendor BIOS". > > It's due to that we check pci_dev->irq before actually allocating IRQ > for the PCI device: > if (!dev->irq && dev->pin) { > dev_warn(&dev->dev, "device [%04x:%04x] has invalid IRQ; " > "check vendor BIOS\n", dev->vendor, dev->device); > } > status = pcie_port_device_register(dev); > -->pci_enable_device(dev); > -->pci_enable_device_flags() > -->do_pci_enable_device() > -->pcibios_enable_device() > -->pcibios_enable_irq() > > This warning message isn't generated for PCIe ports present at boot time > because x86 arch code has called acpi_pci_irq_enable() in pci_acpi_init() > for each PCI device for safety. > > Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com> Applied to pci/misc for v3.17, thanks! > --- > Hi Bjorn, > I have rebased it onto v3.16-rc1 and changed the patch title > according to your suggestion. > Thanks! > Gerry > ___ > drivers/pci/pcie/portdrv_pci.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c > index 80887eaa0668..2ccc9b926ea7 100644 > --- a/drivers/pci/pcie/portdrv_pci.c > +++ b/drivers/pci/pcie/portdrv_pci.c > @@ -203,10 +203,6 @@ static int pcie_portdrv_probe(struct pci_dev *dev, > (pci_pcie_type(dev) != PCI_EXP_TYPE_DOWNSTREAM))) > return -ENODEV; > > - if (!dev->irq && dev->pin) { > - dev_warn(&dev->dev, "device [%04x:%04x] has invalid IRQ; check vendor BIOS\n", > - dev->vendor, dev->device); > - } > status = pcie_port_device_register(dev); > if (status) > return status; > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c index 80887eaa0668..2ccc9b926ea7 100644 --- a/drivers/pci/pcie/portdrv_pci.c +++ b/drivers/pci/pcie/portdrv_pci.c @@ -203,10 +203,6 @@ static int pcie_portdrv_probe(struct pci_dev *dev, (pci_pcie_type(dev) != PCI_EXP_TYPE_DOWNSTREAM))) return -ENODEV; - if (!dev->irq && dev->pin) { - dev_warn(&dev->dev, "device [%04x:%04x] has invalid IRQ; check vendor BIOS\n", - dev->vendor, dev->device); - } status = pcie_port_device_register(dev); if (status) return status;
For hot-added PCIe ports, it always generates a warning message on x86 platforms when binding to portdrv as: "device [8086:0e0b] has invalid IRQ; check vendor BIOS". It's due to that we check pci_dev->irq before actually allocating IRQ for the PCI device: if (!dev->irq && dev->pin) { dev_warn(&dev->dev, "device [%04x:%04x] has invalid IRQ; " "check vendor BIOS\n", dev->vendor, dev->device); } status = pcie_port_device_register(dev); -->pci_enable_device(dev); -->pci_enable_device_flags() -->do_pci_enable_device() -->pcibios_enable_device() -->pcibios_enable_irq() This warning message isn't generated for PCIe ports present at boot time because x86 arch code has called acpi_pci_irq_enable() in pci_acpi_init() for each PCI device for safety. Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com> --- Hi Bjorn, I have rebased it onto v3.16-rc1 and changed the patch title according to your suggestion. Thanks! Gerry