| Message ID | 002d01cffe28$ce2f5870$6a8e0950$%han@samsung.com |
|---|---|
| State | Accepted |
| Headers | show |
On 12 November 2014 08:59, Jingoo Han <jg1.han@samsung.com> wrote: > The site-specific OOM messages are unnecessary, because they > duplicate the MM subsystem generic OOM message. This patch > fixes the following checkpatch warning. > > WARNING: Possible unnecessary 'out of memory' message > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > drivers/pci/host/pcie-spear13xx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Acked-by: Viresh Kumar <viresh.kumar@linaro.org> -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Nov 12, 2014 at 12:29:02PM +0900, Jingoo Han wrote: > The site-specific OOM messages are unnecessary, because they > duplicate the MM subsystem generic OOM message. This patch > fixes the following checkpatch warning. > > WARNING: Possible unnecessary 'out of memory' message > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> Applied with Viresh's ack to pci/host-spear for v3.19, thanks! > --- > drivers/pci/host/pcie-spear13xx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pci/host/pcie-spear13xx.c b/drivers/pci/host/pcie-spear13xx.c > index 85f594e..4647b62 100644 > --- a/drivers/pci/host/pcie-spear13xx.c > +++ b/drivers/pci/host/pcie-spear13xx.c > @@ -308,10 +308,8 @@ static int __init spear13xx_pcie_probe(struct platform_device *pdev) > int ret; > > spear13xx_pcie = devm_kzalloc(dev, sizeof(*spear13xx_pcie), GFP_KERNEL); > - if (!spear13xx_pcie) { > - dev_err(dev, "no memory for SPEAr13xx pcie\n"); > + if (!spear13xx_pcie) > return -ENOMEM; > - } > > spear13xx_pcie->phy = devm_phy_get(dev, "pcie-phy"); > if (IS_ERR(spear13xx_pcie->phy)) { > -- > 1.7.9.5 > > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/host/pcie-spear13xx.c b/drivers/pci/host/pcie-spear13xx.c index 85f594e..4647b62 100644 --- a/drivers/pci/host/pcie-spear13xx.c +++ b/drivers/pci/host/pcie-spear13xx.c @@ -308,10 +308,8 @@ static int __init spear13xx_pcie_probe(struct platform_device *pdev) int ret; spear13xx_pcie = devm_kzalloc(dev, sizeof(*spear13xx_pcie), GFP_KERNEL); - if (!spear13xx_pcie) { - dev_err(dev, "no memory for SPEAr13xx pcie\n"); + if (!spear13xx_pcie) return -ENOMEM; - } spear13xx_pcie->phy = devm_phy_get(dev, "pcie-phy"); if (IS_ERR(spear13xx_pcie->phy)) {
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. This patch fixes the following checkpatch warning. WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/pci/host/pcie-spear13xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)