From patchwork Wed Nov 27 01:59:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 294458 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 7B4032C008A for ; Wed, 27 Nov 2013 13:00:26 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759792Ab3K0CAW (ORCPT ); Tue, 26 Nov 2013 21:00:22 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:44042 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757359Ab3K0B7U (ORCPT ); Tue, 26 Nov 2013 20:59:20 -0500 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MWW000B1G6U4G80@mailout1.samsung.com>; Wed, 27 Nov 2013 10:59:18 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.50]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id FE.2D.18301.6F155925; Wed, 27 Nov 2013 10:59:18 +0900 (KST) X-AuditID: cbfee68e-b7f7e6d00000477d-5a-529551f67953 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 40.10.32308.6F155925; Wed, 27 Nov 2013 10:59:18 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MWW00EFBG6UAX80@mmp1.samsung.com>; Wed, 27 Nov 2013 10:59:18 +0900 (KST) From: Jingoo Han To: 'Christopher Li' , linux-sparse@vger.kernel.org, 'Joe Perches' , 'Dan Carpenter' Cc: 'Jason Gunthorpe' , 'Jason Cooper' , 'Thomas Petazzoni' , 'Bjorn Helgaas' , linux-pci@vger.kernel.org, 'Ezequiel Garcia' , linux-arm-kernel@lists.infradead.org, 'Axel Lin' , 'Julia Lawall' , 'Jingoo Han' References: <001001ceb816$5d1aecc0$1750c640$%han@samsung.com> <20131125200256.GA7316@obsidianresearch.com> <001101ceea68$cb486220$61d92660$%han@samsung.com> <20131126180930.GC19852@obsidianresearch.com> In-reply-to: <20131126180930.GC19852@obsidianresearch.com> Subject: Re: PCI: mvebu: return NULL instead of ERR_PTR(ret) Date: Wed, 27 Nov 2013 10:59:18 +0900 Message-id: <000101ceeb14$480fee80$d82fcb80$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac7q0qkEMP8SUtb/TeufUZJxDVkqfAAPISKg Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEKsWRmVeSWpSXmKPExsVy+t8zI91vgVODDG5dF7U4Mucrs8WSpgyL 1/+ms1icPrWA1aJxyWUWi8sLL7FafL9hajH7/mMWi2UPTjNabHp8jdXi7LzjbBb3bu9nseha c4jV4umDJiYHPo8Vq66weDzZdJHRY8GmUo+2n2UeDQfOs3js3ZLlsXlJvcf3Hb2MHh+f3mLx +LLqGrNH35ZVjB6fN8kF8ERx2aSk5mSWpRbp2yVwZXRvXsVS0CVVsXXtBaYGxkWiXYycHBIC JhIb1m5ggrDFJC7cW88GYgsJLGOUWHu9DqZm44tbLF2MXEDxRYwS99ffhSr6xSjx6pg+iM0m oCbx5cthdpAiEYFpjBKff21kBnGYBTYyS1yd3cAM0XGBUaLziB2IzSlgJXFhzQlWEFtYwEbi 1IONYFNZBFQlLn48zwJi8wrYSlw7PpkRwhaU+DH5HlicWUBLYvO2JlYIW15i85q3QPM5gE5V l3j0VxckLCJgJLF662ImiBIRiX0v3jGC3CMhcIVDYvXZdmaIXQIS3yYfYoHolZXYdIAZ4mNJ iYMrbrBMYJSYhWTzLCSbZyHZPAvJigWMLKsYRVMLkguKk9KLjPSKE3OLS/PS9ZLzczcxQtJH 3w7GmwesDzEmA62fyCwlmpwPTD95JfGGxmZGFqYmpsZG5pZmpAkrifMuepgUJCSQnliSmp2a WpBaFF9UmpNafIiRiYNTqoFRQK7tYau/5hTOnT/+3/kyxeDwWierR/7f9m6YG3XX2a/79LFF XNHvKvP3cF/kCmrbm/S6tWFLhpjbb7lKNv29t9k0JzhOesJdLrfjhNbjdTr8E70dOP2PLztW 4b5Y9W1U1e+9zF7rVOfxPbr4QeIaV/3jH34FPzPnfDd/sdu/5KHLhAt6P/tMlViKMxINtZiL ihMBFwj6SzUDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgk+LIzCtJLcpLzFFi42I5/e+xgO63wKlBBv/6BSyOzPnKbLGkKcPi 9b/pLBanTy1gtWhccpnF4vLCS6wW32+YWsy+/5jFYtmD04wWmx5fY7U4O+84m8W92/tZLLrW HGK1ePqgicmBz2PFqissHk82XWT0WLCp1KPtZ5lHw4HzLB57t2R5bF5S7/F9Ry+jx8ent1g8 vqy6xuzRt2UVo8fnTXIBPFENjDYZqYkpqUUKqXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5 ibmptkouPgG6bpk5QH8oKZQl5pQChQISi4uV9O0wTQgNcdO1gGmM0PUNCYLrMTJAAwnrGDO6 N69iKeiSqti69gJTA+Mi0S5GTg4JAROJjS9usUDYYhIX7q1n62Lk4hASWMQocX/9XTaQhJDA L0aJV8f0QWw2ATWJL18Os4MUiQhMY5T4/GsjM4jDLLCRWeLq7AZmiI4LjBKdR+xAbE4BK4kL a06wgtjCAjYSpx5sBJvKIqAqcfHjebDVvAK2EteOT2aEsAUlfky+BxZnFtCS2LytiRXClpfY vOYt0HwOoFPVJR791QUJiwgYSazeupgJokREYt+Ld4wTGIVmIZk0C8mkWUgmzULSsoCRZRWj aGpBckFxUnquoV5xYm5xaV66XnJ+7iZGcHp6JrWDcWWDxSFGAQ5GJR7eCZenBAmxJpYVV+Ye YpTgYFYS4X3hMDVIiDclsbIqtSg/vqg0J7X4EGMy0KMTmaVEk/OBqTOvJN7Q2MTMyNLIzMLI xNycNGElcd4DrdaBQgLpiSWp2ampBalFMFuYODilGhi1fs2uyfb7/syypNPSRZrrFH+Zhmj/ RIcXDbdfWnLJdu759aLxyDWHrPdLowNZ9y1333hpf+VS7rRL9S0WLl8YHr34+PxuxZHJ0Qur Jix335Qh8fDEC3MD57Ux+eFZMV92PVbY1bbM8HPP15sSh1Yc+OjK+e+O0qOYuvsW+1szjN6f Xf5pGd8MJZbijERDLeai4kQA3SgJs5MDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wednesday, November 27, 2013 3:10 AM, Jason Gunthorpe wrote: > On Tue, Nov 26, 2013 at 02:31:44PM +0900, Jingoo Han wrote: > > Previously, I sent the patch in order to fix sparse warning as below: > > How about this? > > > > static void __iomem *mvebu_pcie_map_registers(struct platform_device *pdev, > > struct device_node *np, struct mvebu_pcie_port *port) > > { > > struct resource regs; > > int ret = 0; > > > > ret = of_address_to_resource(np, 0, ®s); > > if (ret) > > - return ERR_PTR(ret); > > + return (void __iomem *)ERR_PTR(ret); > > You should probably ask the sparse folks for guidance 'git grep > iomem.*ERR_PTR' returns nothing, so this isn't an established pattern. > > It seems like sparse should know that ERR_PTR functions can work with > any pointer no matter the type? IS_ERR_PTR will have the same problem > with implicitly dropping the iomem tag. +cc Christopher Li, sparse mailing-list, Joe Perches, Dan Carpenter, Axel Lin, Julia Lawall, Hi All, I have some questions about handling sparse warning. Currently, the following sparse warning happens at Marvell Armada PCIe driver. drivers/pci/host/pci-mvebu.c:743:31: warning: incorrect type in return expression (different address spaces) drivers/pci/host/pci-mvebu.c:743:31: expected void [noderef] * drivers/pci/host/pci-mvebu.c:743:31: got void * mvebu_pcie_map_registers() returns ERR_PTR(ret), however ERR_PTR() returns (void *), not (void __iomem *). ./drivers/pci/host/pci-mvebu.c static void __iomem *mvebu_pcie_map_registers(struct platform_device *pdev, struct device_node *np, struct mvebu_pcie_port *port) { struct resource regs; int ret = 0; ret = of_address_to_resource(np, 0, ®s); if (ret) return ERR_PTR(ret); return devm_ioremap_resource(&pdev->dev, ®s); } ./include/linux/err.h static inline void * __must_check ERR_PTR(long error) { return (void *) error; } Previously, I submitted the following patch, that adds (void __iomem *) cast. ./drivers/pci/host/pci-mvebu.c static void __iomem *mvebu_pcie_map_registers(struct platform_device *pdev, struct device_node *np, struct mvebu_pcie_port *port) { ..... ret = of_address_to_resource(np, 0, ®s); if (ret) - return ERR_PTR(ret); + return (void __iomem *)ERR_PTR(ret); However, other engineers said that "(void __iomem *)ERR_PTR(ret)" is not a general pattern. I cannot find the proper method to resolve this sparse warning. In this case, how can I resolve this sparse warning? Then, how about the following? Thank you for reading this. :-) Best regards, Jingoo Han --- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/pci/host/pci-mvebu.c +++ b/drivers/pci/host/pci-mvebu.c @@ -740,7 +740,7 @@ static void __iomem *mvebu_pcie_map_registers(struct platform_device *pdev, ret = of_address_to_resource(np, 0, ®s); if (ret) - return ERR_PTR(ret); + return NULL; return devm_ioremap_resource(&pdev->dev, ®s); } @@ -939,7 +939,7 @@ static int mvebu_pcie_probe(struct platform_device *pdev) continue; port->base = mvebu_pcie_map_registers(pdev, child, port); - if (IS_ERR(port->base)) { + if (IS_ERR_OR_NULL(port->base)) { dev_err(&pdev->dev, "PCIe%d.%d: cannot map registers\n", port->port, port->lane); port->base = NULL;