mbox series

[v1,0/3] PCI: Fix failure to assign BARs with alignment >1M with Thunderbolt

Message ID PSXP216MB0438243F9C310CC98AF402F3803C0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM
Headers show
Series PCI: Fix failure to assign BARs with alignment >1M with Thunderbolt | expand

Message

Nicholas Johnson Jan. 6, 2020, 3:45 p.m. UTC 
This patch series is split from from [0] to make sign-off easier.

I have found a way to change the arguments of 
pci_bus_distribute_available_resources() without making any functional 
changes. I think it turned out very well. I hope everybody agrees.

I have tested and looked over for mistakes for several days, but there 
could still be mistakes. I have also changed the commit messages and 
might not be clear enough yet.

Best to get it out there and get feedback or it will never happen.

Removed Reviewed-by tags from Mika Westerberg because some things have 
changed.

[0]
https://lore.kernel.org/lkml/PSXP216MB043892C04178AB333F7AF08C80580@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM/

Nicholas Johnson (3):
  PCI: Remove redundant brackets in
    pci_bus_distribute_available_resources()
  PCI: Change pci_bus_distribute_available_resources() args to struct
    resource
  PCI: Consider alignment of hot-added bridges when distributing
    available resources

 drivers/pci/setup-bus.c | 106 +++++++++++++++++++++++-----------------
 1 file changed, 61 insertions(+), 45 deletions(-)

Comments

Mika Westerberg Jan. 13, 2020, 2:12 p.m. UTC | #1 
Hi,

On Mon, Jan 06, 2020 at 03:45:09PM +0000, Nicholas Johnson wrote:
> This patch series is split from from [0] to make sign-off easier.
> 
> I have found a way to change the arguments of 
> pci_bus_distribute_available_resources() without making any functional 
> changes. I think it turned out very well. I hope everybody agrees.
> 
> I have tested and looked over for mistakes for several days, but there 
> could still be mistakes. I have also changed the commit messages and 
> might not be clear enough yet.
> 
> Best to get it out there and get feedback or it will never happen.
> 
> Removed Reviewed-by tags from Mika Westerberg because some things have 
> changed.

In future it would be nice to spell out what exactly was changed since
the previous version so I don't have to dig that out and figure it out
myself.

This time it's fine :)