mbox series

[v2,0/4] pci_epf_alloc_space() cleanups

Message ID 20240207213922.1796533-1-cassel@kernel.org
Headers show
Series pci_epf_alloc_space() cleanups | expand

Message

Niklas Cassel Feb. 7, 2024, 9:39 p.m. UTC
Hello all,

Here comes some cleanups related to pci_epf_alloc_space().

Changes since v1:
-Picked up Reviewed-by tags.
-Fixed kdoc param name to match the actual param name in patch 1/4.
-Split patch "improve pci_epf_alloc_space()" into one patch changing
 pci-epf-core.c (patch 2/4 in V2) and pci-epf-test (patch 3/4 in V2).
-Perform the alignment even for fixed size BARs. We need this since:
 1) Some platforms have fixed_size_bars that are smaller than the
    iATU MIN REGION.
 2) No longer doing so would be a functional change and not a cleanup.


Kind regards,
Niklas


Niklas Cassel (4):
  PCI: endpoint: refactor pci_epf_alloc_space()
  PCI: endpoint: improve pci_epf_alloc_space()
  PCI: endpoint: pci-epf-test: remove superfluous checks
  PCI: endpoint: pci-epf-vntb: remove superfluous checks

 drivers/pci/endpoint/functions/pci-epf-ntb.c  |  2 +-
 drivers/pci/endpoint/functions/pci-epf-test.c | 13 ++-----------
 drivers/pci/endpoint/functions/pci-epf-vntb.c | 15 ++-------------
 drivers/pci/endpoint/pci-epf-core.c           | 15 +++++++++++++--
 include/linux/pci-epf.h                       |  4 +++-
 5 files changed, 21 insertions(+), 28 deletions(-)

Comments

Frank Li Feb. 7, 2024, 10:23 p.m. UTC | #1
On Wed, Feb 07, 2024 at 10:39:13PM +0100, Niklas Cassel wrote:
> Hello all,
> 
> Here comes some cleanups related to pci_epf_alloc_space().
> 
> Changes since v1:
> -Picked up Reviewed-by tags.
> -Fixed kdoc param name to match the actual param name in patch 1/4.
> -Split patch "improve pci_epf_alloc_space()" into one patch changing
>  pci-epf-core.c (patch 2/4 in V2) and pci-epf-test (patch 3/4 in V2).
> -Perform the alignment even for fixed size BARs. We need this since:
>  1) Some platforms have fixed_size_bars that are smaller than the
>     iATU MIN REGION.
>  2) No longer doing so would be a functional change and not a cleanup.
> 

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> 
> Kind regards,
> Niklas
> 
> 
> Niklas Cassel (4):
>   PCI: endpoint: refactor pci_epf_alloc_space()
>   PCI: endpoint: improve pci_epf_alloc_space()
>   PCI: endpoint: pci-epf-test: remove superfluous checks
>   PCI: endpoint: pci-epf-vntb: remove superfluous checks
> 
>  drivers/pci/endpoint/functions/pci-epf-ntb.c  |  2 +-
>  drivers/pci/endpoint/functions/pci-epf-test.c | 13 ++-----------
>  drivers/pci/endpoint/functions/pci-epf-vntb.c | 15 ++-------------
>  drivers/pci/endpoint/pci-epf-core.c           | 15 +++++++++++++--
>  include/linux/pci-epf.h                       |  4 +++-
>  5 files changed, 21 insertions(+), 28 deletions(-)
> 
> -- 
> 2.43.0
>
Manivannan Sadhasivam Feb. 9, 2024, 8:51 a.m. UTC | #2
On Wed, Feb 07, 2024 at 10:39:13PM +0100, Niklas Cassel wrote:
> Hello all,
> 
> Here comes some cleanups related to pci_epf_alloc_space().
> 

Applied to pci/endpoint!

- Mani

> Changes since v1:
> -Picked up Reviewed-by tags.
> -Fixed kdoc param name to match the actual param name in patch 1/4.
> -Split patch "improve pci_epf_alloc_space()" into one patch changing
>  pci-epf-core.c (patch 2/4 in V2) and pci-epf-test (patch 3/4 in V2).
> -Perform the alignment even for fixed size BARs. We need this since:
>  1) Some platforms have fixed_size_bars that are smaller than the
>     iATU MIN REGION.
>  2) No longer doing so would be a functional change and not a cleanup.
> 
> 
> Kind regards,
> Niklas
> 
> 
> Niklas Cassel (4):
>   PCI: endpoint: refactor pci_epf_alloc_space()
>   PCI: endpoint: improve pci_epf_alloc_space()
>   PCI: endpoint: pci-epf-test: remove superfluous checks
>   PCI: endpoint: pci-epf-vntb: remove superfluous checks
> 
>  drivers/pci/endpoint/functions/pci-epf-ntb.c  |  2 +-
>  drivers/pci/endpoint/functions/pci-epf-test.c | 13 ++-----------
>  drivers/pci/endpoint/functions/pci-epf-vntb.c | 15 ++-------------
>  drivers/pci/endpoint/pci-epf-core.c           | 15 +++++++++++++--
>  include/linux/pci-epf.h                       |  4 +++-
>  5 files changed, 21 insertions(+), 28 deletions(-)
> 
> -- 
> 2.43.0
>