mbox series

[v1,0/2] PCI: dwc: Remove the delay from PCIe probe path

Message ID 20240124092533.1267836-1-ajayagarwal@google.com
Headers show
Series PCI: dwc: Remove the delay from PCIe probe path | expand

Message

Ajay Agarwal Jan. 24, 2024, 9:25 a.m. UTC 
dw_pcie_host_init() waits for the link to come up regardless of
whether there has been an attempt to start the link. The 1 second
wait time is wasteful. Get rid of it if .start_link() is not
defined.

Ajay Agarwal (2):
  PCI: dwc: Add helper function to print link status
  PCI: dwc: Wait for link up only if link is started

 .../pci/controller/dwc/pcie-designware-host.c | 12 +++++++----
 drivers/pci/controller/dwc/pcie-designware.c  | 20 ++++++++++++-------
 drivers/pci/controller/dwc/pcie-designware.h  |  1 +
 3 files changed, 22 insertions(+), 11 deletions(-)

Comments

Manivannan Sadhasivam Jan. 29, 2024, 6:23 a.m. UTC | #1 
On Wed, Jan 24, 2024 at 02:55:31PM +0530, Ajay Agarwal wrote:
> dw_pcie_host_init() waits for the link to come up regardless of
> whether there has been an attempt to start the link. The 1 second
> wait time is wasteful. Get rid of it if .start_link() is not
> defined.
> 

Where is the changelog? Reviewers will first take a look at the cover letter to
understand the series. And this doesn't convey full information (history).

- Mani

> Ajay Agarwal (2):
>   PCI: dwc: Add helper function to print link status
>   PCI: dwc: Wait for link up only if link is started
> 
>  .../pci/controller/dwc/pcie-designware-host.c | 12 +++++++----
>  drivers/pci/controller/dwc/pcie-designware.c  | 20 ++++++++++++-------
>  drivers/pci/controller/dwc/pcie-designware.h  |  1 +
>  3 files changed, 22 insertions(+), 11 deletions(-)
> 
> -- 
> 2.43.0.429.g432eaa2c6b-goog
>