From patchwork Tue Jan 10 16:56:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alvaro Karsz X-Patchwork-Id: 1724201 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=solid-run-com.20210112.gappssmtp.com header.i=@solid-run-com.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=RTCvlCJ6; dkim-atps=neutral Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4Nrxn265QBz23g2 for ; Wed, 11 Jan 2023 03:57:10 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234848AbjAJQ5H (ORCPT ); Tue, 10 Jan 2023 11:57:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234798AbjAJQ44 (ORCPT ); Tue, 10 Jan 2023 11:56:56 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43BC2CF3 for ; Tue, 10 Jan 2023 08:56:55 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id e3so3248413wru.13 for ; Tue, 10 Jan 2023 08:56:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=solid-run-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eegm6h5/4aiM1ctrp3XKGH5jYH2u1V5ZiNnFihk+Tvo=; b=RTCvlCJ6TqO8QFuoI+x/1khXGGuPtw1zPAY57G83xVroYLJc1p/b8Dz43z1Moa0+h8 ZbTiHRre8fhjQyN90jmdywE/6sPxRsgSb5MsRhPW2CzNHDRC7wTxY5/cev8E6qaymsD4 t8D+07bg9sa8/D4M9mboASKyvbGukNP6U9I+/oiNybBuPaSGcSjK+A2qyGuw/msXkErp c45DXW8HiuX7J/Ok70qo9IjCIH8Oz8cFhSnc/3/0aQeexKvPwibxS4IU+J0nRA3BGyPX HjEsqrtQDJl36OyyXPAETx4hCTunMP+1QJdp1abErz+QGvRoZDXdEAPvhLlD1UrqBKKt w9Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eegm6h5/4aiM1ctrp3XKGH5jYH2u1V5ZiNnFihk+Tvo=; b=reRQMdWAL+YdJ/EceAWBs3yxU9lMjxc3p6e1VfBd5lQNUR8/vntI2m7UH+5sDuMNXq pOqFUGyFkCFmBwi9jTcV8irMfNe7PT67x756NEi1qBh79CAxrBoqelLWZ3ozxnHhsbZc rREYEiUOjimOPID8b6Z+ExWzjn3kXxTRtwYPT6i7LcNLDs35TYmRKgc5KU/OIdzvJsp8 c1S8OqP6dp9Az0iFIh1IsWtR4u5bZjWPuyeCRXJtekG7cGX8NBx+LFoB/MErX7LziDeS 2F/KOrHl76xrrPVNByHi3o+1xXp1sycvxxlQfsoNFyOD6ToVxKUYZTGf7H6uh6M1mIQ1 x/jg== X-Gm-Message-State: AFqh2ko2nOBU0r98ef4Tgj+xE7n5ja3oT5FBAEeYpJ9ypGPPU3YHJzGr fKso400PcjAJ+3q4RwzRwBxvsOyZ9tnF/64s X-Google-Smtp-Source: AMrXdXvU3ASKi6xAOeOt/9PpjZP+UheShsILN5+rT/5Z8wsVqhoATjM4S2x99dbOzKylDESc9DHeSA== X-Received: by 2002:a5d:4591:0:b0:2b4:790e:32f8 with SMTP id p17-20020a5d4591000000b002b4790e32f8mr9396175wrq.48.1673369813017; Tue, 10 Jan 2023 08:56:53 -0800 (PST) Received: from localhost.localdomain (bzq-84-110-153-254.static-ip.bezeqint.net. [84.110.153.254]) by smtp.gmail.com with ESMTPSA id q11-20020adf9dcb000000b00268aae5fb5bsm11918066wre.3.2023.01.10.08.56.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 08:56:52 -0800 (PST) From: Alvaro Karsz To: linux-pci@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: mst@redhat.com, helgaas@kernel.org, Alvaro Karsz Subject: [PATCH v9 0/3] virtio: vdpa: new SolidNET DPU driver Date: Tue, 10 Jan 2023 18:56:35 +0200 Message-Id: <20230110165638.123745-1-alvaro.karsz@solid-run.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This series adds a vDPA driver for SolidNET DPU. Patch 1 adds SolidRun vendor ID to pci_ids. Patch 2 adds a PCI quirk needed by the DPU. Patch 3 has the driver source code. Patch 1 is prerequisite for both patch 2 and patch 3. v2: - Semantics fixes in commit log - Patch 1. - Move the vendor ID to the right place, sorted by vendor ID - Patch 1. - Update patch subject to be more meaningful and similar to previous quirks - Patch 2. - Update the commit log to describe better what the patch does - Patch 2. - Auto detect the BAR used for communication - Patch 3. - When waiting for the DPU to write a config, wait for 5secs before giving up on the device - Patch 3. - Return EOPNOTSUPP error code in vDPA set_vq_state callback if the vq state is not the same as the initial one - Patch 3. - Implement a vDPA reset callback - Patch 3. - Wait for an ACK when sending a message to the DPU - Patch 3. - Add endianness comments on 64bit read/write functions - Patch 3. - Remove the get_iova_range and free vDPA callbacks - Patch 3. - Usage of managed device functions to ioremap a region - Patch 3. - Call pci_set_drvdata and pci_set_master before vdpa_register_device - Patch 3. - Create DMA isolation between the vDPA devices by using the chip SR-IOV feature. Every vDPA device gets a PCIe VF with its own DMA device - Patch 3. v3: - Validate vDPA config length while receiving the DPU's config, not while trying to write the vDPA config to the DPU - Patch 3. - Request IRQs when vDPA status is set to VIRTIO_CONFIG_S_DRIVER_OK - Patch 3. - Remove snet_reset_dev() from the PCI remove function for a VF - Patch 3. v4: - Get SolidRun vendor ID from pci_ids - Patch 3. v5: - Remove "select HWMON" from Kconfig. Usage of "depends on HWMON || HWMON=n" instead and usage of IS_ENABLED(CONFIG_HWMON) when calling to snet hwmon functions. snet_hwmon.c is compiled only if CONFIG_HWMON is defined - Patch 3. - Remove the #include from snet_hwmon.c - Patch 3. - Remove the unnecessary (long) casting from snet_hwmon_read_reg - Patch 3. - Remove the "_hwmon" ending from the hwmon name - Patch 3. - Usage of IS_ERR macro to check if devm_hwmon_device_register_with_info failed - Patch 3. - Replace schedule() with usleep_range() in the "hot loop" in psnet_detect_bar - Patch 3. - Remove the logging of memory allocation failures - Patch 3. - Add parenthesis to arguments in SNET_* macros - Patch 3. - Prefer sizeof(*variable) instead of sizeof(struct x) when allocating memory - Patch 3. v6: - SNET_WRN -> SNET_WARN - Patch 3. v7: - Explain the dependency of SNET_VDPA on HWMON in Kconfig - Patch 3. - Fix snprintf size argument in psnet_open_pf_bar and snet_open_vf_bar - Patch 3. - Fix kernel warning in snet_vdpa_remove_vf. Call pci_free_irq_vectors after vdpa_unregister_device, otherwise we'll get "remove_proc_entry: removing non-empty directory 'irq/..', leaking at least '..'" warnings - Patch 3. - Remove the psnet_create_hwmon function empty definition if HWMON is not enabled, otherwise, we'll get "warning: no previous prototype for 'psnet_create_hwmon'" when compiling with W=1. This was reported by kernel test robot - Patch 3. v8: - Fix the series versioning. I updated the versions of every patch separately, which seems to be wrong. v9: - Indent PCI id in pci_ids.h with tabs - Patch 1. - Wrap patch comment log to fill 75 columns - Patch 1 + 2. Alvaro Karsz (3): PCI: Add SolidRun vendor ID PCI: Avoid FLR for SolidRun SNET DPU rev 1 virtio: vdpa: new SolidNET DPU driver. MAINTAINERS | 4 + drivers/pci/quirks.c | 8 + drivers/vdpa/Kconfig | 18 + drivers/vdpa/Makefile | 1 + drivers/vdpa/solidrun/Makefile | 6 + drivers/vdpa/solidrun/snet_hwmon.c | 188 +++++ drivers/vdpa/solidrun/snet_main.c | 1110 ++++++++++++++++++++++++++++ drivers/vdpa/solidrun/snet_vdpa.h | 194 +++++ include/linux/pci_ids.h | 2 + 9 files changed, 1531 insertions(+) create mode 100644 drivers/vdpa/solidrun/Makefile create mode 100644 drivers/vdpa/solidrun/snet_hwmon.c create mode 100644 drivers/vdpa/solidrun/snet_main.c create mode 100644 drivers/vdpa/solidrun/snet_vdpa.h