mbox series

[0/3] Enclosure sysfs refactor

Message ID 20221117163407.28472-1-mariusz.tkaczyk@linux.intel.com
Headers show
Series Enclosure sysfs refactor | expand

Message

Mariusz Tkaczyk Nov. 17, 2022, 4:34 p.m. UTC 
Hi Bjorn,
I agreed with Stuart to take over the NPEM implementation[1].
First part I want to share is a small refactor around enclosure interface.

The one sysfs change introduced is changing active LED to write-only.
get_active() callback is not implemented for SES which is the
only one enclosure API consumer now.

[1] https://lore.kernel.org/linux-pci/cover.1643822289.git.stuart.w.hayes@gmail.com/

Mariusz Tkaczyk (3):
  misc: enclosure: remove get_active() callback
  misc: enclosure, ses: simplify some get callbacks
  misc: enclosure: update sysfs api

 drivers/misc/enclosure.c  | 96 ++++++++++++++++-----------------------
 drivers/scsi/ses.c        | 33 ++++++++------
 include/linux/enclosure.h | 14 ++----
 3 files changed, 61 insertions(+), 82 deletions(-)

Comments

Mariusz Tkaczyk May 4, 2023, 12:10 p.m. UTC | #1 
On Thu, 17 Nov 2022 17:34:04 +0100
Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> wrote:

> Hi Bjorn,
> I agreed with Stuart to take over the NPEM implementation[1].
> First part I want to share is a small refactor around enclosure interface.
> 
> The one sysfs change introduced is changing active LED to write-only.
> get_active() callback is not implemented for SES which is the
> only one enclosure API consumer now.
> 
> [1]
> https://lore.kernel.org/linux-pci/cover.1643822289.git.stuart.w.hayes@gmail.com/
> 
> Mariusz Tkaczyk (3):
>   misc: enclosure: remove get_active() callback
>   misc: enclosure, ses: simplify some get callbacks
>   misc: enclosure: update sysfs api
> 
>  drivers/misc/enclosure.c  | 96 ++++++++++++++++-----------------------
>  drivers/scsi/ses.c        | 33 ++++++++------
>  include/linux/enclosure.h | 14 ++----
>  3 files changed, 61 insertions(+), 82 deletions(-)
> 

Hi Bjorn,
Could you please take a look? Let me know if you against this cleanup.
I would like to get back to NPEM, I based my patches on top of it.

Thanks,
Mariusz
Dan Williams May 4, 2023, 5:16 p.m. UTC | #2 
Mariusz Tkaczyk wrote:
> On Thu, 17 Nov 2022 17:34:04 +0100
> Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> wrote:
> 
> > Hi Bjorn,
> > I agreed with Stuart to take over the NPEM implementation[1].
> > First part I want to share is a small refactor around enclosure interface.
> > 
> > The one sysfs change introduced is changing active LED to write-only.
> > get_active() callback is not implemented for SES which is the
> > only one enclosure API consumer now.
> > 
> > [1]
> > https://lore.kernel.org/linux-pci/cover.1643822289.git.stuart.w.hayes@gmail.com/
> > 
> > Mariusz Tkaczyk (3):
> >   misc: enclosure: remove get_active() callback
> >   misc: enclosure, ses: simplify some get callbacks
> >   misc: enclosure: update sysfs api
> > 
> >  drivers/misc/enclosure.c  | 96 ++++++++++++++++-----------------------
> >  drivers/scsi/ses.c        | 33 ++++++++------
> >  include/linux/enclosure.h | 14 ++----
> >  3 files changed, 61 insertions(+), 82 deletions(-)
> > 
> 
> Hi Bjorn,
> Could you please take a look? Let me know if you against this cleanup.
> I would like to get back to NPEM, I based my patches on top of it.

Hi Mariusz,

I don't expect Bjorn to handle enclosure updates. I expect the upstream
path for these patches is through the SCSI tree. Going forward you can
use get_maintainer.pl for this routing information.

$ ./scripts/get_maintainer.pl drivers/scsi/ses.c 
"James E.J. Bottomley" <jejb@linux.ibm.com> (maintainer:SCSI SUBSYSTEM)
"Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
linux-scsi@vger.kernel.org (open list:SCSI SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)

I'll take a look and then you can resend to linux-scsi. I do like this
stat line:

3 files changed, 61 insertions(+), 82 deletions(-)

...makes it compelling to take a look.
Mariusz Tkaczyk May 5, 2023, 9:12 a.m. UTC | #3 
On Thu, 4 May 2023 10:16:36 -0700
Dan Williams <dan.j.williams@intel.com> wrote:

> Mariusz Tkaczyk wrote:
> > On Thu, 17 Nov 2022 17:34:04 +0100
> > Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> wrote:
> >   
> > > Hi Bjorn,
> > > I agreed with Stuart to take over the NPEM implementation[1].
> > > First part I want to share is a small refactor around enclosure interface.
> > > 
> > > The one sysfs change introduced is changing active LED to write-only.
> > > get_active() callback is not implemented for SES which is the
> > > only one enclosure API consumer now.
> > > 
> > > [1]
> > > https://lore.kernel.org/linux-pci/cover.1643822289.git.stuart.w.hayes@gmail.com/
> > > 
> > > Mariusz Tkaczyk (3):
> > >   misc: enclosure: remove get_active() callback
> > >   misc: enclosure, ses: simplify some get callbacks
> > >   misc: enclosure: update sysfs api
> > > 
> > >  drivers/misc/enclosure.c  | 96 ++++++++++++++++-----------------------
> > >  drivers/scsi/ses.c        | 33 ++++++++------
> > >  include/linux/enclosure.h | 14 ++----
> > >  3 files changed, 61 insertions(+), 82 deletions(-)
> > >   
> > 
> > Hi Bjorn,
> > Could you please take a look? Let me know if you against this cleanup.
> > I would like to get back to NPEM, I based my patches on top of it.  
> 
> Hi Mariusz,
> 
> I don't expect Bjorn to handle enclosure updates. I expect the upstream
> path for these patches is through the SCSI tree. Going forward you can
> use get_maintainer.pl for this routing information.
> 
> $ ./scripts/get_maintainer.pl drivers/scsi/ses.c 
> "James E.J. Bottomley" <jejb@linux.ibm.com> (maintainer:SCSI SUBSYSTEM)
> "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
> linux-scsi@vger.kernel.org (open list:SCSI SUBSYSTEM)
> linux-kernel@vger.kernel.org (open list)
> 
> I'll take a look and then you can resend to linux-scsi. I do like this
> stat line:
> 
> 3 files changed, 61 insertions(+), 82 deletions(-)
> 
> ...makes it compelling to take a look.

Ohh...my bad. Apologize for noise. Thanks Dan for clarification.

Mariusz