From patchwork Thu Mar 24 01:37:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 1610263 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=baikalelectronics.ru header.i=@baikalelectronics.ru header.a=rsa-sha256 header.s=mail header.b=kOf+tkyS; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by bilbo.ozlabs.org (Postfix) with ESMTP id 4KRxLr13Ryz9sDX for ; Tue, 29 Mar 2022 02:24:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236949AbiC1PZz (ORCPT ); Mon, 28 Mar 2022 11:25:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236621AbiC1PZw (ORCPT ); Mon, 28 Mar 2022 11:25:52 -0400 Received: from mail.baikalelectronics.ru (mail.baikalelectronics.com [87.245.175.226]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 70F821FA55; Mon, 28 Mar 2022 08:24:11 -0700 (PDT) Received: from mail.baikalelectronics.ru (unknown [192.168.51.25]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 4FFBD39CB77; Thu, 24 Mar 2022 04:37:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.baikalelectronics.ru 4FFBD39CB77 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baikalelectronics.ru; s=mail; t=1648085867; bh=npWKFXQ+aTKYA0rxtP23gRryMV+pcKHHgb+hcyLfZ4w=; h=From:To:CC:Subject:Date:From; b=kOf+tkySlXIFnWE76NhNYeGggWB3++KRdK2KZy+slEWPKWi9SZKWX39a35HdvMqF9 e1AkiR+80qSZjwU2nZemuN1dGr04jfson8tNH/QLd4ID/OAnegtkUZrYbd8uXUJlJP ZB0xMu0xMqWO2BqfPW4odfNykdGAxyneUJJypUys= Received: from localhost (192.168.168.10) by mail (192.168.51.25) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 24 Mar 2022 04:37:47 +0300 From: Serge Semin To: Jingoo Han , Gustavo Pimentel , Bjorn Helgaas CC: Serge Semin , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Lorenzo Pieralisi , Rob Herring , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Frank Li , Manivannan Sadhasivam , Rob Herring , , , Subject: [PATCH 00/16] PCI: dwc: Add dma-ranges/YAML-schema/Baikal-T1 support Date: Thu, 24 Mar 2022 04:37:18 +0300 Message-ID: <20220324013734.18234-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This patchset is a third one in the series created in the framework of my Baikal-T1 PCIe/eDMA-related work: [1: In-progress] clk: Baikal-T1 DDR/PCIe resets and some xGMAC fixes Link: --submitted-- [2: In-progress] PCI: dwc: Various fixes and cleanups Link: --submitted-- [3: In-progress] PCI: dwc: Add dma-ranges/YAML-schema/Baikal-T1 support Link: --you are looking at it-- [4: Stalling] dmaengine: dw-edma: Add RP/EP local DMA controllers support Link: --being submitted afterwards-- Note it is very recommended to merge the patchsets in the same order as they are listed in the set above in order to have them applied smoothly. Nothing prevents them from being reviewed synchronously though. This series is about adding new features to the DW PCIe Host/End-point driver. First of all we start from splitting up the DT-bindings into common properties schema and generic DW PCIe bindings definition. It's done to support the generic DW PCIe Host/End-point available platforms with adding a common YAML-schema to be reused by the platform-specific DW PCIe bindings. @Rob could you please take a look at that patch? I've got a problem with dt_bindings_check-ing the schema which is likely caused by the dt-schema parser misbehaviour. After that we suggest to add a more verbose link-up log message. Really printing link generation and width would be much more informative than just "link up". Then a series of IP-core version-related patches go, like using a native FourCC version representation, adding the IP-core auto-detection, adding better structured IP-core version/type interface. After that the platform-specific host de-initialization method is introduced. A series of iATU optimizations, cleanups and new features goes afterwards. In particular we suggest to drop some redundant enumerations, add iATU regions size detection procedure and then use the regions parameters to verify the requested by the platform iATU ranges/dma-ranges settings. After that the dma-ranges property support is added for the DW PCIe Host controllers. Then a structured set of the DW PCIe RP/EP specific clocks and resets names/IDs is introduced so to be re-used by the generic and new platforms. Note it is fully coherent with the DW PCIe controller manuals (see the patch log for details). Also note the patch doesn't affect the already available DW PCIe platform-specific code since it would be too risky for my to do the corresponding conversion, but the maintainers are welcome to do that. Finally at the series closure we introduce the Baikal-T1 PCIe interface support, which uses all the recently added features including the set of the generic clocks and resets names. Signed-off-by: Serge Semin Cc: Alexey Malahov Cc: Pavel Parkhomenko Cc: Lorenzo Pieralisi Cc: Rob Herring Cc: "Krzysztof Wilczyński" Cc: Frank Li Cc: Manivannan Sadhasivam Cc: Rob Herring Cc: linux-pci@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Serge Semin (16): dt-bindings: PCI: dwc: Define generic and native DT bindings dt-bindings: PCI: dwc: Add Baikal-T1 PCIe Root Port bindings PCI: dwc: Add more verbose link-up message PCI: dwc: Convert to using native IP-core versions representation PCI: dwc: Add IP-core version detection procedure PCI: dwc: Introduce Synopsys IP-core versions/types interface PCI: dwc: Add host de-initialization callback PCI: dwc: Drop inbound iATU types enumeration - dw_pcie_as_type PCI: dwc: Simplify in/outbound iATU setup methods PCI: dwc: Drop iATU regions enumeration - dw_pcie_region_type PCI: dwc: Add iATU regions size detection procedure PCI: dwc: Verify in/out regions against iATU constraints PCI: dwc: Check iATU in/outbound ranges setup methods status PCI: dwc: Introduce dma-ranges property support for RC-host PCI: dwc: Introduce generic platform clocks and resets sets PCI: dwc: Add Baikal-T1 PCIe controller support .../bindings/pci/baikal,bt1-pcie.yaml | 148 ++++ .../bindings/pci/fsl,imx6q-pcie.yaml | 5 +- .../bindings/pci/hisilicon,kirin-pcie.yaml | 4 +- .../bindings/pci/sifive,fu740-pcie.yaml | 4 +- .../bindings/pci/snps,dw-pcie-common.yaml | 298 ++++++++ .../bindings/pci/snps,dw-pcie-ep.yaml | 143 ++-- .../devicetree/bindings/pci/snps,dw-pcie.yaml | 189 ++++-- .../bindings/pci/toshiba,visconti-pcie.yaml | 2 +- drivers/pci/controller/dwc/Kconfig | 9 + drivers/pci/controller/dwc/Makefile | 1 + drivers/pci/controller/dwc/pci-keystone.c | 12 +- drivers/pci/controller/dwc/pcie-bt1.c | 638 ++++++++++++++++++ .../pci/controller/dwc/pcie-designware-ep.c | 36 +- .../pci/controller/dwc/pcie-designware-host.c | 198 ++++-- drivers/pci/controller/dwc/pcie-designware.c | 465 ++++++------- drivers/pci/controller/dwc/pcie-designware.h | 200 ++++-- drivers/pci/controller/dwc/pcie-intel-gw.c | 10 +- drivers/pci/controller/dwc/pcie-tegra194.c | 2 +- 18 files changed, 1857 insertions(+), 507 deletions(-) create mode 100644 Documentation/devicetree/bindings/pci/baikal,bt1-pcie.yaml create mode 100644 Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml create mode 100644 drivers/pci/controller/dwc/pcie-bt1.c