mbox series

[v7,00/12] Multiple fixes in PCIe qcom driver

Message ID 20200615210608.21469-1-ansuelsmth@gmail.com
Headers show
Series Multiple fixes in PCIe qcom driver | expand

Message

Ansuel Smith June 15, 2020, 9:05 p.m. UTC
This contains multiple fix for PCIe qcom driver.
Some optional reset and clocks were missing.
Fix a problem with no PARF programming that cause kernel lock on load.
Add support to force gen 1 speed if needed. (due to hardware limitation)
Add ipq8064 rev 2 support that use a different tx termination offset.

v7:
* Rework GEN1 patch

v6:
* Replace custom define
* Move define not used in 07 to 08

v5:
* Split PCI: qcom: Add ipq8064 rev2 variant and set tx term offset

v4:
* Fix grammar error across all patch subject
* Use bulk api for clks
* Program PARF only in ipq8064 SoC
* Program tx term only in ipq8064 SoC
* Drop configurable tx-dempth rx-eq
* Make added clk optional

v3:
* Fix check reported by checkpatch --strict
* Rename force_gen1 to gen

v2:
* Drop iATU programming (already done in pcie init)
* Use max-link-speed instead of force-gen1 custom definition
* Drop MRRS to 256B (Can't find a realy reason why this was suggested)
* Introduce a new variant for different revision of ipq8064

Abhishek Sahu (1):
  PCI: qcom: Change duplicate PCI reset to phy reset

Ansuel Smith (10):
  PCI: qcom: Add missing ipq806x clocks in PCIe driver
  dt-bindings: PCI: qcom: Add missing clks
  PCI: qcom: Add missing reset for ipq806x
  dt-bindings: PCI: qcom: Add ext reset
  PCI: qcom: Use bulk clk api and assert on error
  PCI: qcom: Define some PARF params needed for ipq8064 SoC
  PCI: qcom: Add support for tx term offset for rev 2.1.0
  PCI: qcom: Add ipq8064 rev2 variant
  dt-bindings: PCI: qcom: Add ipq8064 rev 2 variant
  PCI: qcom: Replace define with standard value

Sham Muthayyan (1):
  PCI: qcom: Support pci speed set for ipq806x

 .../devicetree/bindings/pci/qcom,pcie.txt     |  15 +-
 drivers/pci/controller/dwc/pcie-qcom.c        | 186 +++++++++++-------
 2 files changed, 128 insertions(+), 73 deletions(-)

Comments

Stanimir Varbanov June 25, 2020, 11:37 p.m. UTC | #1
Hi Ansuel,

Thank you for the patience.

On 6/16/20 12:05 AM, Ansuel Smith wrote:
> This contains multiple fix for PCIe qcom driver.
> Some optional reset and clocks were missing.
> Fix a problem with no PARF programming that cause kernel lock on load.
> Add support to force gen 1 speed if needed. (due to hardware limitation)
> Add ipq8064 rev 2 support that use a different tx termination offset.
> 
> v7:
> * Rework GEN1 patch
> 
> v6:
> * Replace custom define
> * Move define not used in 07 to 08
> 
> v5:
> * Split PCI: qcom: Add ipq8064 rev2 variant and set tx term offset
> 
> v4:
> * Fix grammar error across all patch subject
> * Use bulk api for clks
> * Program PARF only in ipq8064 SoC
> * Program tx term only in ipq8064 SoC
> * Drop configurable tx-dempth rx-eq
> * Make added clk optional
> 
> v3:
> * Fix check reported by checkpatch --strict
> * Rename force_gen1 to gen
> 
> v2:
> * Drop iATU programming (already done in pcie init)
> * Use max-link-speed instead of force-gen1 custom definition
> * Drop MRRS to 256B (Can't find a realy reason why this was suggested)
> * Introduce a new variant for different revision of ipq8064
> 
> Abhishek Sahu (1):
>   PCI: qcom: Change duplicate PCI reset to phy reset
> 
> Ansuel Smith (10):
>   PCI: qcom: Add missing ipq806x clocks in PCIe driver
>   dt-bindings: PCI: qcom: Add missing clks
>   PCI: qcom: Add missing reset for ipq806x
>   dt-bindings: PCI: qcom: Add ext reset
>   PCI: qcom: Use bulk clk api and assert on error
>   PCI: qcom: Define some PARF params needed for ipq8064 SoC
>   PCI: qcom: Add support for tx term offset for rev 2.1.0
>   PCI: qcom: Add ipq8064 rev2 variant
>   dt-bindings: PCI: qcom: Add ipq8064 rev 2 variant
>   PCI: qcom: Replace define with standard value
> 
> Sham Muthayyan (1):
>   PCI: qcom: Support pci speed set for ipq806x
> 
>  .../devicetree/bindings/pci/qcom,pcie.txt     |  15 +-
>  drivers/pci/controller/dwc/pcie-qcom.c        | 186 +++++++++++-------
>  2 files changed, 128 insertions(+), 73 deletions(-)
> 

For the whole set:

Acked-by: Stanimir Varbanov <svarbanov@mm-sol.com>
Lorenzo Pieralisi July 7, 2020, 2:05 p.m. UTC | #2
On Mon, Jun 15, 2020 at 11:05:56PM +0200, Ansuel Smith wrote:
> This contains multiple fix for PCIe qcom driver.
> Some optional reset and clocks were missing.
> Fix a problem with no PARF programming that cause kernel lock on load.
> Add support to force gen 1 speed if needed. (due to hardware limitation)
> Add ipq8064 rev 2 support that use a different tx termination offset.
> 
> v7:
> * Rework GEN1 patch
> 
> v6:
> * Replace custom define
> * Move define not used in 07 to 08
> 
> v5:
> * Split PCI: qcom: Add ipq8064 rev2 variant and set tx term offset
> 
> v4:
> * Fix grammar error across all patch subject
> * Use bulk api for clks
> * Program PARF only in ipq8064 SoC
> * Program tx term only in ipq8064 SoC
> * Drop configurable tx-dempth rx-eq
> * Make added clk optional
> 
> v3:
> * Fix check reported by checkpatch --strict
> * Rename force_gen1 to gen
> 
> v2:
> * Drop iATU programming (already done in pcie init)
> * Use max-link-speed instead of force-gen1 custom definition
> * Drop MRRS to 256B (Can't find a realy reason why this was suggested)
> * Introduce a new variant for different revision of ipq8064
> 
> Abhishek Sahu (1):
>   PCI: qcom: Change duplicate PCI reset to phy reset
> 
> Ansuel Smith (10):
>   PCI: qcom: Add missing ipq806x clocks in PCIe driver
>   dt-bindings: PCI: qcom: Add missing clks
>   PCI: qcom: Add missing reset for ipq806x
>   dt-bindings: PCI: qcom: Add ext reset
>   PCI: qcom: Use bulk clk api and assert on error
>   PCI: qcom: Define some PARF params needed for ipq8064 SoC
>   PCI: qcom: Add support for tx term offset for rev 2.1.0
>   PCI: qcom: Add ipq8064 rev2 variant
>   dt-bindings: PCI: qcom: Add ipq8064 rev 2 variant
>   PCI: qcom: Replace define with standard value
> 
> Sham Muthayyan (1):
>   PCI: qcom: Support pci speed set for ipq806x
> 
>  .../devicetree/bindings/pci/qcom,pcie.txt     |  15 +-
>  drivers/pci/controller/dwc/pcie-qcom.c        | 186 +++++++++++-------
>  2 files changed, 128 insertions(+), 73 deletions(-)

ACK missing on patches 8,9,12 please let me know how to proceed,
thanks.

Lorenzo
Stanimir Varbanov July 7, 2020, 2:57 p.m. UTC | #3
Hi Lorenzo,

On 7/7/20 5:05 PM, Lorenzo Pieralisi wrote:
> On Mon, Jun 15, 2020 at 11:05:56PM +0200, Ansuel Smith wrote:
>> This contains multiple fix for PCIe qcom driver.
>> Some optional reset and clocks were missing.
>> Fix a problem with no PARF programming that cause kernel lock on load.
>> Add support to force gen 1 speed if needed. (due to hardware limitation)
>> Add ipq8064 rev 2 support that use a different tx termination offset.
>>
>> v7:
>> * Rework GEN1 patch
>>
>> v6:
>> * Replace custom define
>> * Move define not used in 07 to 08
>>
>> v5:
>> * Split PCI: qcom: Add ipq8064 rev2 variant and set tx term offset
>>
>> v4:
>> * Fix grammar error across all patch subject
>> * Use bulk api for clks
>> * Program PARF only in ipq8064 SoC
>> * Program tx term only in ipq8064 SoC
>> * Drop configurable tx-dempth rx-eq
>> * Make added clk optional
>>
>> v3:
>> * Fix check reported by checkpatch --strict
>> * Rename force_gen1 to gen
>>
>> v2:
>> * Drop iATU programming (already done in pcie init)
>> * Use max-link-speed instead of force-gen1 custom definition
>> * Drop MRRS to 256B (Can't find a realy reason why this was suggested)
>> * Introduce a new variant for different revision of ipq8064
>>
>> Abhishek Sahu (1):
>>   PCI: qcom: Change duplicate PCI reset to phy reset
>>
>> Ansuel Smith (10):
>>   PCI: qcom: Add missing ipq806x clocks in PCIe driver
>>   dt-bindings: PCI: qcom: Add missing clks
>>   PCI: qcom: Add missing reset for ipq806x
>>   dt-bindings: PCI: qcom: Add ext reset
>>   PCI: qcom: Use bulk clk api and assert on error
>>   PCI: qcom: Define some PARF params needed for ipq8064 SoC
>>   PCI: qcom: Add support for tx term offset for rev 2.1.0
>>   PCI: qcom: Add ipq8064 rev2 variant
>>   dt-bindings: PCI: qcom: Add ipq8064 rev 2 variant
>>   PCI: qcom: Replace define with standard value
>>
>> Sham Muthayyan (1):
>>   PCI: qcom: Support pci speed set for ipq806x
>>
>>  .../devicetree/bindings/pci/qcom,pcie.txt     |  15 +-
>>  drivers/pci/controller/dwc/pcie-qcom.c        | 186 +++++++++++-------
>>  2 files changed, 128 insertions(+), 73 deletions(-)
> 
> ACK missing on patches 8,9,12 please let me know how to proceed,
> thanks.

You could use my acked-by for them:

Acked-by: Stanimir Varbanov <svarbanov@mm-sol.com>

> 
> Lorenzo
>
Lorenzo Pieralisi July 7, 2020, 3:15 p.m. UTC | #4
On Mon, Jun 15, 2020 at 11:05:56PM +0200, Ansuel Smith wrote:
> This contains multiple fix for PCIe qcom driver.
> Some optional reset and clocks were missing.
> Fix a problem with no PARF programming that cause kernel lock on load.
> Add support to force gen 1 speed if needed. (due to hardware limitation)
> Add ipq8064 rev 2 support that use a different tx termination offset.
> 
> v7:
> * Rework GEN1 patch
> 
> v6:
> * Replace custom define
> * Move define not used in 07 to 08
> 
> v5:
> * Split PCI: qcom: Add ipq8064 rev2 variant and set tx term offset
> 
> v4:
> * Fix grammar error across all patch subject
> * Use bulk api for clks
> * Program PARF only in ipq8064 SoC
> * Program tx term only in ipq8064 SoC
> * Drop configurable tx-dempth rx-eq
> * Make added clk optional
> 
> v3:
> * Fix check reported by checkpatch --strict
> * Rename force_gen1 to gen
> 
> v2:
> * Drop iATU programming (already done in pcie init)
> * Use max-link-speed instead of force-gen1 custom definition
> * Drop MRRS to 256B (Can't find a realy reason why this was suggested)
> * Introduce a new variant for different revision of ipq8064
> 
> Abhishek Sahu (1):
>   PCI: qcom: Change duplicate PCI reset to phy reset
> 
> Ansuel Smith (10):
>   PCI: qcom: Add missing ipq806x clocks in PCIe driver
>   dt-bindings: PCI: qcom: Add missing clks
>   PCI: qcom: Add missing reset for ipq806x
>   dt-bindings: PCI: qcom: Add ext reset
>   PCI: qcom: Use bulk clk api and assert on error
>   PCI: qcom: Define some PARF params needed for ipq8064 SoC
>   PCI: qcom: Add support for tx term offset for rev 2.1.0
>   PCI: qcom: Add ipq8064 rev2 variant
>   dt-bindings: PCI: qcom: Add ipq8064 rev 2 variant
>   PCI: qcom: Replace define with standard value
> 
> Sham Muthayyan (1):
>   PCI: qcom: Support pci speed set for ipq806x
> 
>  .../devicetree/bindings/pci/qcom,pcie.txt     |  15 +-
>  drivers/pci/controller/dwc/pcie-qcom.c        | 186 +++++++++++-------
>  2 files changed, 128 insertions(+), 73 deletions(-)

Applied to pci/dwc for v5.9, thanks.

Lorenzo