From patchwork Thu Jun 4 17:23:22 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nahor X-Patchwork-Id: 28111 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id 268B5B6F44 for ; Fri, 5 Jun 2009 03:26:40 +1000 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1MCGfS-0007r5-TP; Thu, 04 Jun 2009 17:23:55 +0000 Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by bombadil.infradead.org with esmtps (Exim 4.69 #1 (Red Hat Linux)) id 1MCGfG-0007b8-Pi for linux-mtd@lists.infradead.org; Thu, 04 Jun 2009 17:23:50 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1MCGfE-0001p3-9W for linux-mtd@lists.infradead.org; Thu, 04 Jun 2009 17:23:40 +0000 Received: from adsl-99-185-243-218.dsl.pltn13.sbcglobal.net ([99.185.243.218]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 04 Jun 2009 17:23:40 +0000 Received: from nahor.j+gmane by adsl-99-185-243-218.dsl.pltn13.sbcglobal.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 04 Jun 2009 17:23:40 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: linux-mtd@lists.infradead.org From: Nahor Subject: [PATH] [MTD-UTILS] Return error if failure when reading from standard input Date: Thu, 04 Jun 2009 10:23:22 -0700 Lines: 39 Message-ID: Mime-Version: 1.0 X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: adsl-99-185-243-218.dsl.pltn13.sbcglobal.net User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) X-Spam-Score: -1.0 (-) X-Spam-Report: SpamAssassin version 3.2.5 on bombadil.infradead.org summary: Content analysis details: (-1.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [80.91.229.2 listed in list.dnswl.org] X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The test to return SUCCESS or FAILURE at the end of nandwrite is done only when reading from a file. When reading from the standard input, nandwrite always returns success except for some cases at the begining. This patches aims at fixing that by returning an error when jumping to the closeall label. Regards, Nahor --- a/nandwrite.c 2009-06-01 18:03:55.000000000 -0700 +++ b/nandwrite.c 2009-06-03 17:25:19.000000000 -0700 @@ -261,6 +261,7 @@ int oobinfochanged = 0; struct nand_oobinfo old_oobinfo; int readcnt = 0; + bool failed = true; process_options(argc, argv); @@ -623,6 +624,8 @@ mtdoffset += meminfo.writesize; } + failed = false; + closeall: close(ifd); @@ -637,7 +640,7 @@ close(fd); - if ((ifd != STDIN_FILENO) && (imglen > 0)) { + if (failed || ((ifd != STDIN_FILENO) && (imglen > 0))) { perror ("Data was only partially written due to error\n"); exit (EXIT_FAILURE); }