| Message ID | OF5D2B97A5.BBB53CFB-ON48257BC8.00312DE8-48257BC8.003BEE50@zte.com.cn |
|---|---|
| State | New, archived |
| Headers | show |
Hi, First of all: thanks for contributing! On Thu, Aug 15, 2013 at 06:54:26PM +0800, wang.bo116@zte.com.cn wrote: > > Hi, > In ubifs_garbage_collect, "space_before" calculate twice, i think the > first one is unnecessary. > Mmm... this is not the way patches are contributed, although you were close. Please read: Documentation/SubmittingPatches and maybe see this video as well: http://www.youtube.com/watch?v=XXix80GCvpo Thanks! > > Signed-off-by: wang bo <wang.bo116@zte.com.cn> > diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c > index 76ca53c..38dc67d 100755 > --- a/fs/ubifs/gc.c > +++ b/fs/ubifs/gc.c > @@ -668,7 +668,7 @@ int ubifs_garbage_collect(struct ubifs_info *c, int > anyway) > ubifs_assert(!wbuf->used); > > for (i = 0; ; i++) { > - int space_before = c->leb_size - wbuf->offs - wbuf->used; > + int space_before; > int space_after; > > cond_resched(); > > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/
diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c index 76ca53c..38dc67d 100755 --- a/fs/ubifs/gc.c +++ b/fs/ubifs/gc.c @@ -668,7 +668,7 @@ int ubifs_garbage_collect(struct ubifs_info *c, int anyway) ubifs_assert(!wbuf->used); for (i = 0; ; i++) { - int space_before = c->leb_size - wbuf->offs - wbuf->used; + int space_before; int space_after;
Hi, In ubifs_garbage_collect, "space_before" calculate twice, i think the first one is unnecessary. Signed-off-by: wang bo <wang.bo116@zte.com.cn> cond_resched();