Message ID | OF476A1E1E.10D82F3D-ON48257BC9.002911AE-48257BC9.002A75A8@zte.com.cn |
---|---|
State | New, archived |
Headers | show |
On Fri, Aug 16, 2013 at 03:43:36PM +0800, wang.bo116@zte.com.cn wrote: > Hi, > In ubifs_garbage_collect,local variable "space_before" calculate twice. In fact, at the > beginning of the loop, there is no need to calculate this variable. Calculate it before call > "ubifs_garbage_collect_leb" is enough. This patch just remove the unnecessary calculate code. > > > > Signed-off-by: wang bo <wang.bo116@zte.com.cn> Acked-by: Brian Norris <computersforpeace@gmail.com>
(Ccing Artem who might have missed this one) On Mon, Sep 16, 2013 at 06:51:05PM -0700, Brian Norris wrote: > On Fri, Aug 16, 2013 at 03:43:36PM +0800, wang.bo116@zte.com.cn wrote: > > Hi, > > In ubifs_garbage_collect,local variable "space_before" calculate twice. In fact, at the > > beginning of the loop, there is no need to calculate this variable. Calculate it before call > > "ubifs_garbage_collect_leb" is enough. This patch just remove the unnecessary calculate code. > > > > > > > > Signed-off-by: wang bo <wang.bo116@zte.com.cn> > > Acked-by: Brian Norris <computersforpeace@gmail.com> >
On Sat, 2013-10-19 at 10:27 -0300, Ezequiel Garcia wrote: > (Ccing Artem who might have missed this one) > > On Mon, Sep 16, 2013 at 06:51:05PM -0700, Brian Norris wrote: > > On Fri, Aug 16, 2013 at 03:43:36PM +0800, wang.bo116@zte.com.cn wrote: > > > Hi, > > > In ubifs_garbage_collect,local variable "space_before" calculate twice. In fact, at the > > > beginning of the loop, there is no need to calculate this variable. Calculate it before call > > > "ubifs_garbage_collect_leb" is enough. This patch just remove the unnecessary calculate code. > > > > > > > > > > > > Signed-off-by: wang bo <wang.bo116@zte.com.cn> > > > > Acked-by: Brian Norris <computersforpeace@gmail.com> Pushed to linux-ubifs.git, thanks!
diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c index 76ca53c..38dc67d 100755 --- a/fs/ubifs/gc.c +++ b/fs/ubifs/gc.c @@ -668,7 +668,7 @@ int ubifs_garbage_collect(struct ubifs_info *c, int anyway) ubifs_assert(!wbuf->used); for (i = 0; ; i++) { - int space_before = c->leb_size - wbuf->offs - wbuf->used; + int space_before; int space_after; cond_resched();
Hi, In ubifs_garbage_collect,local variable "space_before" calculate twice. In fact, at the beginning of the loop, there is no need to calculate this variable. Calculate it before call "ubifs_garbage_collect_leb" is enough. This patch just remove the unnecessary calculate code. Signed-off-by: wang bo <wang.bo116@zte.com.cn>