| Message ID | DM2PR12MB001463BD62775C388AEBFD3FA6CE0@DM2PR12MB0014.namprd12.prod.outlook.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Boris Brezillon |
| Headers | show |
| Series | mtd: add support for the dual-die stack parallel NOR | expand |
On Wed, 21 Feb 2018 19:32:32 +0000 Bean Huo <beanhuo@outlook.com> wrote: > From: beanhuo <beanhuo@micron.com> > > This commit adds the dual die entry in the devicetree binding > for the daul die stacked parallel NOR. > > Signed-off-by: beanhuo <beanhuo@micron.com> > --- > Documentation/devicetree/bindings/mtd/mtd-physmap.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/mtd-physmap.txt b/Documentation/devicetree/bindings/mtd/mtd-physmap.txt > index 4a0a48b..782bacc 100644 > --- a/Documentation/devicetree/bindings/mtd/mtd-physmap.txt > +++ b/Documentation/devicetree/bindings/mtd/mtd-physmap.txt > @@ -29,6 +29,8 @@ file systems on embedded devices. > - use-advanced-sector-protection: boolean to enable support for the > advanced sector protection (Spansion: PPB - Persistent Protection > Bits) locking. > + - dual-die-stack: boolean to enable support for the devices with the > + two dies in stack. How about making that more future proof and adding a property that directly contains the number of dies (num-dies)? > > For JEDEC compatible devices, the following additional properties > are defined:
Boris, thanks for the review. >> + - dual-die-stack: boolean to enable support for the devices with the >> + two dies in stack. >How about making that more future proof and adding a property that >directly contains the number of dies (num-dies)? Exactly, I also thought here should add a property, through which it can be compatible with all kinds of PNOR for the future more dies stacked device. But currently, it doesn't exist PNOR device with more than two dies, and we have no idea about 4/6 dies stacked device operation sequence. so I simply add a boolean entry and try to only enable dual-die stacked PNOR firstly. Maybe I can try to do that in next version patch. the software implementation is so flexible. >> >> For JEDEC compatible devices, the following additional properties >> are defined:
On Fri, 23 Feb 2018 11:07:17 +0000 Bean Huo <beanhuo@outlook.com> wrote: > Boris, > thanks for the review. > > >> + - dual-die-stack: boolean to enable support for the devices with the > >> + two dies in stack. > > >How about making that more future proof and adding a property that > >directly contains the number of dies (num-dies)? > > Exactly, I also thought here should add a property, through which it can be compatible > with all kinds of PNOR for the future more dies stacked device. > But currently, it doesn't exist PNOR device with more than two dies, and we > have no idea about 4/6 dies stacked device operation sequence. so I simply add a boolean > entry and try to only enable dual-die stacked PNOR firstly. Actually, I think it's better to think about future evolutions now than adding a new property every time a vendor decides to add more dies (I guess the number of dies will always be a power-of-2). > > Maybe I can try to do that in next version patch. the software implementation is so flexible. > > >> > >> For JEDEC compatible devices, the following additional properties > >> are defined: >
diff --git a/Documentation/devicetree/bindings/mtd/mtd-physmap.txt b/Documentation/devicetree/bindings/mtd/mtd-physmap.txt index 4a0a48b..782bacc 100644 --- a/Documentation/devicetree/bindings/mtd/mtd-physmap.txt +++ b/Documentation/devicetree/bindings/mtd/mtd-physmap.txt @@ -29,6 +29,8 @@ file systems on embedded devices. - use-advanced-sector-protection: boolean to enable support for the advanced sector protection (Spansion: PPB - Persistent Protection Bits) locking. + - dual-die-stack: boolean to enable support for the devices with the + two dies in stack. For JEDEC compatible devices, the following additional properties are defined: