From patchwork Mon Oct 8 03:46:20 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 189884 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5A9682C0253 for ; Mon, 8 Oct 2012 14:47:27 +1100 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TL4IS-0000AY-8g; Mon, 08 Oct 2012 03:46:24 +0000 Received: from mail-ob0-f177.google.com ([209.85.214.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TL4IP-0000AK-T0 for linux-mtd@lists.infradead.org; Mon, 08 Oct 2012 03:46:22 +0000 Received: by mail-ob0-f177.google.com with SMTP id wd20so3490547obb.36 for ; Sun, 07 Oct 2012 20:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=r/dN7AYSITf7UceKy6RtkpXMl0MKjrwcAitILS8WyVM=; b=fnlTjRtvSuu2tsXQT2xgSMJ3Fj8u1z44Mi9cFpzBLf/PACHwgw3nK92NXYqgkq7JN/ EBMyvq/fekLO9QhXWY+7WdMP1vmYiPJ4Fxxd4D7vqLOaGf4BqbWKYmqR3YDY+DxQ5xEb t+wxZ6yWfGCDEJH5ZAOwaqaUlGw0Hhuf4cxVhbF+egv7FgwQFzTQOo8dIbF8sanMEmmB sqtUMCSa673NrJSWaymDhnUk2U46kLKBL++30r45S+tA/tu8bV221fDE7JfgAzC5sDv1 ajcD1MKNbDPKT3Ldur32Wnyo/mEr22bNJCLiKVZC+RD9zo+n82VSnxTFiURKx9fgy9Vy QGAg== MIME-Version: 1.0 Received: by 10.60.14.5 with SMTP id l5mr12465470oec.39.1349667980413; Sun, 07 Oct 2012 20:46:20 -0700 (PDT) Received: by 10.76.91.41 with HTTP; Sun, 7 Oct 2012 20:46:20 -0700 (PDT) In-Reply-To: References: <1348425062-17427-1-git-send-email-festevam@gmail.com> <50723E5C.3020403@freescale.com> <5072496A.3040205@freescale.com> Date: Mon, 8 Oct 2012 00:46:20 -0300 Message-ID: Subject: Re: [PATCH] nand: gpmi-nand: Fix clock registration From: Fabio Estevam To: Huang Shijie X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.214.177 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (festevam[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: marex@denx.de, artem.bityutskiy@linux.intel.com, shawn.guo@linaro.org, linux-mtd@lists.infradead.org, Fabio Estevam X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Mon, Oct 8, 2012 at 12:31 AM, Fabio Estevam wrote: > On Mon, Oct 8, 2012 at 12:32 AM, Huang Shijie wrote: >> >> This patch is really not needed. >> >> The clk_get() can get the right clock in the mx23/mx28. I tested them. > > Please test it on linux-next. > > gpmi nand can not event be probed. What about this? --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c @@ -495,7 +495,11 @@ static int __devinit gpmi_get_clks(struct gpmi_nand_data *this) int i; /* The main clock is stored in the first. */ - r->clock[0] = clk_get(this->dev, "gpmi_io"); + if (GPMI_IS_MX6Q(this)) + r->clock[0] = clk_get(this->dev, "gpmi_io"); + else + r->clock[0] = clk_get(this->dev, NULL); + if (IS_ERR(r->clock[0])) goto err_clock;