From patchwork Mon Oct 8 03:22:08 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 189883 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id AB9452C0156 for ; Mon, 8 Oct 2012 14:23:14 +1100 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TL3v3-0007S0-6B; Mon, 08 Oct 2012 03:22:13 +0000 Received: from mail-ob0-f177.google.com ([209.85.214.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TL3v0-0007RW-5Z for linux-mtd@lists.infradead.org; Mon, 08 Oct 2012 03:22:11 +0000 Received: by mail-ob0-f177.google.com with SMTP id wd20so3479970obb.36 for ; Sun, 07 Oct 2012 20:22:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=f+lMazNHrT+FQWum6hC7omj/pl/P/6kgr/InQRgcLhw=; b=RE9TvmJ5C9/8RUB+VvHu71V99fRd4GygJVLtJDqaiAcYYhxS90IYe+ooDcpD+K0yT0 2mw/2dvh0byhoBLjOO3iTLDWmpPCD1o4ZcqabPxI0KmMNXa7R8uwpXNNMx7L+ulGQIEl 0oAAukJi4pdocj/wdV/2FkI6emhXiOSBthgqxg4x64mj+6+q7yc1lan3m/giLaLAoPrI 1WFFjTvl4yCwVPbMVtd5bwAFiWnlni7f8R7iV77/INBlygxwEvHY1JskhCnq9VymsspK G6kT9jrz1bxo5/MOrsMpMRgARxZqS6p7MDNis+N9ZulQGM63AlM2F9ArP+NfrvV8yvli ve+Q== MIME-Version: 1.0 Received: by 10.60.14.5 with SMTP id l5mr12436835oec.39.1349666528276; Sun, 07 Oct 2012 20:22:08 -0700 (PDT) Received: by 10.76.91.41 with HTTP; Sun, 7 Oct 2012 20:22:08 -0700 (PDT) In-Reply-To: <50723E5C.3020403@freescale.com> References: <1348425062-17427-1-git-send-email-festevam@gmail.com> <50723E5C.3020403@freescale.com> Date: Mon, 8 Oct 2012 00:22:08 -0300 Message-ID: Subject: Re: [PATCH] nand: gpmi-nand: Fix clock registration From: Fabio Estevam To: Huang Shijie X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (festevam[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.214.177 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: marex@denx.de, artem.bityutskiy@linux.intel.com, shawn.guo@linaro.org, linux-mtd@lists.infradead.org, Fabio Estevam X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Sun, Oct 7, 2012 at 11:45 PM, Huang Shijie wrote: > 于 2012年09月24日 02:31, Fabio Estevam 写道: >> From: Fabio Estevam >> >> On a mx28 board the following error happens since commit 638064e56c >> (mtd: gpmi: change the code for clocks): >> >> gpmi-nand: probe of 8000c000.gpmi-nand failed with error -12 >> >> Acquire the clock using "NULL" as it was done previously, so that the driver >> can register on mx23/mx28 as well. >> >> Signed-off-by: Fabio Estevam >> --- >> drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c >> index c46be6c..1f23cb4 100644 >> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c >> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c >> @@ -492,7 +492,7 @@ static int __devinit gpmi_get_clks(struct gpmi_nand_data *this) >> int i; >> >> /* The main clock is stored in the first. */ >> - r->clock[0] = clk_get(this->dev, "gpmi_io"); >> + r->clock[0] = clk_get(this->dev, NULL); > Please do not change this line. > > The gpmi_io is for mx6q. > If you replace it with `NULL`. The mx6q can not find the proper clock. What about this? index 42978f1b..7b1aded 100644 Can you please test it on mx28? Regards, Fabio Estevam --- a/drivers/clk/mxs/clk-imx28.c +++ b/drivers/clk/mxs/clk-imx28.c @@ -139,7 +139,7 @@ enum imx28_clk { ssp0_div, ssp1_div, ssp2_div, ssp3_div, gpmi_div, emi_pll, emi_xtal, lcdif_div, etm_div, ptp, saif0_div, saif1_div, clk32k_div, rtc, lradc, spdif_div, clk32k, pwm, uart, ssp0, - ssp1, ssp2, ssp3, gpmi, spdif, emi, saif0, saif1, lcdif, etm, + ssp1, ssp2, ssp3, gpmi_io, spdif, emi, saif0, saif1, lcdif, etm, fec, can0, can1, usb0, usb1, usb0_pwr, usb1_pwr, enet_out, clk_max }; @@ -208,7 +208,7 @@ int __init mx28_clocks_init(void) clks[ssp1] = mxs_clk_gate("ssp1", "ssp1_div", SSP1, 31); clks[ssp2] = mxs_clk_gate("ssp2", "ssp2_div", SSP2, 31); clks[ssp3] = mxs_clk_gate("ssp3", "ssp3_div", SSP3, 31); - clks[gpmi] = mxs_clk_gate("gpmi", "gpmi_div", GPMI, 31); + clks[gpmi_io] = mxs_clk_gate("gpmi_io", "gpmi_div", GPMI, 31); clks[spdif] = mxs_clk_gate("spdif", "spdif_div", SPDIF, 31); clks[emi] = mxs_clk_gate("emi", "emi_sel", EMI, 31); clks[saif0] = mxs_clk_gate("saif0", "saif0_div", SAIF0, 31);