From patchwork Thu Jul 7 21:53:05 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 103734 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6C6C0B6F54 for ; Fri, 8 Jul 2011 07:53:43 +1000 (EST) Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QewVp-0006My-2k; Thu, 07 Jul 2011 21:53:33 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QewVo-0005uX-Hs; Thu, 07 Jul 2011 21:53:32 +0000 Received: from mail-iy0-f177.google.com ([209.85.210.177]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QewVl-0005uF-8z for linux-mtd@lists.infradead.org; Thu, 07 Jul 2011 21:53:30 +0000 Received: by iyn15 with SMTP id 15so1504031iyn.36 for ; Thu, 07 Jul 2011 14:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=hsCveq6g7kRLgKvL9bHVqd9jPDigPafHrbrKVeohoVc=; b=rKud47VO8zIk6uqtupa8B0bXMqF/LK11IbPdMH3/bCMtmvoEcPPL7CbDOixlW7egfs UScGxsqShc1DzmZ65woGd9krJW01+RRhik3TyqdkTN5a4OW1Vo1Pqp3D7WqcvhqjixdA iWSfPgupcSMkAZ26nRwJUqJvcBpr+rpF8ciz0= Received: by 10.231.45.80 with SMTP id d16mr1129453ibf.111.1310075605183; Thu, 07 Jul 2011 14:53:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.208.68 with HTTP; Thu, 7 Jul 2011 14:53:05 -0700 (PDT) In-Reply-To: References: <1310071467-9017-1-git-send-email-computersforpeace@gmail.com> From: Mike Frysinger Date: Thu, 7 Jul 2011 17:53:05 -0400 Message-ID: Subject: Re: [PATCH 1/3] Makefile: fix "version.h" build for cross-compiling To: Brian Norris X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110707_175329_569498_9D149DF0 X-CRM114-Status: UNSURE ( 6.45 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.8 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-0.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.210.177 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (vapier.adi[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: linux-mtd@lists.infradead.org, Artem Bityutskiy X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org with my two proposed changes, it's working for me now ... $ git clean -x -d $ git diff CPPFLAGS += -DWITHOUT_XATTR @@ -71,6 +71,7 @@ cscope: $(BUILDDIR)/include/version.h: $(BUILDDIR)/include/version.h.tmp $(Q)cmp -s $@ $@.tmp && rm -f $@.tmp || mv $@.tmp $@ $(BUILDDIR)/include/version.h.tmp: + $(Q)mkdir -p $(dir $@) $(Q)echo '#define VERSION "$(VERSION)"' > $@ # $ make CROSS=x86_64-pc-linux-gnu- -j2 ... success ... -mike --- a/Makefile +++ b/Makefile @@ -3,7 +3,7 @@ VERSION = 1.4.5 -CPPFLAGS += -I./include -I./ubi-utils/include $(ZLIBCPPFLAGS) $(LZOCPPFLAGS) +CPPFLAGS += -I./include -I$(BUILDDIR)/include -I./ubi-utils/include $(ZLIBCPPFLAGS) $(LZOCPPFLAGS) ifeq ($(WITHOUT_XATTR), 1)