| Message ID | BYAPR08MB45338B3B9FE13B8FB3070789DB680@BYAPR08MB4533.namprd08.prod.outlook.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Ambarus Tudor |
| Headers | show |
| Series | include: mtd: spi-nor: change HWCPAS to HWCAPS | expand |
Hi, Bean, SNOR_HWCPAS_READ_OCTO was renamed to SNOR_HWCPAS_READ_OCTAL please update your remote and send a new patch. The patch prefix is wrong, it should be prefixed with "mtd: spi-nor:". When in doubt, you can check how were prefixed previous patches on the same file by running something like: git log --oneline include/linux/mtd/spi-nor.h On 02/07/2019 03:46 PM, Bean Huo (beanhuo) wrote: > This looks like a blank line, it's not needed, remove it please. > Maybe this is wrong abbreviation, change from HWCPAS to HWCAPS. Indeed, it is, use imperative, something like: "Fix wrong abbreviation, s/HWCPAS/HWCAPS" > > Signed-off-by: Bean Huo <beanhuo@micron.com> Your S-o-b tag doesn't match the author name, please fix this as well. Cheers, ta > --- > include/linux/mtd/spi-nor.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h > index fa2d89e..5e12bf9 100644 > --- a/include/linux/mtd/spi-nor.h > +++ b/include/linux/mtd/spi-nor.h > @@ -479,7 +479,7 @@ struct spi_nor_hwcaps { > #define SNOR_HWCAPS_READ_4_4_4 BIT(9) > #define SNOR_HWCAPS_READ_1_4_4_DTR BIT(10) > > -#define SNOR_HWCPAS_READ_OCTO GENMASK(14, 11) > +#define SNOR_HWCAPS_READ_OCTO GENMASK(14, 11) > #define SNOR_HWCAPS_READ_1_1_8 BIT(11) > #define SNOR_HWCAPS_READ_1_8_8 BIT(12) > #define SNOR_HWCAPS_READ_8_8_8 BIT(13) >
Hi, Tudor >SNOR_HWCPAS_READ_OCTO was renamed to SNOR_HWCPAS_READ_OCTAL >please update your remote and send a new patch. > Which branch do you mean? I checked linux-mtd, not renamed yet. >The patch prefix is wrong, it should be prefixed with "mtd: spi-nor:". When in >doubt, you can check how were prefixed previous patches on the same file by >running something like: > >git log --oneline include/linux/mtd/spi-nor.h > >On 02/07/2019 03:46 PM, Bean Huo (beanhuo) wrote: >> > >This looks like a blank line, it's not needed, remove it please. >> Maybe this is wrong abbreviation, change from HWCPAS to HWCAPS. > >Indeed, it is, use imperative, something like: "Fix wrong abbreviation, >s/HWCPAS/HWCAPS" >> >> Signed-off-by: Bean Huo <beanhuo@micron.com> > >Your S-o-b tag doesn't match the author name, please fix this as well. It is automatically added by git, what is correct way? Thanks, //Bean
On 02/08/2019 01:39 PM, Bean Huo (beanhuo) wrote: > Hi, Tudor > >> SNOR_HWCPAS_READ_OCTO was renamed to SNOR_HWCPAS_READ_OCTAL >> please update your remote and send a new patch. >> > Which branch do you mean? I checked linux-mtd, not renamed yet. spi-nor/next > >> The patch prefix is wrong, it should be prefixed with "mtd: spi-nor:". When in >> doubt, you can check how were prefixed previous patches on the same file by >> running something like: >> >> git log --oneline include/linux/mtd/spi-nor.h >> >> On 02/07/2019 03:46 PM, Bean Huo (beanhuo) wrote: >>> >> >> This looks like a blank line, it's not needed, remove it please. >>> Maybe this is wrong abbreviation, change from HWCPAS to HWCAPS. >> >> Indeed, it is, use imperative, something like: "Fix wrong abbreviation, >> s/HWCPAS/HWCAPS" >>> >>> Signed-off-by: Bean Huo <beanhuo@micron.com> >> >> Your S-o-b tag doesn't match the author name, please fix this as well. > > It is automatically added by git, what is correct way? Your author name "Bean Huo (beanhuo)" is different than your S-o-b name, "Bean Huo". Did you add your S-o-b tag by hand? The author name is automatically added by git, it looks into your ~/.gitconfig file, at [user] name. S-o-b tag can also be added by git, just use the "-s" option when committing the change: "git commit -s". Cheers, ta
diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h index fa2d89e..5e12bf9 100644 --- a/include/linux/mtd/spi-nor.h +++ b/include/linux/mtd/spi-nor.h @@ -479,7 +479,7 @@ struct spi_nor_hwcaps { #define SNOR_HWCAPS_READ_4_4_4 BIT(9) #define SNOR_HWCAPS_READ_1_4_4_DTR BIT(10) -#define SNOR_HWCPAS_READ_OCTO GENMASK(14, 11) +#define SNOR_HWCAPS_READ_OCTO GENMASK(14, 11) #define SNOR_HWCAPS_READ_1_1_8 BIT(11) #define SNOR_HWCAPS_READ_1_8_8 BIT(12) #define SNOR_HWCAPS_READ_8_8_8 BIT(13)
Maybe this is wrong abbreviation, change from HWCPAS to HWCAPS. Signed-off-by: Bean Huo <beanhuo@micron.com> --- include/linux/mtd/spi-nor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)