| Message ID | 9b1b4ab1-681f-0ef9-7b5c-b6545f7464d2@infradead.org |
|---|---|
| State | Accepted |
| Delegated to: | Vignesh R |
| Headers | show |
| Series | mtd: hyperbus: fix dependency and build error | expand |
Hi Vignesh, Randy Dunlap <rdunlap@infradead.org> wrote on Tue, 13 Aug 2019 16:03:13 -0700: > From: Randy Dunlap <rdunlap@infradead.org> > > lib/devres.c, which implements devm_ioremap_resource(), is only built > when CONFIG_HAS_IOMEM is set/enabled, so MTD_HYPERBUS should depend > on HAS_IOMEM. Fixes a build error and a Kconfig warning (as seen on > UML builds): > > WARNING: unmet direct dependencies detected for MTD_COMPLEX_MAPPINGS > Depends on [n]: MTD [=m] && HAS_IOMEM [=n] > Selected by [m]: > - MTD_HYPERBUS [=m] && MTD [=m] > > ERROR: "devm_ioremap_resource" [drivers/mtd/hyperbus/hyperbus-core.ko] undefined! > > Fixes: dcc7d3446a0f ("mtd: Add support for HyperBus memory devices") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Vignesh Raghavendra <vigneshr@ti.com> > Cc: Miquel Raynal <miquel.raynal@bootlin.com> > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: linux-mtd@lists.infradead.org > --- This patch looks like a good candidate for fixes, shall I send a fixes PR next week with it? (Acked-by wished) Miquèl
Hi Miquel, On 24-Aug-19 4:18 PM, Miquel Raynal wrote: > Hi Vignesh, > > Randy Dunlap <rdunlap@infradead.org> wrote on Tue, 13 Aug 2019 16:03:13 > -0700: > >> From: Randy Dunlap <rdunlap@infradead.org> >> >> lib/devres.c, which implements devm_ioremap_resource(), is only built >> when CONFIG_HAS_IOMEM is set/enabled, so MTD_HYPERBUS should depend >> on HAS_IOMEM. Fixes a build error and a Kconfig warning (as seen on >> UML builds): >> >> WARNING: unmet direct dependencies detected for MTD_COMPLEX_MAPPINGS >> Depends on [n]: MTD [=m] && HAS_IOMEM [=n] >> Selected by [m]: >> - MTD_HYPERBUS [=m] && MTD [=m] >> >> ERROR: "devm_ioremap_resource" [drivers/mtd/hyperbus/hyperbus-core.ko] undefined! >> >> Fixes: dcc7d3446a0f ("mtd: Add support for HyperBus memory devices") >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Cc: Vignesh Raghavendra <vigneshr@ti.com> >> Cc: Miquel Raynal <miquel.raynal@bootlin.com> >> Cc: Geert Uytterhoeven <geert@linux-m68k.org> >> Cc: linux-mtd@lists.infradead.org >> --- > > This patch looks like a good candidate for fixes, shall I send a fixes > PR next week with it? (Acked-by wished) > Yes, that would be great. I was about to send across patch bundle myself. Acked-by: Vignesh Raghavendra <vigneshr@ti.com> Thanks Vignesh
On Tue, 2019-08-13 at 23:03:13 UTC, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > lib/devres.c, which implements devm_ioremap_resource(), is only built > when CONFIG_HAS_IOMEM is set/enabled, so MTD_HYPERBUS should depend > on HAS_IOMEM. Fixes a build error and a Kconfig warning (as seen on > UML builds): > > WARNING: unmet direct dependencies detected for MTD_COMPLEX_MAPPINGS > Depends on [n]: MTD [=m] && HAS_IOMEM [=n] > Selected by [m]: > - MTD_HYPERBUS [=m] && MTD [=m] > > ERROR: "devm_ioremap_resource" [drivers/mtd/hyperbus/hyperbus-core.ko] undefined! > > Fixes: dcc7d3446a0f ("mtd: Add support for HyperBus memory devices") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Vignesh Raghavendra <vigneshr@ti.com> > Cc: Miquel Raynal <miquel.raynal@bootlin.com> > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: linux-mtd@lists.infradead.org > Acked-by: Vignesh Raghavendra <vigneshr@ti.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks. Miquel
--- lnx-53-rc4.orig/drivers/mtd/hyperbus/Kconfig +++ lnx-53-rc4/drivers/mtd/hyperbus/Kconfig @@ -1,5 +1,6 @@ menuconfig MTD_HYPERBUS tristate "HyperBus support" + depends on HAS_IOMEM select MTD_CFI select MTD_MAP_BANK_WIDTH_2 select MTD_CFI_AMDSTD