| Message ID | 5673177.0QYFhMPCBq@wuerfel |
|---|---|
| State | Rejected |
| Headers | show |
On Fri, Oct 16, 2015 at 06:24:21PM +0200, Arnd Bergmann wrote: > I think you also need this one: Are you sure? > 8<----------- > From 0ab7b2d32921b3f3da15274d8c3982ba1d54660f Mon Sep 17 00:00:00 2001 > From: Arnd Bergmann <arnd@arndb.de> > Date: Thu, 4 Jun 2015 09:25:59 +0200 > Subject: [PATCH] mtd: brcmnand depends on MTD_NAND > > MTD_NAND_BRCMNAND uses the generic nand functions, but is currently allowed > to be built without CONFIG_MTD_NAND, which results in a link error: > > drivers/built-in.o: In function `brcmnand_remove': > coresight-replicator.c:(.text+0x17ae6c): undefined reference to `nand_release' > drivers/built-in.o: In function `brcmnand_probe': > coresight-replicator.c:(.text+0x17d4b4): undefined reference to `nand_scan_ident' > coresight-replicator.c:(.text+0x17d948): undefined reference to `nand_scan_tail' How did you get this? MTD_NAND_BRCMNAND is surrounded in the 'if MTD_NAND' block, which implicitly generates a MTD_NAND dependency. And I can confirm that in menuconfig, I see this when I disable MTD_NAND and search for BRCMNAND: Symbol: MTD_NAND_BRCMNAND [=n] Type : tristate Prompt: Broadcom STB NAND controller Location: -> Device Drivers -> Memory Technology Device (MTD) support (MTD [=y]) (1) -> NAND Device Support (MTD_NAND [=n]) Defined at drivers/mtd/nand/Kconfig:394 Depends on: MTD [=y] && MTD_NAND [=n] && (ARM [=y] || ARM64 || MIPS) Brian > This adds an explicit Kconfig dependency. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > index 289664089cf3..4b7e853ce35d 100644 > --- a/drivers/mtd/nand/Kconfig > +++ b/drivers/mtd/nand/Kconfig > @@ -393,6 +393,7 @@ config MTD_NAND_GPMI_NAND > > config MTD_NAND_BRCMNAND > tristate "Broadcom STB NAND controller" > + depends on MTD_NAND > depends on ARM || ARM64 || MIPS > help > Enables the Broadcom NAND controller driver. The controller was >
On Friday 16 October 2015 09:54:45 Brian Norris wrote: > > MTD_NAND_BRCMNAND uses the generic nand functions, but is currently allowed > > to be built without CONFIG_MTD_NAND, which results in a link error: > > > > drivers/built-in.o: In function `brcmnand_remove': > > coresight-replicator.c:(.text+0x17ae6c): undefined reference to `nand_release' > > drivers/built-in.o: In function `brcmnand_probe': > > coresight-replicator.c:(.text+0x17d4b4): undefined reference to `nand_scan_ident' > > coresight-replicator.c:(.text+0x17d948): undefined reference to `nand_scan_tail' > > How did you get this? MTD_NAND_BRCMNAND is surrounded in the > 'if MTD_NAND' block, which implicitly generates a MTD_NAND dependency. > And I can confirm that in menuconfig, I see this when I disable MTD_NAND > and search for BRCMNAND: > > Symbol: MTD_NAND_BRCMNAND [=n] > Type : tristate > Prompt: Broadcom STB NAND controller > Location: > -> Device Drivers > -> Memory Technology Device (MTD) support (MTD [=y]) > (1) -> NAND Device Support (MTD_NAND [=n]) > Defined at drivers/mtd/nand/Kconfig:394 > Depends on: MTD [=y] && MTD_NAND [=n] && (ARM [=y] || ARM64 || MIPS) Sorry, can't reproduce it any more. My patch is dated June 4, so it was probably broken then but got fixed since. I normally try to verify that the patches are still needed before I send them, but this time I only saw the current discussion and remembered something vague about it and sent what I had in my backlog of the randconfig-fixes series. Sorry for the confusion. Arnd
On 16/10/15 12:25, Arnd Bergmann wrote: > On Friday 16 October 2015 09:54:45 Brian Norris wrote: >>> MTD_NAND_BRCMNAND uses the generic nand functions, but is currently allowed >>> to be built without CONFIG_MTD_NAND, which results in a link error: >>> >>> drivers/built-in.o: In function `brcmnand_remove': >>> coresight-replicator.c:(.text+0x17ae6c): undefined reference to `nand_release' >>> drivers/built-in.o: In function `brcmnand_probe': >>> coresight-replicator.c:(.text+0x17d4b4): undefined reference to `nand_scan_ident' >>> coresight-replicator.c:(.text+0x17d948): undefined reference to `nand_scan_tail' >> >> How did you get this? MTD_NAND_BRCMNAND is surrounded in the >> 'if MTD_NAND' block, which implicitly generates a MTD_NAND dependency. >> And I can confirm that in menuconfig, I see this when I disable MTD_NAND >> and search for BRCMNAND: >> >> Symbol: MTD_NAND_BRCMNAND [=n] >> Type : tristate >> Prompt: Broadcom STB NAND controller >> Location: >> -> Device Drivers >> -> Memory Technology Device (MTD) support (MTD [=y]) >> (1) -> NAND Device Support (MTD_NAND [=n]) >> Defined at drivers/mtd/nand/Kconfig:394 >> Depends on: MTD [=y] && MTD_NAND [=n] && (ARM [=y] || ARM64 || MIPS) > > Sorry, can't reproduce it any more. My patch is dated June 4, so it was > probably broken then but got fixed since. I normally try to verify that > the patches are still needed before I send them, but this time I only > saw the current discussion and remembered something vague about it > and sent what I had in my backlog of the randconfig-fixes series. It may have been a problem before this patch: d80d942bcc8e1555a76774d20be9800cfef2d415 ("ARM: BCM: Do not select CONFIG_MTD_NAND_BRCMNAND")
On Friday 16 October 2015 12:28:03 Florian Fainelli wrote: > > > > Sorry, can't reproduce it any more. My patch is dated June 4, so it was > > probably broken then but got fixed since. I normally try to verify that > > the patches are still needed before I send them, but this time I only > > saw the current discussion and remembered something vague about it > > and sent what I had in my backlog of the randconfig-fixes series. > > It may have been a problem before this patch: > > d80d942bcc8e1555a76774d20be9800cfef2d415 ("ARM: BCM: Do not select > CONFIG_MTD_NAND_BRCMNAND") > -- > Yes, that must have been it. So my patch was not only outdated but also wrong ;-) Arnd
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index 289664089cf3..4b7e853ce35d 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig @@ -393,6 +393,7 @@ config MTD_NAND_GPMI_NAND config MTD_NAND_BRCMNAND tristate "Broadcom STB NAND controller" + depends on MTD_NAND depends on ARM || ARM64 || MIPS help Enables the Broadcom NAND controller driver. The controller was