| Message ID | 541D24CF.1040705@huawei.com |
|---|---|
| State | Rejected |
| Headers | show |
On Sat, 2014-09-20 at 14:55 +0800, hujianyang wrote: > I found the dump messages of UBIFS_SB_NODE is not aligned. This > patch remove the extra space from the line which is retracted. > > > Signed-off-by: hujianyang <hujianyang@huawei.com> This was not a typo, this was intentional. We first print the all flags in a hex format, and then we "decode" it and print the values of the individual flags with an additional indent. The indent is to make it clear that these line belong to the flags, and they are not independent values.
On 2014/9/26 18:36, Artem Bityutskiy wrote: > On Sat, 2014-09-20 at 14:55 +0800, hujianyang wrote: >> I found the dump messages of UBIFS_SB_NODE is not aligned. This >> patch remove the extra space from the line which is retracted. >> >> >> Signed-off-by: hujianyang <hujianyang@huawei.com> > > This was not a typo, this was intentional. We first print the all flags > in a hex format, and then we "decode" it and print the values of the > individual flags with an additional indent. The indent is to make it > clear that these line belong to the flags, and they are not independent > values. > Oh, thanks for your explanation~! Hu
diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c index 177b015..d0bcf92 100644 --- a/fs/ubifs/debug.c +++ b/fs/ubifs/debug.c @@ -334,9 +334,9 @@ void ubifs_dump_node(const struct ubifs_info *c, const void *node) pr_err("\tkey_fmt %d (%s)\n", (int)sup->key_fmt, get_key_fmt(sup->key_fmt)); pr_err("\tflags %#x\n", sup_flags); - pr_err("\t big_lpt %u\n", + pr_err("\tbig_lpt %u\n", !!(sup_flags & UBIFS_FLG_BIGLPT)); - pr_err("\t space_fixup %u\n", + pr_err("\tspace_fixup %u\n", !!(sup_flags & UBIFS_FLG_SPACE_FIXUP)); pr_err("\tmin_io_size %u\n", le32_to_cpu(sup->min_io_size)); pr_err("\tleb_size %u\n", le32_to_cpu(sup->leb_size));
I found the dump messages of UBIFS_SB_NODE is not aligned. This patch remove the extra space from the line which is retracted. Signed-off-by: hujianyang <hujianyang@huawei.com> --- fs/ubifs/debug.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)