| Message ID | 20240319093405.39833-4-manojkiran.eda@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add eSPI device driver (flash channel) | expand |
On 19/03/2024 10:34, Manojkiran Eda wrote: > This commit adds eSPI to the device tree for aspeed 5/6th > generation SoCs. > > Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com> > --- > arch/arm/boot/dts/aspeed/aspeed-g5.dtsi | 19 +++++++++++++++++++ > arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 20 ++++++++++++++++++++ > 2 files changed, 39 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi > index 04f98d1dbb97..eaf7d82b6f46 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi > +++ b/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi > @@ -343,6 +343,25 @@ sdhci1: sdhci@200 { > status = "disabled"; > }; > }; > + espi: espi@1e6ee000 { spi or syscon Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "aspeed,ast2500-espi", "simple-mfd", "syscon"; > + reg = <0x1e6ee000 0x1000>; > + > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x1e6ee000 0x1000>; > + > + espi_ctrl: espi-ctrl@0 { What is this device? If parent is espi, then what is this? Where is the binding? Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi index 04f98d1dbb97..eaf7d82b6f46 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi +++ b/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi @@ -343,6 +343,25 @@ sdhci1: sdhci@200 { status = "disabled"; }; }; + espi: espi@1e6ee000 { + compatible = "aspeed,ast2500-espi", "simple-mfd", "syscon"; + reg = <0x1e6ee000 0x1000>; + + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x1e6ee000 0x1000>; + + espi_ctrl: espi-ctrl@0 { + compatible = "aspeed,ast2500-espi-ctrl"; + reg = <0x0 0x800>,<0x0 0x4000000>; + reg-names = "espi_ctrl","espi_flash"; + interrupts = <23>; + clocks = <&syscon ASPEED_CLK_GATE_ESPICLK>; + status = "disabled"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_espi_default>; + }; + }; gpio: gpio@1e780000 { #gpio-cells = <2>; diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi index c4d1faade8be..094e14442101 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi @@ -454,6 +454,26 @@ video: video@1e700000 { status = "disabled"; }; + espi: espi@1e6ee000 { + compatible = "aspeed,ast2500-espi", "simple-mfd", "syscon"; + reg = <0x1e6ee000 0x1000>; + + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x1e6ee000 0x1000>; + + espi_ctrl: espi-ctrl@0 { + compatible = "aspeed,ast2500-espi-ctrl"; + reg = <0x0 0x800>,<0x0 0x4000000>; + reg-names = "espi_ctrl","espi_flash"; + interrupts = <23>; + clocks = <&syscon ASPEED_CLK_GATE_ESPICLK>; + status = "disabled"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_espi_default>; + }; + }; + gpio0: gpio@1e780000 { #gpio-cells = <2>; gpio-controller;
This commit adds eSPI to the device tree for aspeed 5/6th generation SoCs. Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com> --- arch/arm/boot/dts/aspeed/aspeed-g5.dtsi | 19 +++++++++++++++++++ arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 20 ++++++++++++++++++++ 2 files changed, 39 insertions(+)