| Message ID | 20240207202257.271784-7-william.zhang@broadcom.com |
|---|---|
| State | New |
| Headers | show |
| Series | mtd: rawnand: brcmnand: driver and doc updates | expand |
From: Florian Fainelli <f.fainelli@gmail.com> On Wed, 7 Feb 2024 12:22:51 -0800, William Zhang <william.zhang@broadcom.com> wrote: > Enable the nand controller and add WP pin connection property in actual > board dts as they are board level properties now that they are disabled > and moved out from SoC dtsi. > > Also remove the unnecessary brcm,nand-has-wp property from AC5300 board. > This property is only needed for some old controller that this board > does not apply. > > Signed-off-by: William Zhang <william.zhang@broadcom.com> > --- Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! -- Florian
On 2/21/24 16:37, Florian Fainelli wrote: > From: Florian Fainelli <f.fainelli@gmail.com> > > On Wed, 7 Feb 2024 12:22:51 -0800, William Zhang <william.zhang@broadcom.com> wrote: >> Enable the nand controller and add WP pin connection property in actual >> board dts as they are board level properties now that they are disabled >> and moved out from SoC dtsi. >> >> Also remove the unnecessary brcm,nand-has-wp property from AC5300 board. >> This property is only needed for some old controller that this board >> does not apply. >> >> Signed-off-by: William Zhang <william.zhang@broadcom.com> >> --- > > Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! > -- > Florian Actually no, cannot apply this just yet since this depends upon patch #5.
On 2/21/24 16:40, Florian Fainelli wrote: > On 2/21/24 16:37, Florian Fainelli wrote: >> From: Florian Fainelli <f.fainelli@gmail.com> >> >> On Wed, 7 Feb 2024 12:22:51 -0800, William Zhang >> <william.zhang@broadcom.com> wrote: >>> Enable the nand controller and add WP pin connection property in actual >>> board dts as they are board level properties now that they are disabled >>> and moved out from SoC dtsi. >>> >>> Also remove the unnecessary brcm,nand-has-wp property from AC5300 board. >>> This property is only needed for some old controller that this board >>> does not apply. >>> >>> Signed-off-by: William Zhang <william.zhang@broadcom.com> >>> --- >> >> Applied to >> https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! >> -- >> Florian > > Actually no, cannot apply this just yet since this depends upon patch #5. Correct. Please wait for v6.
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-netgear-r8000p.dts b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-netgear-r8000p.dts index 78204d71ecd2..999d93730240 100644 --- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-netgear-r8000p.dts +++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-netgear-r8000p.dts @@ -125,6 +125,11 @@ port@7 { }; }; +&nand_controller { + brcm,wp-not-connected; + status = "okay"; +}; + &nandcs { nand-ecc-strength = <4>; nand-ecc-step-size = <512>; diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-tplink-archer-c2300-v1.dts b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-tplink-archer-c2300-v1.dts index fcf092c81b59..19fc03ef47a0 100644 --- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-tplink-archer-c2300-v1.dts +++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-tplink-archer-c2300-v1.dts @@ -155,6 +155,11 @@ port@7 { }; }; +&nand_controller { + brcm,wp-not-connected; + status = "okay"; +}; + &nandcs { nand-ecc-strength = <4>; nand-ecc-step-size = <512>; diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908-asus-gt-ac5300.dts b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908-asus-gt-ac5300.dts index d94a53d68320..52f928dbfa3c 100644 --- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908-asus-gt-ac5300.dts +++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908-asus-gt-ac5300.dts @@ -166,11 +166,15 @@ led@19 { }; }; +&nand_controller { + brcm,wp-not-connected; + status = "okay"; +}; + &nandcs { nand-ecc-strength = <4>; nand-ecc-step-size = <512>; nand-on-flash-bbt; - brcm,nand-has-wp; #address-cells = <1>; #size-cells = <0>;
Enable the nand controller and add WP pin connection property in actual board dts as they are board level properties now that they are disabled and moved out from SoC dtsi. Also remove the unnecessary brcm,nand-has-wp property from AC5300 board. This property is only needed for some old controller that this board does not apply. Signed-off-by: William Zhang <william.zhang@broadcom.com> --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None .../boot/dts/broadcom/bcmbca/bcm4906-netgear-r8000p.dts | 5 +++++ .../dts/broadcom/bcmbca/bcm4906-tplink-archer-c2300-v1.dts | 5 +++++ .../boot/dts/broadcom/bcmbca/bcm4908-asus-gt-ac5300.dts | 6 +++++- 3 files changed, 15 insertions(+), 1 deletion(-)