Message ID | 20240205100955.149755-1-tudor.ambarus@linaro.org |
---|---|
State | Accepted |
Headers | show
Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=CveMvodh; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=naQ+eY4g; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TT2FL4h78z23gT for <incoming@patchwork.ozlabs.org>; Mon, 5 Feb 2024 21:10:28 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=9SgiQm0g/Ekzqi7mYSnC8z4Hv2VYxYuVIhqAUe87CtI=; b=CveMvodhAAsy/O uP9JHhIp0SL2gT+mt9+gSMCy2aopK6bFSu7QwRBGBCfbLXpDhDCq+d+02PSOMnP05jK2lTNpsYv0/ idnoZpnepg5PK/T3GaqTCOgxdVIcWF5yg0FS0VaGDXKe/0TB4yXuqOxZItAPEcx2zVWdQezoEyNyF hcQNLzK5SWkbMTCSU35GwgTLNX32A0ZHsmtM09OEwUfpOZAouWz2xiCztPXoWho1VXcVh+iDYbCTJ IJsXMp0p/BKN/sKLoUguUiurbPqcWiFLB6pOSkvb0kE9860ujN4F2cRDh9DMkzebjavIy7tRQEeIY QIMdLTKaq7joyLFmSjoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWvvU-00000002kZi-1f6j; Mon, 05 Feb 2024 10:10:08 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWvvS-00000002kZ6-0KGD for linux-mtd@lists.infradead.org; Mon, 05 Feb 2024 10:10:07 +0000 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-337cc8e72f5so3131239f8f.1 for <linux-mtd@lists.infradead.org>; Mon, 05 Feb 2024 02:10:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707127803; x=1707732603; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PM79ddFlM7URHKM92cg1UrBcIO6D7fI7h+zZ2IlfnwQ=; b=naQ+eY4gOa7zUppU6c0qAEEnsPh0cfEbEJR6iU4Xbb+7ZIslMeYKHe/EbwqkQBnmm3 rTbrQY7vzOEw9THw3zRqtRc0uhQnRlKlpuA+jqHmCDBNmAeXfbz4oCJ7FR0mkYmKSX1s k8cPDRG84xFv7jROCu4jhSTFII1nZ6Pkdg2mMSTPTfhwp/K/4rlSKaE+Y4Z0C1zhj4d5 WvfqDDbMcD5XIAqRVHXE2QGaBVEmjguzGYEIv3FwYz93gLzsSCZEG2zf38Wtv63L6LfE RtJiWEE9MseUzhSz73hlOQLBcFeSXNwAKGZyxVWnXmj8gq7+7YDD6yfV3h+rPr/rL3d7 lQ3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707127803; x=1707732603; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PM79ddFlM7URHKM92cg1UrBcIO6D7fI7h+zZ2IlfnwQ=; b=LT1Pql8y4mBdUvbd/4xsEDOn2n7IOa+0wMBFNk8pNk8de8yzhWEBkgmtw9txLX52Bk aYeIA/SEpHUUYQwAQDFg2kkRePwKKP66C78a16Lh3wtWGFg5yVZJMS10pvYXpc2JuF8u mm56vsqOeO4Lcy7k3d1Ulp5/GNLWEKLaeQuVZacOpota61pO4fWrP+Dl1WvqDtgmJ9kv 31uS/vwb7q488JS/KwjIcLPfLBg8VkD+OuXbtZkT5RkAh1KfIhdZZEvemom/fLt75w5N xfKoF97GNyiC3IbJ0EroVZHoqF97D/kGk3dJmVUBsMBTzZ++xsjHpcruDDQLVUFro3/9 nspg== X-Gm-Message-State: AOJu0YxCVSLk7n5eO/9pYrnJ2DK8HQwjhCIChuwTC0UHZbm/lJNb8e8l 8C14wU7MWpsi4mH/ugnOn7pgeoHt5avkgQw8XFZIwcgpS5em1XAveprDrNl7esU= X-Google-Smtp-Source: AGHT+IGgdKcnU5KmXqzxTG6IPmbKMzlO9O60tha1XABc6ryVGbd/dNZgL8d5b6WVkrriIAy7dazcuQ== X-Received: by 2002:a05:6000:dd0:b0:33a:e6dc:2e98 with SMTP id dw16-20020a0560000dd000b0033ae6dc2e98mr8856744wrb.5.1707127802716; Mon, 05 Feb 2024 02:10:02 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCU6yDO2FBqezZlPU2JPGqbY4RTsKYQbF3YB8DM9gGdCdKm2bSUeD/4maLEXs2UxamIL7xdOQcolQWZ4yCw1xtCY4EdiNU7QeVQ5P7xya7yp5EEK6xZGwxdf7wru5wiNqd8IawTtUGfgbMH0+DV1JhVc3dY2gUCa0YQM+cadEOZGhG+p+vbID0Jpr3hzyGth9GkU5Qpk Received: from 1.. ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id l10-20020a5d410a000000b0033af5716a7fsm7694395wrp.61.2024.02.05.02.10.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 02:10:02 -0800 (PST) From: Tudor Ambarus <tudor.ambarus@linaro.org> To: miquel.raynal@bootlin.com, richard@nod.at Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Takahiro.Kuwano@infineon.com, Tudor Ambarus <tudor.ambarus@linaro.org> Subject: [PATCH] mtd: flashchip: explicitly include <linux/wait.h> Date: Mon, 5 Feb 2024 12:09:55 +0200 Message-Id: <20240205100955.149755-1-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1152; i=tudor.ambarus@linaro.org; h=from:subject; bh=e3w9hSsDT3FO8WPZhRfhMoOpgMXCC+pRKpqGj74t4+0=; b=owEBbQGS/pANAwAKAUtVT0eljRTpAcsmYgBlwLPz5xUk93u1ufsUid6bQ6qowIDwkHv5Mnolp 8Eknq+ko1CJATMEAAEKAB0WIQQdQirKzw7IbV4d/t9LVU9HpY0U6QUCZcCz8wAKCRBLVU9HpY0U 6fxXB/95862mGGMlEovpodPY5k8h7gH4fQQXhXtYxFEQ/axPd02kxgryzHrF7JJ/KTk8NpJHTqJ XK3E2cgoMxNkdTuLd6tsvl5m3hiQY4jqZyJhrM2ia1PFnlDr9SBC/U8FSVDAz4dJDBtJb3FXc/V CVkxRyDtYkMU/iYuuZ/B9V3/uG2gIoW8qk94wKBSScf1GVmOHT/rzlnzLcOzUAyYXB/l6mKv71U oYxGNDy0YYXcJ1MYrYtBgaVC4ZrKrdWPydsDmBgz6T04RzS1i0GPN1REJqYrzI83GVT7Exb5nxm ku3qO4W4xukOHrbTc8Bk2bhhCnOShdRBpctIrhejwSw/fOo2 X-Developer-Key: i=tudor.ambarus@linaro.org; a=openpgp; fpr=280B06FD4CAAD2980C46DDDF4DB1B079AD29CF3D X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_021006_145699_90F8619F X-CRM114-Status: UNSURE ( 9.52 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__While_reviewing_the_hyperbus_sfdp_prop?= =?unknown-8bit?q?osal_the_following_problem?= =?unknown-8bit?q?_was_noticed=3A_In_file_included_from_=2E/include/linux/mtd?= =?unknown-8bit?q?/gen=5Fprobe=2Eh=3A10=2C_from?= =?unknown-8bit?q?_drivers/mtd/hyperbus/hyperbus-sfdp=2Ec=3A6=3A_=2E/include/?= =?unknown-8bit?q?linux/mtd/flashchip=2Eh=3A77=3A9=3A?= =?unknown-8bit?b?IGVycm9yOiB1bmtub3duIHR5cGUgbmFtZSDigJh3YWl0X3F1ZXVlX2hl?= =?unknown-8bit?b?YWRfdOKAmSA3NyB8IHdhaXRfIFsuLi5dIA==?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=28-0=2E2_points=2C_5=2E0_re?= =?unknown-8bit?q?quired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_a?= =?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C_no?= =?unknown-8bit?q?_trust?= =?unknown-8bit?b?IFsyYTAwOjE0NTA6NDg2NDoyMDowOjA6MDo0MmUgbGlzdGVkIGluXQ==?= =?unknown-8bit?b?IFtsaXN0LmRuc3dsLm9yZ10=?= =?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FEF__________Message_has_a_valid_DKIM?= =?unknown-8bit?q?_or_DK_signature_from?= =?unknown-8bit?q?_envelope-from_domain?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily_valid?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM?= =?unknown-8bit?q?_or_DK_signature_from_author=27s?= =?unknown-8bit?q?_domain?= =?unknown-8bit?q?_-0=2E0_T=5FSCC=5FBODY=5FTEXT=5FLINE___No_description_avail?= =?unknown-8bit?q?able=2E?= X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/> List-Post: <mailto:linux-mtd@lists.infradead.org> List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
mtd: flashchip: explicitly include <linux/wait.h>
|
expand
|
On Mon, 2024-02-05 at 10:09:55 UTC, Tudor Ambarus wrote: > While reviewing the hyperbus sfdp proposal the following problem was > noticed: > > In file included from ./include/linux/mtd/gen_probe.h:10, > from drivers/mtd/hyperbus/hyperbus-sfdp.c:6: > ./include/linux/mtd/flashchip.h:77:9: error: unknown type name ‘wait_queue_head_t’ > 77 | wait_queue_head_t wq; /* Wait on here when we're waiting for the chip > | ^~~~~~~~~~~~~~~~~ > > It is good practice to directly include all headers used, it avoids > implicit dependencies and spurious breakage if someone rearranges > headers and causes the implicit include to vanish. > > Explicitly include <linux/wait.h> in include/linux/mtd/flashchip. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel
diff --git a/include/linux/mtd/flashchip.h b/include/linux/mtd/flashchip.h index c04f690871ca..9798c1a1d3b6 100644 --- a/include/linux/mtd/flashchip.h +++ b/include/linux/mtd/flashchip.h @@ -13,6 +13,7 @@ */ #include <linux/sched.h> #include <linux/mutex.h> +#include <linux/wait.h> typedef enum { FL_READY,
While reviewing the hyperbus sfdp proposal the following problem was noticed: In file included from ./include/linux/mtd/gen_probe.h:10, from drivers/mtd/hyperbus/hyperbus-sfdp.c:6: ./include/linux/mtd/flashchip.h:77:9: error: unknown type name ‘wait_queue_head_t’ 77 | wait_queue_head_t wq; /* Wait on here when we're waiting for the chip | ^~~~~~~~~~~~~~~~~ It is good practice to directly include all headers used, it avoids implicit dependencies and spurious breakage if someone rearranges headers and causes the implicit include to vanish. Explicitly include <linux/wait.h> in include/linux/mtd/flashchip. Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> --- include/linux/mtd/flashchip.h | 1 + 1 file changed, 1 insertion(+)