| Message ID | 20231201181542.421077-1-dregan@broadcom.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] mtd: rawnand: Add deassert_wp comment | expand |
On Fri, 1 Dec 2023 10:15:42 -0800 dregan <dregan@broadcom.com> wrote: > From: Boris Brezillon <bbrezillon@kernel.org> I'm pretty sure I shouldn't be the author. The original patch might have been partly written by me, but this is a fixup on top of it. > > Add deassert_wp description comment > > Signed-off-by: Boris Brezillon <bbrezillon@kernel.org> and you should drop my SoB too. > Signed-off-by: David Regan <dregan@broadcom.com> > --- > include/linux/mtd/rawnand.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h > index fcad94aa0515..3049b05d8a20 100644 > --- a/include/linux/mtd/rawnand.h > +++ b/include/linux/mtd/rawnand.h > @@ -1001,6 +1001,8 @@ struct nand_op_parser { > /** > * struct nand_operation - NAND operation descriptor > * @cs: the CS line to select for this NAND operation > + * @deassert_wp: set to true when the operation requires the WP pin to be > + * de-asserted (ERASE, PROG, ...) > * @instrs: array of instructions to execute > * @ninstrs: length of the @instrs array > *
I'm sorry my mistake, I had originally missed this comment which came from here: https://github.com/bbrezillon/linux/commit/e612e1f2c69a33ac5f2c91d13669f0f172d58717 On Fri, Dec 1, 2023 at 10:38 AM Boris Brezillon <boris.brezillon@collabora.com> wrote: > > On Fri, 1 Dec 2023 10:15:42 -0800 > dregan <dregan@broadcom.com> wrote: > > > From: Boris Brezillon <bbrezillon@kernel.org> > > I'm pretty sure I shouldn't be the author. The original patch might > have been partly written by me, but this is a fixup on top of it. > > > > > Add deassert_wp description comment > > > > Signed-off-by: Boris Brezillon <bbrezillon@kernel.org> > > and you should drop my SoB too. > > > Signed-off-by: David Regan <dregan@broadcom.com> > > --- > > include/linux/mtd/rawnand.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h > > index fcad94aa0515..3049b05d8a20 100644 > > --- a/include/linux/mtd/rawnand.h > > +++ b/include/linux/mtd/rawnand.h > > @@ -1001,6 +1001,8 @@ struct nand_op_parser { > > /** > > * struct nand_operation - NAND operation descriptor > > * @cs: the CS line to select for this NAND operation > > + * @deassert_wp: set to true when the operation requires the WP pin to be > > + * de-asserted (ERASE, PROG, ...) > > * @instrs: array of instructions to execute > > * @ninstrs: length of the @instrs array > > * >
diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h index fcad94aa0515..3049b05d8a20 100644 --- a/include/linux/mtd/rawnand.h +++ b/include/linux/mtd/rawnand.h @@ -1001,6 +1001,8 @@ struct nand_op_parser { /** * struct nand_operation - NAND operation descriptor * @cs: the CS line to select for this NAND operation + * @deassert_wp: set to true when the operation requires the WP pin to be + * de-asserted (ERASE, PROG, ...) * @instrs: array of instructions to execute * @ninstrs: length of the @instrs array *