| Message ID | 20231027094610.1022114-3-equu@openmail.cc |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: mtd-partitions: Export special values | expand |
On 27/10/2023 11:46, Edward Chow wrote: > Add examples for special values in linux/mtd/partitions.h. > > Signed-off-by: Edward Chow <equu@openmail.cc> > --- > .../mtd/partitions/fixed-partitions.yaml | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml b/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml > index 331e564f29dc..e7bf466c395f 100644 > --- a/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml > +++ b/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml > @@ -164,3 +164,33 @@ examples: > read-only; > }; > }; > + > + - | > + #include <dt-bindings/mtd/partitions.h> > + partitions { > + compatible = "fixed-partitions"; > + #address-cells = <2>; > + #size-cells = <1>; > + > + partition@0 { > + label = "bootloader"; > + reg = <0 0x000000 0x020000>; > + read-only; > + }; > + > + firmware@1 { > + label = "firmware"; > + /* From the end of the last partition, occupying as mush This is a friendly reminder during the review process. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof
On Fri, 27 Oct 2023 17:46:10 +0800, Edward Chow wrote: > Add examples for special values in linux/mtd/partitions.h. > > Signed-off-by: Edward Chow <equu@openmail.cc> > --- > .../mtd/partitions/fixed-partitions.yaml | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.example.dtb: calibration@2: '#address-cells' is a required property from schema $id: http://devicetree.org/schemas/mtd/partitions/fixed-partitions.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.example.dtb: calibration@2: '#size-cells' is a required property from schema $id: http://devicetree.org/schemas/mtd/partitions/fixed-partitions.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231027094610.1022114-3-equu@openmail.cc The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml b/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml index 331e564f29dc..e7bf466c395f 100644 --- a/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml +++ b/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml @@ -164,3 +164,33 @@ examples: read-only; }; }; + + - | + #include <dt-bindings/mtd/partitions.h> + partitions { + compatible = "fixed-partitions"; + #address-cells = <2>; + #size-cells = <1>; + + partition@0 { + label = "bootloader"; + reg = <0 0x000000 0x020000>; + read-only; + }; + + firmware@1 { + label = "firmware"; + /* From the end of the last partition, occupying as mush + * as possible, retaining 0x010000 after it, + * "MTDPART_OFS_SPECIAL MTDPART_OFS_NXTBLK" similar to + * this, but always beginning at erase block boundary. */ + reg = <MTDPART_OFS_SPECIAL MTDPART_OFS_RETAIN 0x010000>; + }; + + calibration@2 { + compatible = "fixed-partitions"; + label = "calibration"; + /* Appending to the last partition, occupying 0x010000 */ + reg = <MTDPART_OFS_SPECIAL MTDPART_OFS_APPEND 0x010000>; + }; + };
Add examples for special values in linux/mtd/partitions.h. Signed-off-by: Edward Chow <equu@openmail.cc> --- .../mtd/partitions/fixed-partitions.yaml | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+)