| Message ID | 20230815154412.713846-5-hsinyi@chromium.org |
|---|---|
| State | New |
| Headers | show |
| Series | Add a property to override the quad mode | expand |
Hi, On Tue, Aug 15, 2023 at 8:45 AM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > Some of the SKUs are using gigadevice gd25lq64c flash chip. The chip > default enables quad mode, which results in the write protect pin set to > IO pin. In trogdor platforms, we won't use quad enable for all SKUs, so > apply the property to disable spi nor's quad mode. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index 5a33e16a8b677..0806ce8e86bea 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -436,6 +436,7 @@ flash@0 { > spi-max-frequency = <37500000>; > spi-tx-bus-width = <2>; > spi-rx-bus-width = <2>; > + disable-quad-mode; This seems unnecessary. Unless "tx-bus-width" or "rx-bus-width" is 4 then Quad SPI isn't enabled. You don't need an explicit property since this can just be inferred from the tx and rx bus width. -Doug
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index 5a33e16a8b677..0806ce8e86bea 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -436,6 +436,7 @@ flash@0 { spi-max-frequency = <37500000>; spi-tx-bus-width = <2>; spi-rx-bus-width = <2>; + disable-quad-mode; }; };
Some of the SKUs are using gigadevice gd25lq64c flash chip. The chip default enables quad mode, which results in the write protect pin set to IO pin. In trogdor platforms, we won't use quad enable for all SKUs, so apply the property to disable spi nor's quad mode. Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> --- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 + 1 file changed, 1 insertion(+)