| Message ID | 20230531025847.1284862-2-chris.packham@alliedtelesis.co.nz |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | mtd: rawnand: marvell: add support for AC5 SoC | expand |
On Wed, May 31, 2023 at 02:58:46PM +1200, Chris Packham wrote: > Add binding for AC5 SoC. Ideally the comment about how it has only 3 of something-I-forget would go here too, explaining why you cannot use a fallback compatible. > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- > .../devicetree/bindings/mtd/marvell,nand-controller.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml > index 80ce854291cb..c09efd7a0043 100644 > --- a/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml > +++ b/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml > @@ -18,6 +18,7 @@ properties: > - enum: > - marvell,armada370-nand-controller > - marvell,pxa3xx-nand-controller > + - marvell,ac5-nand-controller IFF you end up respinning for another reason, I think alphanumerical order would be preferable. Otherwise, Acked-by: Conor Dooley <conor.dooley@microchip.com> I figure this depends on the conversion, so alphanumerical order would be good to have there from the beginning of the yaml binding's existence if it isn't already. Cheers, Conor. > > reg: > maxItems: 1 > -- > 2.40.1 >
diff --git a/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml index 80ce854291cb..c09efd7a0043 100644 --- a/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml +++ b/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml @@ -18,6 +18,7 @@ properties: - enum: - marvell,armada370-nand-controller - marvell,pxa3xx-nand-controller + - marvell,ac5-nand-controller reg: maxItems: 1
Add binding for AC5 SoC. Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> --- .../devicetree/bindings/mtd/marvell,nand-controller.yaml | 1 + 1 file changed, 1 insertion(+)