Message ID | 20230401161938.2503204-46-u.kleine-koenig@pengutronix.de |
---|---|
State | Changes Requested |
Delegated to: | Miquel Raynal |
Headers | show
Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=LaaypVsm; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=lEOEXAYE; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjWf1ShWz1yY8 for <incoming@patchwork.ozlabs.org>; Sun, 2 Apr 2023 02:38:06 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sXI39vXAaViY4PVdoVsvafI0ia8k10fJhv6Vi/rWmCQ=; b=LaaypVsmhzR3VE ovs4Uggl8wM7BFRfIHowk5kWqUFAnUGdc3F74T5g/+To7Jcfbm41q/4ffYc/WiaHSLPGSsxKCf5R7 map82D2FyqU0ap0idCNbZe8KOuGG8ef9NukFe8craiVoFeo9asP74yFWDkZq/ixBBeW82GUWejhlx YWFXRZgZ+mEuK4SKC1ebBUffPuM9UrG25cXGCcAI6sS+UcgiVQnDLaV/G0qMWom02Ohyy3j5d4pBR jvf7rkMJ03nx7hXbUyeLRlmc7SyNI4gFs7A8E97T85eqmvx/RX38dzAUBL/Vj3kYwAcgAM7L9Xno/ pvvMcOx12FkzRF54m0Yg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieEK-00AwUT-1C; Sat, 01 Apr 2023 16:37:28 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEH-00AwRk-15 for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=ojvEeNTmk3GYW05R1yrHV6n8/z4ws20erldx3TZFspQ=; b=lEOEXAYEK/TPL1scevank4Hiza S4p/RHGCtqSeHblHwdhWHbrhhc6C/1oKAx1+mqckL1ItXf6Mcq9Oc15zSkB4DZxDYEogG7Lg4Fjq5 zp12x71vWU/mTzck0bH4NTrOyr7r13DdIPtISJsNQwdKS4xakDz1MbG34lMp6sNvjRDFkeJUwwyBG 5fP3Jd5XV3TkS6fQ5cpx/zhs5+Zab+W/gUc7VEK/0bXC4qBio0pFWJFINHTFH9hHyNL2gEK4K8Ctw X5buMv/FST22DleCBWJ+N/6015iWwD+k6a8klF74FEUygVsgvikYorldxoO9kQUB+D0J3IHZ5duEL 1RwQfzJQ==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxW-00CYSj-CB for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:14 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ukl@pengutronix.de>) id 1pidxO-0000HA-E2; Sat, 01 Apr 2023 18:19:58 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pidxM-008GT4-N4; Sat, 01 Apr 2023 18:19:56 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pidxL-009khy-Mn; Sat, 01 Apr 2023 18:19:55 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> To: Miquel Raynal <miquel.raynal@bootlin.com>, Vignesh Raghavendra <vigneshr@ti.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Christophe Kerello <christophe.kerello@foss.st.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Jack Wang <jinpu.wang@ionos.com> Cc: Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 45/49] mtd: rawnand: stm32_fmc2: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:34 +0200 Message-Id: <20230401161938.2503204-46-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1912; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=AEOfFfpg8jnamUficc+JbatV7+ft2JVAarvqxLIvw2c=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlQYs1o0K6QqS7EEqapqX9nS62hboypZ4nf4 48fJjzJYDyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZUAAKCRCPgPtYfRL+ ThSrB/9r9Cg7UBQvFzPFrqICftflvmP1LawosdzFYl0KYvNmgvXQNCfcc1lYm206AYw6g9u/RZm PTw9ugnrMAvf9E8vDSRj9bTIG4ebb4w0kImvQgJOfv9VUKGmFETqUC3tBtvenGRt/9hmPxaUlmn xm0fR0IE+A2GT7JCh8TJmWYA6qiyTxUtW/QV7076WXcixvAffoE+u3CdFBpUH5ubfWFYKRl9V9I /OvaTYpY0+xvVvMqIylLWTmjuTKH7uhDic8Q6twEKy+ucYS4Doo6R+iY8zZOeZBPTWPfjVzYuzP Tt/hpkDNogojwR6qsfh5+RbvrACEJD6ittMOm+p4oG9Exytw X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172006_445454_74535D4A X-CRM114-Status: GOOD ( 13.16 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/> List-Post: <mailto:linux-mtd@lists.infradead.org> List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
mtd: nand: Convert to platform remove callback returning void
|
expand
|
diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c index 5d627048c420..e3d09dd5963b 100644 --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c @@ -2021,7 +2021,7 @@ static int stm32_fmc2_nfc_probe(struct platform_device *pdev) return ret; } -static int stm32_fmc2_nfc_remove(struct platform_device *pdev) +static void stm32_fmc2_nfc_remove(struct platform_device *pdev) { struct stm32_fmc2_nfc *nfc = platform_get_drvdata(pdev); struct stm32_fmc2_nand *nand = &nfc->nand; @@ -2045,8 +2045,6 @@ static int stm32_fmc2_nfc_remove(struct platform_device *pdev) clk_disable_unprepare(nfc->clk); stm32_fmc2_nfc_wp_enable(nand); - - return 0; } static int __maybe_unused stm32_fmc2_nfc_suspend(struct device *dev) @@ -2103,7 +2101,7 @@ MODULE_DEVICE_TABLE(of, stm32_fmc2_nfc_match); static struct platform_driver stm32_fmc2_nfc_driver = { .probe = stm32_fmc2_nfc_probe, - .remove = stm32_fmc2_nfc_remove, + .remove_new = stm32_fmc2_nfc_remove, .driver = { .name = "stm32_fmc2_nfc", .of_match_table = stm32_fmc2_nfc_match,
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/mtd/nand/raw/stm32_fmc2_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)