Message ID | 20230401161938.2503204-45-u.kleine-koenig@pengutronix.de |
---|---|
State | Changes Requested |
Delegated to: | Miquel Raynal |
Headers | show
Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=0y1QOJuw; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=Nv+T9WWu; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjWr4mCsz1yY8 for <incoming@patchwork.ozlabs.org>; Sun, 2 Apr 2023 02:38:16 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vAnO4dtTI1SXYO7iq2uDkdLc89Q9QBhyN4si8I/5MFs=; b=0y1QOJuwdhlvcN 8gVLdBu0cZmjNKJToJcoHgr1Id2OrFjwBXueE+JHXCgMf55e5n+4FWygqG7iquhLYefTiT+jm0BM3 qOXw2lYOMDX5eOXvLF9zp2ypphzvRbo+dmrkFbJQcVKDSazdT5hBkWkS0QhN/lp0L3JoIi9xzW9zw /fkXcvz49PMb0e2ItWCjYhg7sJhge/a59WzB6rBXtrJ/Mb5KCABPXIrNWumfDu1VGZQqevg8MPc7g LB0mxK94qlYBfApJ59fBp1Nu/ctefIAmp9sFHHcjcnKf/nYYRDzJW9bFXhbiPdwYdCgS0NAAVptvs DJOw7XnHrPR0b/bjpqHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieET-00Awal-0C; Sat, 01 Apr 2023 16:37:37 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEJ-00AwRk-1K for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=0dlD/ciAM1mAdaJeniyJfYCyGG0Ji/lVaYEE5QDKm2E=; b=Nv+T9WWuXEbu7y/xXtdfMX0n+v B+XJM7nLMk5OO1B7csW/KYMDADbbfXbsn86OFQQv/j5D55hAO2Sx5tTDiA46paopj/LrXJ4vpzmBb LQMNpwgcedUmhDSjbhme+bV7/3fjOmc8iwhLC72JALNt8yljVkoarv7eVXw+7HZG2eHfvgwFdUtV6 xfu0eYy5KUyhwhUh/+Nkv0PHMf6L2WCSfmPxUR0cSItEL7PVCrKZIxVQxL4PoioEVqfvVkgTxZ+S4 yr9/Gd4B16aQfwuUMEIoOchW5bKNs5devjAAYehEgqRLvz8CexwO9dL7gaMmhKJBTwutYOvCVmN6X CFDhpxkA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxU-00CYS4-Ps for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:12 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ukl@pengutronix.de>) id 1pidxP-0000N0-LF; Sat, 01 Apr 2023 18:19:59 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pidxN-008GTQ-M0; Sat, 01 Apr 2023 18:19:57 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pidxL-009khu-Fr; Sat, 01 Apr 2023 18:19:55 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> To: Miquel Raynal <miquel.raynal@bootlin.com>, Vignesh Raghavendra <vigneshr@ti.com> Cc: Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 44/49] mtd: rawnand: socrates: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:33 +0200 Message-Id: <20230401161938.2503204-45-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1848; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=ubqLpURaWIdRpwU4SbY9gA9Nj93h7rIhZhWsYkx7Yqk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlPiK0nHU5VZtlcPwHjM3pOl5BJPTRkzbG14 XLSiYjIDzqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZTwAKCRCPgPtYfRL+ ToxGB/4wV1VkjAunagUxV/4qSr4uxkRG2WdKKpGYttkUj99xWx/hMpZGFQ3ZEQHPG1KTRraaiHT UPo7kvnhcQb+dWyH8zs8WkN/GIf04OAuU+rXpnfgIX8g+mJkJhBhFF0xDE2siVQGqN02fe7iZHK vWtWU/ZvX9a1wNrYyOspdc8hxI4wZlAjiCuQ91fzZnIcNB4sA18MEp0GrHiYNdVkkQ99A91J5rK ki4FvLhxpoPpe3TH+EuvMLulTBOPBpB4CcAn2jI3fCXD1LzsnBHcffyS7iTJ/+lYdn7pTpGnvYp XN3pF6JPg9JOwQ0gmB3ttsMKzitOUUFwDecbqB90agJW1H6X X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172004_877285_DA77E0E8 X-CRM114-Status: GOOD ( 13.39 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/> List-Post: <mailto:linux-mtd@lists.infradead.org> List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
mtd: nand: Convert to platform remove callback returning void
|
expand
|
diff --git a/drivers/mtd/nand/raw/socrates_nand.c b/drivers/mtd/nand/raw/socrates_nand.c index fb39cc7ebce0..a8b720ffe9e8 100644 --- a/drivers/mtd/nand/raw/socrates_nand.c +++ b/drivers/mtd/nand/raw/socrates_nand.c @@ -201,7 +201,7 @@ static int socrates_nand_probe(struct platform_device *ofdev) /* * Remove a NAND device. */ -static int socrates_nand_remove(struct platform_device *ofdev) +static void socrates_nand_remove(struct platform_device *ofdev) { struct socrates_nand_host *host = dev_get_drvdata(&ofdev->dev); struct nand_chip *chip = &host->nand_chip; @@ -212,8 +212,6 @@ static int socrates_nand_remove(struct platform_device *ofdev) nand_cleanup(chip); iounmap(host->io_base); - - return 0; } static const struct of_device_id socrates_nand_match[] = @@ -232,7 +230,7 @@ static struct platform_driver socrates_nand_driver = { .of_match_table = socrates_nand_match, }, .probe = socrates_nand_probe, - .remove = socrates_nand_remove, + .remove_new = socrates_nand_remove, }; module_platform_driver(socrates_nand_driver);
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/mtd/nand/raw/socrates_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)