Message ID | 20230401161938.2503204-30-u.kleine-koenig@pengutronix.de |
---|---|
State | Changes Requested |
Delegated to: | Miquel Raynal |
Headers | show
Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=fMiQ4kki; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=gdmgChvY; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj9R0dGbz1yY8 for <incoming@patchwork.ozlabs.org>; Sun, 2 Apr 2023 02:22:19 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kFBgulmdF1Jj9Awj0wgudBu0MCxwczECIVlTh1nj620=; b=fMiQ4kkiNZGgPJ doJ2BNL2fx6w0okvDE6yZO5uhxqyaxTIDQj9jQms16XS9p+KZEXkBOl0XagEHUCD0fKLBQygwg1V5 vs+4y/2FhOSknZ/cJOe289NMU8f/E3ofE3ZqhG7OQt6O35Mdn33mByBbckUJR6CWBQpYMbcpm8X1A BDkXnpM9aEe4CyhXL47I9ArYDyojdKnSz3hL2PxSlTuSv/PMjPAwpm5p85Mvjb8yE7rO0DWLeEvOk p+2olNxvoRF6zCMgfpciW1MCEGBpX9ONUllDpa6gBrq8TuylU6lxUCWl+dvdCFRBN+kAuJWpwPu5F DoNUanYOX1HsXkInpu3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidz8-00AtPX-2M; Sat, 01 Apr 2023 16:21:46 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxg-00AsJU-0V for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:20:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=PvIIyOgWTRJ/ZciFDr04PorRcSxoJ3RyFpQBQxFwan4=; b=gdmgChvY14OgzzoMs7CmLnN7Ga JUIMMj6ZwFc+luAa0LxewTf+WsVAwe7HsMUYpyjU9u/5ejV9x7qv4pp4ecVTa7JCvACEUm+tP9caX 94ijTN7+kWDk8TZCPzH4C2/0XSloBOlxxSE6klguh4iitp1GHgB98vc0Tx0vOvcoKIYwV/5El//5n Ih4UcXl+HkY/oQwizFunaZbeYpWkZ0VYgCrWZvv1Sn3CGxlWr2PnZNiV4AT8H4TJutUqgqpK1253Y 6+n2A2HIBIX4pKWLe5Xn8kt1nQ9TbI/WrpcWJNLs3Wqxz0D/ib62rCnGUqIEt/QVHMM0kL3xng/zW yRlmIMfw==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-008DKo-14 for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:15 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ukl@pengutronix.de>) id 1pidxK-0008Nj-AD; Sat, 01 Apr 2023 18:19:54 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pidxJ-008GRp-3x; Sat, 01 Apr 2023 18:19:53 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pidxI-009kgw-Bd; Sat, 01 Apr 2023 18:19:52 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> To: Miquel Raynal <miquel.raynal@bootlin.com>, Vignesh Raghavendra <vigneshr@ti.com> Cc: Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 29/49] mtd: rawnand: mxic: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:18 +0200 Message-Id: <20230401161938.2503204-30-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1770; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=rWPkYqoEydSYHk43eQLy3o1FwM6CRP1SaxcZbhcEOt0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFkvxAwMTjlzxl5e/Lo/aYyDwbCiiDeaeyWOt nZ6UXAjodKJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZLwAKCRCPgPtYfRL+ TncBB/oDqI9rby3kUJ5uf4k4YlV0zGefT6LlTjpE5julwHre+/93kY5WMwVn/ZOrY0t8zbzrBmW spDsLPEGV7+U7PHDo/BSzrPzoyOULf8sKHXiU4JwarNREkOcYdPii48XZ4j7AH+cufDXpadqANY giiL17O5U3OOGjkI/lwQmUBp7OvbtHLLfXcKNjzsIBH3mvm4fnDoRRtlYochm4I2996cn0j9HFc aomcXtFpJL6bYPYE89yEcoRgNlOUyq3ul1USFK2EJ7EKyRSMPIHwiHVpLHLJBkLSjcA3eDxs+57 dRUlMB6pW5eBM1q0cBdNC5DM+pkDuvAYvUm8nrv4SXSohme+ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172007_729231_35A7161A X-CRM114-Status: GOOD ( 16.72 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/> List-Post: <mailto:linux-mtd@lists.infradead.org> List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
mtd: nand: Convert to platform remove callback returning void
|
expand
|
diff --git a/drivers/mtd/nand/raw/mxic_nand.c b/drivers/mtd/nand/raw/mxic_nand.c index da1070993994..be8050e84b4f 100644 --- a/drivers/mtd/nand/raw/mxic_nand.c +++ b/drivers/mtd/nand/raw/mxic_nand.c @@ -553,7 +553,7 @@ static int mxic_nfc_probe(struct platform_device *pdev) return err; } -static int mxic_nfc_remove(struct platform_device *pdev) +static void mxic_nfc_remove(struct platform_device *pdev) { struct mxic_nand_ctlr *nfc = platform_get_drvdata(pdev); struct nand_chip *chip = &nfc->chip; @@ -564,7 +564,6 @@ static int mxic_nfc_remove(struct platform_device *pdev) nand_cleanup(chip); mxic_nfc_clk_disable(nfc); - return 0; } static const struct of_device_id mxic_nfc_of_ids[] = { @@ -575,7 +574,7 @@ MODULE_DEVICE_TABLE(of, mxic_nfc_of_ids); static struct platform_driver mxic_nfc_driver = { .probe = mxic_nfc_probe, - .remove = mxic_nfc_remove, + .remove_new = mxic_nfc_remove, .driver = { .name = "mxic-nfc", .of_match_table = mxic_nfc_of_ids,
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/mtd/nand/raw/mxic_nand.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)