Message ID | 20230401161938.2503204-18-u.kleine-koenig@pengutronix.de |
---|---|
State | Changes Requested |
Delegated to: | Miquel Raynal |
Headers | show
Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=b0DU2xSz; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=NuZert1l; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj8W21ZYz1yY8 for <incoming@patchwork.ozlabs.org>; Sun, 2 Apr 2023 02:21:31 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bcf8BZOEZqMPelC2JVwPn4uxwxS97+alV8xRmIrXjKQ=; b=b0DU2xSzFVBvV6 Henq6h9jZIq3ICIamY9L46Gu0fRoBSVMm64r7iPx/z4D3NnnHv69p9n8Cqw/z/UWbvRdwBGPbhGtA GnZVRxIWxijCpp9BncPAqhm+BgDYZnWnmhE1/Dm99nD+I59e988MNHQGYX3/1SOivUH9r0kufzAzi /dwoYuYS7aLh/TGUN7Iw9jB92IlcyrP49JSVMnbYwE+6h7fpHwAFotP73k1JQt6alxVoZW5YWt2Po IzrOOGaqboybMUpQLqeo94v6elhq1KA5xU4NTZi5eiWy5CjJeU9UnHpnnYQvwoNZxIkouW7u3D5sn MN0fZgVGZIW/x2UxCjAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidyL-00Asg2-0v; Sat, 01 Apr 2023 16:20:57 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxd-00AsHc-1v for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:20:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=2GBW08o9sTvlTKfiDQpR1H3c6dpyS4I0ZoJMTPm2OzM=; b=NuZert1lmm6ucUCoCB05UcygZ7 sWjFg1SPyW9HJlBv1TfXk3l8VkFj9STcYDbkeZkokCmVgg1OyvT1KmFSMLqim2beojy8Z6+tWri6f fBduuYN1D/AMtoD2l1DhGcAmapoa8QhP3CZqNO2xKfm8/6JwgEQG3mDJSIsZ1uaChxOGhM+hpSJLc 93m6EKYq90nnVUmA3m93zJEl3604p+7XETx16iI/ODFdq9Nm7TxQhRRW/nYN/YZ6HqdUe5d8LFnVQ GRm0SZ/e+h25x/vcyofw4MLf5T4SfUeJWToWOZ8ml78Yiyg+fGCY1tyHt1mjsSqFQx6bAqkekvFHf fClCbCRA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxW-008DKn-2c for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:12 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ukl@pengutronix.de>) id 1pidxI-0008Iv-HG; Sat, 01 Apr 2023 18:19:52 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pidxH-008GR5-JB; Sat, 01 Apr 2023 18:19:51 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pidxF-009kg8-Q5; Sat, 01 Apr 2023 18:19:49 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> To: Miquel Raynal <miquel.raynal@bootlin.com>, Vignesh Raghavendra <vigneshr@ti.com> Cc: Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 17/49] mtd: rawnand: gpio: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:06 +0200 Message-Id: <20230401161938.2503204-18-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1905; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=Qa0UNc0ZLq5BiHzyZQHe7oOtRkhVAwb/C37f8QKiCIg=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFkDDoqKcvCvM36bnCMSmTLzMEL9FaZobvqbk HnwgOPymZyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZAwAKCRCPgPtYfRL+ TkkcB/9PL5+WTs93Q17vScnxfBpWbznl+xUvpL8jGLwvbHdet19/2n3z0llWMcQI6AsNixAuvsr 4evR4K+aoIieWmTdJaIzSE55RZqsOsS1nmdokBIQrOE2ir6cO2JMIFG7iF24H9ESwzmekrWCDn4 HhtfG/Mu8vHzMTFyxXqlLxY8xUgMQW7nr5lO3JHk41XoRfZ8GfPRMv9lq59lAo2PvOV/RrsxQSK 8voa6kst0BaPzo0V6uf0SqvNt3XO4s3zOp7IJHnSuzJo8FJhJMAFIGpv4WJk/DnMY211PWzNINj cSoqspa/BvE5KJE17diR5YynArdFWTbcNbw1Rcaz+kUtpPV2 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172007_094039_F625ACA4 X-CRM114-Status: GOOD ( 16.06 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/> List-Post: <mailto:linux-mtd@lists.infradead.org> List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
mtd: nand: Convert to platform remove callback returning void
|
expand
|
diff --git a/drivers/mtd/nand/raw/gpio.c b/drivers/mtd/nand/raw/gpio.c index dcf28cff760d..d6cc2cb65214 100644 --- a/drivers/mtd/nand/raw/gpio.c +++ b/drivers/mtd/nand/raw/gpio.c @@ -265,7 +265,7 @@ gpio_nand_get_io_sync(struct platform_device *pdev) return platform_get_resource(pdev, IORESOURCE_MEM, 1); } -static int gpio_nand_remove(struct platform_device *pdev) +static void gpio_nand_remove(struct platform_device *pdev) { struct gpiomtd *gpiomtd = platform_get_drvdata(pdev); struct nand_chip *chip = &gpiomtd->nand_chip; @@ -280,8 +280,6 @@ static int gpio_nand_remove(struct platform_device *pdev) gpiod_set_value(gpiomtd->nwp, 0); if (gpiomtd->nce && !IS_ERR(gpiomtd->nce)) gpiod_set_value(gpiomtd->nce, 0); - - return 0; } static int gpio_nand_probe(struct platform_device *pdev) @@ -394,7 +392,7 @@ static int gpio_nand_probe(struct platform_device *pdev) static struct platform_driver gpio_nand_driver = { .probe = gpio_nand_probe, - .remove = gpio_nand_remove, + .remove_new = gpio_nand_remove, .driver = { .name = "gpio-nand", .of_match_table = of_match_ptr(gpio_nand_id_table),
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/mtd/nand/raw/gpio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)