Message ID | 20220330182816.1177341-1-jmeurin@google.com |
---|---|
State | Changes Requested |
Headers | show |
Series | Fix the size of the header read buffer. | expand |
On Wed, Mar 30, 2022 at 11:28 AM Jean-Marc Eurin <jmeurin@google.com> wrote: > > The read buffer size depends on the MTDOOPS_HEADER_SIZE. > > Tested: Changed the header size, it doesn't panic, header is still > read/written correctly. > > Signed-off-by: Jean-Marc Eurin <jmeurin@google.com> > --- > drivers/mtd/mtdoops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/mtdoops.c b/drivers/mtd/mtdoops.c > index 227df24387df..09a26747f490 100644 > --- a/drivers/mtd/mtdoops.c > +++ b/drivers/mtd/mtdoops.c > @@ -223,7 +223,7 @@ static void find_next_position(struct mtdoops_context *cxt) > { > struct mtd_info *mtd = cxt->mtd; > int ret, page, maxpos = 0; > - u32 count[2], maxcount = 0xffffffff; > + u32 count[MTDOOPS_HEADER_SIZE/sizeof(u32)], maxcount = 0xffffffff; > size_t retlen; > > for (page = 0; page < cxt->oops_pages; page++) { > -- > 2.35.0.rc2.247.g8bbb082509-goog > Sorry, please ignore this duplicate patch/email. Jean-Marc
diff --git a/drivers/mtd/mtdoops.c b/drivers/mtd/mtdoops.c index 227df24387df..09a26747f490 100644 --- a/drivers/mtd/mtdoops.c +++ b/drivers/mtd/mtdoops.c @@ -223,7 +223,7 @@ static void find_next_position(struct mtdoops_context *cxt) { struct mtd_info *mtd = cxt->mtd; int ret, page, maxpos = 0; - u32 count[2], maxcount = 0xffffffff; + u32 count[MTDOOPS_HEADER_SIZE/sizeof(u32)], maxcount = 0xffffffff; size_t retlen; for (page = 0; page < cxt->oops_pages; page++) {
The read buffer size depends on the MTDOOPS_HEADER_SIZE. Tested: Changed the header size, it doesn't panic, header is still read/written correctly. Signed-off-by: Jean-Marc Eurin <jmeurin@google.com> --- drivers/mtd/mtdoops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)