| Message ID | 20220315165607.390070-2-ikegami.t@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Vignesh R |
| Headers | show |
| Series | mtd: cfi_cmdset_0002: Use chip_ready() for write on S29GL064N | expand |
Hi Tokunori, ikegami.t@gmail.com wrote on Wed, 16 Mar 2022 01:56:05 +0900: > It is for the model number 01, 02, V1 and V2. Please move this change to the end of the series. We do not need to backport this improvement. Also use the hexadecimal value in your fix (patch 3/3) so that we can apply it easily to older kernels. > Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com> > Cc: Miquel Raynal <miquel.raynal@bootlin.com> > Cc: Richard Weinberger <richard@nod.at> > Cc: Vignesh Raghavendra <vigneshr@ti.com> > Cc: linux-mtd@lists.infradead.org > --- > drivers/mtd/chips/cfi_cmdset_0002.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c > index a761134fd3be..0125658a1d30 100644 > --- a/drivers/mtd/chips/cfi_cmdset_0002.c > +++ b/drivers/mtd/chips/cfi_cmdset_0002.c > @@ -48,6 +48,7 @@ > #define SST49LF040B 0x0050 > #define SST49LF008A 0x005a > #define AT49BV6416 0x00d6 > +#define S29GL064N_MN12 0x0c01 > > /* > * Status Register bit description. Used by flash devices that don't > @@ -462,7 +463,7 @@ static struct cfi_fixup cfi_fixup_table[] = { > { CFI_MFR_AMD, 0x0056, fixup_use_secsi }, > { CFI_MFR_AMD, 0x005C, fixup_use_secsi }, > { CFI_MFR_AMD, 0x005F, fixup_use_secsi }, > - { CFI_MFR_AMD, 0x0c01, fixup_s29gl064n_sectors }, > + { CFI_MFR_AMD, S29GL064N_MN12, fixup_s29gl064n_sectors }, > { CFI_MFR_AMD, 0x1301, fixup_s29gl064n_sectors }, > { CFI_MFR_AMD, 0x1a00, fixup_s29gl032n_sectors }, > { CFI_MFR_AMD, 0x1a01, fixup_s29gl032n_sectors }, Thanks, Miquèl
Hi, On 2022/03/16 3:37, Miquel Raynal wrote: > Hi Tokunori, > > ikegami.t@gmail.com wrote on Wed, 16 Mar 2022 01:56:05 +0900: > >> It is for the model number 01, 02, V1 and V2. > Please move this change to the end of the series. We do not need to > backport this improvement. > > Also use the hexadecimal value in your fix (patch 3/3) so that we can > apply it easily to older kernels. Fixed by the version 4 patches. Regards, Ikegami > >> Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com> >> Cc: Miquel Raynal <miquel.raynal@bootlin.com> >> Cc: Richard Weinberger <richard@nod.at> >> Cc: Vignesh Raghavendra <vigneshr@ti.com> >> Cc: linux-mtd@lists.infradead.org >> --- >> drivers/mtd/chips/cfi_cmdset_0002.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c >> index a761134fd3be..0125658a1d30 100644 >> --- a/drivers/mtd/chips/cfi_cmdset_0002.c >> +++ b/drivers/mtd/chips/cfi_cmdset_0002.c >> @@ -48,6 +48,7 @@ >> #define SST49LF040B 0x0050 >> #define SST49LF008A 0x005a >> #define AT49BV6416 0x00d6 >> +#define S29GL064N_MN12 0x0c01 >> >> /* >> * Status Register bit description. Used by flash devices that don't >> @@ -462,7 +463,7 @@ static struct cfi_fixup cfi_fixup_table[] = { >> { CFI_MFR_AMD, 0x0056, fixup_use_secsi }, >> { CFI_MFR_AMD, 0x005C, fixup_use_secsi }, >> { CFI_MFR_AMD, 0x005F, fixup_use_secsi }, >> - { CFI_MFR_AMD, 0x0c01, fixup_s29gl064n_sectors }, >> + { CFI_MFR_AMD, S29GL064N_MN12, fixup_s29gl064n_sectors }, >> { CFI_MFR_AMD, 0x1301, fixup_s29gl064n_sectors }, >> { CFI_MFR_AMD, 0x1a00, fixup_s29gl032n_sectors }, >> { CFI_MFR_AMD, 0x1a01, fixup_s29gl032n_sectors }, > > Thanks, > Miquèl
diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index a761134fd3be..0125658a1d30 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -48,6 +48,7 @@ #define SST49LF040B 0x0050 #define SST49LF008A 0x005a #define AT49BV6416 0x00d6 +#define S29GL064N_MN12 0x0c01 /* * Status Register bit description. Used by flash devices that don't @@ -462,7 +463,7 @@ static struct cfi_fixup cfi_fixup_table[] = { { CFI_MFR_AMD, 0x0056, fixup_use_secsi }, { CFI_MFR_AMD, 0x005C, fixup_use_secsi }, { CFI_MFR_AMD, 0x005F, fixup_use_secsi }, - { CFI_MFR_AMD, 0x0c01, fixup_s29gl064n_sectors }, + { CFI_MFR_AMD, S29GL064N_MN12, fixup_s29gl064n_sectors }, { CFI_MFR_AMD, 0x1301, fixup_s29gl064n_sectors }, { CFI_MFR_AMD, 0x1a00, fixup_s29gl032n_sectors }, { CFI_MFR_AMD, 0x1a01, fixup_s29gl032n_sectors },
It is for the model number 01, 02, V1 and V2. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com> Cc: Miquel Raynal <miquel.raynal@bootlin.com> Cc: Richard Weinberger <richard@nod.at> Cc: Vignesh Raghavendra <vigneshr@ti.com> Cc: linux-mtd@lists.infradead.org --- drivers/mtd/chips/cfi_cmdset_0002.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)