From patchwork Fri Mar 5 08:29:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 1447689 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=DcNOuuKg; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=o/KIh+GX; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DsLYN0Yz2z9sVS for ; Fri, 5 Mar 2021 19:31:20 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=XoFaA76NOm8VGZPys/bR+rRly735B7HS8BOH1caXdBg=; b=DcNOuuKgnon2WZLAjw6ybrwGol i8RcwB6yu4v3PkxNFXnPVCEjAXFhIksHyqIa30QlVZKQhXZYaY7njavDcoCwdni5Dyjidn+ZnCR1t 5PUP5LsshIVvBQ9nlHuLCbPvvxE6VeJmIvnNHm9KmWi/64YrfPMXZJzGc9jTAoK4mYkQ0bR5SyqZW ID9vrWRzxkDxmgFijnpqml6fQyZRvZEk1UIMJJIU/egxqATQSOCDRDA8b0Cu4Qkv1wzLA7m4oktjw Odf3TKF5EZlDU5vQJPEG0cv13XN5T3AvWfuGXOJCvb/cJ0tCm+pRmRz6Me1gKnnEeOoULyYFt4LKG 1Z77vstA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lI5qn-00E0OE-Du; Fri, 05 Mar 2021 08:30:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lI5qQ-00E0IX-1M; Fri, 05 Mar 2021 08:30:00 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 68A8D65011; Fri, 5 Mar 2021 08:29:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614932996; bh=9Roq1+ktzTZSK6gD+rBHK9mji+a80aPRur08v7e2wvY=; h=Date:From:To:Cc:Subject:From; b=o/KIh+GXKNRmP5lEF2qV1cyPu6qDmzDaCPJtTJzinhE5IJdfcIvK5SFVF9W6p6fev IRLsoPGPVVdovZu4e4mLsB4kIo1tNMo5hzduk8GfeLQgySFmOaTQyA0yCo+K7x1NF2 yokgvx7yPhok1MS3EDomQ9YGP/xnE3bxEAa2qc5mrWO+V/zcmAijAjQ7/NCoEruE8J gB64g9qhY9FLOL+O5z2tOYBjhRBTykJU4huS5PIuKAqrB30j+katjW7yy1OyXhxCR2 Zk1YtT8NtcwRVM2UrQVHy2B73gfdF61Zmirqa6hFYht+jZcLv52AfhSgSKggyOqzCI wdhnk+SfdHxCw== Date: Fri, 5 Mar 2021 02:29:53 -0600 From: "Gustavo A. R. Silva" To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Maxime Coquelin , Alexandre Torgue Cc: linux-mtd@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH v3][next] mtd: rawnand: stm32_fmc2: Fix fall-through warnings for Clang Message-ID: <20210305082953.GA137771@embeddedor> MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_082958_662738_2D4316B3 X-CRM114-Status: UNSURE ( 8.27 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -5.5 (-----) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple of warnings by explicitly adding a couple of break statements instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- Changes in v3: Update the changelog text according to the actual code change. Content analysis details: (-5.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [198.145.29.99 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.3 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple of warnings by explicitly adding a couple of break statements instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- Changes in v3: Update the changelog text according to the actual code change. Changes in v2: Make use of a break statement instead of fallthrough for consistency. Link: https://lore.kernel.org/lkml/20201123093347.719a77cf@xps13/ drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c index 550bda4d1415..1c277fbb91f2 100644 --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c @@ -531,6 +531,7 @@ static int stm32_fmc2_nfc_ham_correct(struct nand_chip *chip, u8 *dat, switch (b % 4) { case 2: bit_position += shifting; + break; case 1: break; default: @@ -546,6 +547,7 @@ static int stm32_fmc2_nfc_ham_correct(struct nand_chip *chip, u8 *dat, switch (b % 4) { case 2: byte_addr += shifting; + break; case 1: break; default: