| Message ID | 20201126130422.92945-12-hch@lst.de |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [01/44] blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats | expand |
On 11/26/20 2:03 PM, Christoph Hellwig wrote: > sector_t is now always a u64, so this check is not needed. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > Acked-by: Tejun Heo <tj@kernel.org> > Reviewed-by: Jan Kara <jack@suse.cz> > --- > block/ioctl.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/block/ioctl.c b/block/ioctl.c > index 6b785181344fe1..0c09bb7a6ff35f 100644 > --- a/block/ioctl.c > +++ b/block/ioctl.c > @@ -35,15 +35,6 @@ static int blkpg_do_ioctl(struct block_device *bdev, > start = p.start >> SECTOR_SHIFT; > length = p.length >> SECTOR_SHIFT; > > - /* check for fit in a hd_struct */ > - if (sizeof(sector_t) < sizeof(long long)) { > - long pstart = start, plength = length; > - > - if (pstart != start || plength != length || pstart < 0 || > - plength < 0 || p.pno > 65535) > - return -EINVAL; > - } > - > switch (op) { > case BLKPG_ADD_PARTITION: > /* check if partition is aligned to blocksize */ > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
diff --git a/block/ioctl.c b/block/ioctl.c index 6b785181344fe1..0c09bb7a6ff35f 100644 --- a/block/ioctl.c +++ b/block/ioctl.c @@ -35,15 +35,6 @@ static int blkpg_do_ioctl(struct block_device *bdev, start = p.start >> SECTOR_SHIFT; length = p.length >> SECTOR_SHIFT; - /* check for fit in a hd_struct */ - if (sizeof(sector_t) < sizeof(long long)) { - long pstart = start, plength = length; - - if (pstart != start || plength != length || pstart < 0 || - plength < 0 || p.pno > 65535) - return -EINVAL; - } - switch (op) { case BLKPG_ADD_PARTITION: /* check if partition is aligned to blocksize */