Message ID | 20201126030946.2058-1-festevam@gmail.com |
---|---|
State | Accepted |
Headers | show |
Series | mtd: rawnand: gpmi: Use of_device_get_match_data() | expand |
On Thu, 2020-11-26 at 03:09:46 UTC, Fabio Estevam wrote: > The retrieval of driver data via of_device_get_match_data() can make > the code simpler. > > Use of_device_get_match_data() to simplify the code. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel
diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c index b5f46f214a58..0d30f3fbb045 100644 --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c @@ -2487,21 +2487,13 @@ MODULE_DEVICE_TABLE(of, gpmi_nand_id_table); static int gpmi_nand_probe(struct platform_device *pdev) { struct gpmi_nand_data *this; - const struct of_device_id *of_id; int ret; this = devm_kzalloc(&pdev->dev, sizeof(*this), GFP_KERNEL); if (!this) return -ENOMEM; - of_id = of_match_device(gpmi_nand_id_table, &pdev->dev); - if (of_id) { - this->devdata = of_id->data; - } else { - dev_err(&pdev->dev, "Failed to find the right device id.\n"); - return -ENODEV; - } - + this->devdata = of_device_get_match_data(&pdev->dev); platform_set_drvdata(pdev, this); this->pdev = pdev; this->dev = &pdev->dev;
The retrieval of driver data via of_device_get_match_data() can make the code simpler. Use of_device_get_match_data() to simplify the code. Signed-off-by: Fabio Estevam <festevam@gmail.com> --- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)