| Message ID | 20201103115645.684-1-kechengsong@huawei.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] mtd:ubi: Remove useless code in bytes_str_to_int | expand |
On Tue, Nov 3, 2020 at 1:00 PM Chengsong Ke <kechengsong@huawei.com> wrote: > > From: k00524021 <kechengsong@huawei.com> > > As a local variable, "endp" is neither refered nor returned > after this line "endp += 2", it looks like a useless code, > suggest to remove it. > > Signed-off-by: Chengsong Ke <kechengsong@huawei.com> > --- > drivers/mtd/ubi/build.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c > index e85b04e9716b..46a6dd75e533 100644 > --- a/drivers/mtd/ubi/build.c > +++ b/drivers/mtd/ubi/build.c > @@ -1351,8 +1351,6 @@ static int bytes_str_to_int(const char *str) > fallthrough; > case 'K': > result *= 1024; > - if (endp[1] == 'i' && endp[2] == 'B') > - endp += 2; Makes sense. But why did you send a v2?
On Tue, Nov 3, 2020 at 1:00 PM Chengsong Ke <kechengsong@huawei.com> wrote: > > From: Chengsong Ke <kechengsong@huawei.com> > > As a local variable, "endp" is neither refered nor returned after this > line "endp += 2", it looks like a useless code, suggest to remove it. > > Signed-off-by: Chengsong Ke <kechengsong@huawei.com> > --- > drivers/mtd/ubi/build.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index > e85b04e9716b..46a6dd75e533 100644 > --- a/drivers/mtd/ubi/build.c > +++ b/drivers/mtd/ubi/build.c > @@ -1351,8 +1351,6 @@ static int bytes_str_to_int(const char *str) > fallthrough; > case 'K': > result *= 1024; > - if (endp[1] == 'i' && endp[2] == 'B') > - endp += 2; > Makes sense. But why did you send a v2? > -- > Thanks, > //richard I just send the v1 with the wrong module name 'ubifs'. [PATCH] ubifs: Remove useless code in bytes_str_to_int :-) Thanks, //Chengsong Ke
On Tue, Nov 3, 2020 at 1:00 PM Chengsong Ke <kechengsong@huawei.com> wrote: > > From: Chengsong Ke <kechengsong@huawei.com> > > As a local variable, "endp" is neither refered nor returned after this > line "endp += 2", it looks like a useless code, suggest to remove it. > > Signed-off-by: Chengsong Ke <kechengsong@huawei.com> > --- > drivers/mtd/ubi/build.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index > e85b04e9716b..46a6dd75e533 100644 > --- a/drivers/mtd/ubi/build.c > +++ b/drivers/mtd/ubi/build.c > @@ -1351,8 +1351,6 @@ static int bytes_str_to_int(const char *str) > fallthrough; > case 'K': > result *= 1024; > - if (endp[1] == 'i' && endp[2] == 'B') > - endp += 2; > Makes sense. But why did you send a v2? > -- > Thanks, > //richard > I just send the v1 with the wrong module name 'ubifs'. > [PATCH] ubifs: Remove useless code in bytes_str_to_int > :-) > Thanks, > //Chengsong Ke ping
On Fri, Dec 11, 2020 at 4:38 AM Chengsong Ke <kechengsong@huawei.com> wrote: > > I just send the v1 with the wrong module name 'ubifs'. > > [PATCH] ubifs: Remove useless code in bytes_str_to_int > > :-) > > Thanks, > > //Chengsong Ke > ping Both patches are in my next tree and should appear soon on linux-next. Thanks for your patience.
diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index e85b04e9716b..46a6dd75e533 100644 --- a/drivers/mtd/ubi/build.c +++ b/drivers/mtd/ubi/build.c @@ -1351,8 +1351,6 @@ static int bytes_str_to_int(const char *str) fallthrough; case 'K': result *= 1024; - if (endp[1] == 'i' && endp[2] == 'B') - endp += 2; case '\0': break; default: