| Message ID | 20200916124418.833-2-p.yadav@ti.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Vignesh R |
| Headers | show |
| Series | mtd: spi-nor: add xSPI Octal DTR support | expand |
On 9/16/20 3:44 PM, Pratyush Yadav wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > ENOTSUPP is not a SUSV4 error code. Using EOPNOTSUPP is preferred > in its stead. > > Signed-off-by: Pratyush Yadav <p.yadav@ti.com> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com> > --- > drivers/mtd/spi-nor/core.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > index 65eff4ce6ab1..623384ef9a5d 100644 > --- a/drivers/mtd/spi-nor/core.c > +++ b/drivers/mtd/spi-nor/core.c > @@ -2297,7 +2297,7 @@ static int spi_nor_hwcaps_pp2cmd(u32 hwcaps) > *@nor: pointer to a 'struct spi_nor' > *@op: pointer to op template to be checked > * > - * Returns 0 if operation is supported, -ENOTSUPP otherwise. > + * Returns 0 if operation is supported, -EOPNOTSUPP otherwise. > */ > static int spi_nor_spimem_check_op(struct spi_nor *nor, > struct spi_mem_op *op) > @@ -2311,12 +2311,12 @@ static int spi_nor_spimem_check_op(struct spi_nor *nor, > op->addr.nbytes = 4; > if (!spi_mem_supports_op(nor->spimem, op)) { > if (nor->mtd.size > SZ_16M) > - return -ENOTSUPP; > + return -EOPNOTSUPP; > > /* If flash size <= 16MB, 3 address bytes are sufficient */ > op->addr.nbytes = 3; > if (!spi_mem_supports_op(nor->spimem, op)) > - return -ENOTSUPP; > + return -EOPNOTSUPP; > } > > return 0; > @@ -2328,7 +2328,7 @@ static int spi_nor_spimem_check_op(struct spi_nor *nor, > *@nor: pointer to a 'struct spi_nor' > *@read: pointer to op template to be checked > * > - * Returns 0 if operation is supported, -ENOTSUPP otherwise. > + * Returns 0 if operation is supported, -EOPNOTSUPP otherwise. > */ > static int spi_nor_spimem_check_readop(struct spi_nor *nor, > const struct spi_nor_read_command *read) > @@ -2354,7 +2354,7 @@ static int spi_nor_spimem_check_readop(struct spi_nor *nor, > *@nor: pointer to a 'struct spi_nor' > *@pp: pointer to op template to be checked > * > - * Returns 0 if operation is supported, -ENOTSUPP otherwise. > + * Returns 0 if operation is supported, -EOPNOTSUPP otherwise. > */ > static int spi_nor_spimem_check_pp(struct spi_nor *nor, > const struct spi_nor_pp_command *pp) > -- > 2.28.0 >
diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index 65eff4ce6ab1..623384ef9a5d 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -2297,7 +2297,7 @@ static int spi_nor_hwcaps_pp2cmd(u32 hwcaps) *@nor: pointer to a 'struct spi_nor' *@op: pointer to op template to be checked * - * Returns 0 if operation is supported, -ENOTSUPP otherwise. + * Returns 0 if operation is supported, -EOPNOTSUPP otherwise. */ static int spi_nor_spimem_check_op(struct spi_nor *nor, struct spi_mem_op *op) @@ -2311,12 +2311,12 @@ static int spi_nor_spimem_check_op(struct spi_nor *nor, op->addr.nbytes = 4; if (!spi_mem_supports_op(nor->spimem, op)) { if (nor->mtd.size > SZ_16M) - return -ENOTSUPP; + return -EOPNOTSUPP; /* If flash size <= 16MB, 3 address bytes are sufficient */ op->addr.nbytes = 3; if (!spi_mem_supports_op(nor->spimem, op)) - return -ENOTSUPP; + return -EOPNOTSUPP; } return 0; @@ -2328,7 +2328,7 @@ static int spi_nor_spimem_check_op(struct spi_nor *nor, *@nor: pointer to a 'struct spi_nor' *@read: pointer to op template to be checked * - * Returns 0 if operation is supported, -ENOTSUPP otherwise. + * Returns 0 if operation is supported, -EOPNOTSUPP otherwise. */ static int spi_nor_spimem_check_readop(struct spi_nor *nor, const struct spi_nor_read_command *read) @@ -2354,7 +2354,7 @@ static int spi_nor_spimem_check_readop(struct spi_nor *nor, *@nor: pointer to a 'struct spi_nor' *@pp: pointer to op template to be checked * - * Returns 0 if operation is supported, -ENOTSUPP otherwise. + * Returns 0 if operation is supported, -EOPNOTSUPP otherwise. */ static int spi_nor_spimem_check_pp(struct spi_nor *nor, const struct spi_nor_pp_command *pp)
ENOTSUPP is not a SUSV4 error code. Using EOPNOTSUPP is preferred in its stead. Signed-off-by: Pratyush Yadav <p.yadav@ti.com> --- drivers/mtd/spi-nor/core.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)