| Message ID | 20200529111322.7184-17-miquel.raynal@bootlin.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Allow vendor drivers to propose their own timings | expand |
On Fri, 29 May 2020 13:13:10 +0200 Miquel Raynal <miquel.raynal@bootlin.com> wrote: > These two values are already hardcoded in the default ONFI timing > structure, no need to redefine them here. Plus, we want to be able to > reference timing mode 0 easily and reliably, without extra > computation, so we get rid of the extra assignations. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> > --- > drivers/mtd/nand/raw/nand_timings.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/mtd/nand/raw/nand_timings.c b/drivers/mtd/nand/raw/nand_timings.c > index b089f2dc5f23..54c7a1a8b038 100644 > --- a/drivers/mtd/nand/raw/nand_timings.c > +++ b/drivers/mtd/nand/raw/nand_timings.c > @@ -369,9 +369,6 @@ int onfi_fill_data_interface(struct nand_chip *chip, > /* microseconds -> picoseconds */ > timings->tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX; > timings->tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX; > - > - timings->tR_max = 200000000; > - timings->tCCS_min = 500000; > } > > return 0;
On Fri, 2020-05-29 at 11:13:10 UTC, Miquel Raynal wrote: > These two values are already hardcoded in the default ONFI timing > structure, no need to redefine them here. Plus, we want to be able to > reference timing mode 0 easily and reliably, without extra > computation, so we get rid of the extra assignations. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next. Miquel
diff --git a/drivers/mtd/nand/raw/nand_timings.c b/drivers/mtd/nand/raw/nand_timings.c index b089f2dc5f23..54c7a1a8b038 100644 --- a/drivers/mtd/nand/raw/nand_timings.c +++ b/drivers/mtd/nand/raw/nand_timings.c @@ -369,9 +369,6 @@ int onfi_fill_data_interface(struct nand_chip *chip, /* microseconds -> picoseconds */ timings->tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX; timings->tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX; - - timings->tR_max = 200000000; - timings->tCCS_min = 500000; } return 0;
These two values are already hardcoded in the default ONFI timing structure, no need to redefine them here. Plus, we want to be able to reference timing mode 0 easily and reliably, without extra computation, so we get rid of the extra assignations. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/mtd/nand/raw/nand_timings.c | 3 --- 1 file changed, 3 deletions(-)