[v7,11/28] mtd: rawnand: Rename nand_init_data_interface()

Message ID	20200529111322.7184-12-miquel.raynal@bootlin.com
State	Accepted
Headers	show Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 5F793240005; Fri, 29 May 2020 11:13:38 +0000 (UTC) From: Miquel Raynal <miquel.raynal@bootlin.com> To: Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Tudor Ambarus <Tudor.Ambarus@microchip.com>, <linux-mtd@lists.infradead.org> Subject: [PATCH v7 11/28] mtd: rawnand: Rename nand_init_data_interface() Date: Fri, 29 May 2020 13:13:05 +0200 Message-Id: <20200529111322.7184-12-miquel.raynal@bootlin.com> In-Reply-To: <20200529111322.7184-1-miquel.raynal@bootlin.com> References: <20200529111322.7184-1-miquel.raynal@bootlin.com> MIME-Version: 1.0 summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.183.193 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [217.70.183.193 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders Precedence: list Cc: Michal Simek <monstr@monstr.eu>, Boris Brezillon <boris.brezillon@collabora.com>, Naga Sureshkumar Relli <nagasure@xilinx.com>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Miquel Raynal <miquel.raynal@bootlin.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org
Series	Allow vendor drivers to propose their own timings \| expand [v7,00/28] Allow vendor drivers to propose their own timings [v7,01/28] mtd: rawnand: Use unsigned types for nand_chip unsigned values [v7,02/28] mtd: rawnand: Only use u8 instead of uint8_t in nand_chip structure [v7,03/28] mtd: rawnand: Create a nand_chip operations structure [v7,04/28] mtd: rawnand: Rename the manufacturer structure [v7,05/28] mtd: rawnand: Declare the nand_manufacturer structure out of nand_chip [v7,06/28] mtd: rawnand: Reorganize the nand_chip structure [v7,07/28] mtd: rawnand: Compare the actual timing values [v7,08/28] mtd: rawnand: Use the data interface mode entry when relevant [v7,09/28] mtd: rawnand: Rename nand_has_setup_data_iface() [v7,10/28] mtd: rawnand: Fix nand_setup_data_interface() description [v7,11/28] mtd: rawnand: Rename nand_init_data_interface() [v7,12/28] mtd: rawnand: timings: Update onfi_fill_data_interface() kernel doc [v7,13/28] mtd: rawnand: timings: Provide onfi_fill_data_interface() with a data interface [v7,14/28] mtd: rawnand: timings: onfi_fill_data_interface timing mode is unsigned [v7,15/28] mtd: rawnand: timings: Add a helper to find the closest ONFI mode [v7,16/28] mtd: rawnand: timings: Avoid redefining tR_max and tCCS_min [v7,17/28] mtd: rawnand: timings: Use default values for tPROG_max and tBERS_max [v7,18/28] mtd: rawnand: Hide the chip->data_interface indirection [v7,19/28] mtd: rawnand: s/data_interface/interface_config/ [v7,20/28] mtd: rawnand: timings: Make onfi_fill_interface_config() a void helper [v7,21/28] mtd: rawnand: Introduce nand_choose_best_sdr_timings() [v7,22/28] mtd: rawnand: Add the ->choose_interface_config() hook [v7,23/28] mtd: rawnand: toshiba: Implement ->choose_interface_config() for TC58TEG5DCLTA00 [v7,24/28] mtd: rawnand: toshiba: Implement ->choose_interface_config() for TC58NVG0S3E [v7,25/28] mtd: rawnand: hynix: Implement ->choose_interface_config() for H27UCG8T2ATR-BC [v7,26/28] mtd: rawnand: toshiba: Choose the interface configuration for TH58NVG2S3HBAI4 [v7,27/28] mtd: rawnand: Get rid of the default ONFI timing mode [v7,28/28] mtd: rawnand: Allocate the interface configurations dynamically

Message ID

20200529111322.7184-12-miquel.raynal@bootlin.com

State

Accepted

Headers

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Richard Weinberger <richard@nod.at>,
 Vignesh Raghavendra <vigneshr@ti.com>,
 Tudor Ambarus <Tudor.Ambarus@microchip.com>,
 <linux-mtd@lists.infradead.org>
Subject: [PATCH v7 11/28] mtd: rawnand: Rename nand_init_data_interface()
Date: Fri, 29 May 2020 13:13:05 +0200
Message-Id: <20200529111322.7184-12-miquel.raynal@bootlin.com>
In-Reply-To: <20200529111322.7184-1-miquel.raynal@bootlin.com>
References: <20200529111322.7184-1-miquel.raynal@bootlin.com>
MIME-Version: 1.0
Precedence: list
Cc: Michal Simek <monstr@monstr.eu>,
 Boris Brezillon <boris.brezillon@collabora.com>,
 Naga Sureshkumar Relli <nagasure@xilinx.com>,
 Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
 Miquel Raynal <miquel.raynal@bootlin.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org>
Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org

Series

Allow vendor drivers to propose their own timings | expand

Commit Message

Miquel Raynal May 29, 2020, 11:13 a.m. UTC

This name is a bit misleading, what we do in this helper is trying to
find the best SDR timings supported by the controller and the chip.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
---
 drivers/mtd/nand/raw/nand_base.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Miquel Raynal June 15, 2020, 9:05 a.m. UTC | #1

On Fri, 2020-05-29 at 11:13:05 UTC, Miquel Raynal wrote:
> This name is a bit misleading, what we do in this helper is trying to
> find the best SDR timings supported by the controller and the chip.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next.

Miquel

diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index 01e788e0d010..1d9cf02d164b 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -1005,7 +1005,7 @@  static int nand_setup_data_interface(struct nand_chip *chip, int chipnr)
 }
 
 /**
- * nand_init_data_interface - find the best data interface and timings
+ * nand_choose_data_interface - find the best data interface and timings
  * @chip: The NAND chip
  *
  * Find the best data interface and NAND timings supported by the chip
@@ -1018,7 +1018,7 @@  static int nand_setup_data_interface(struct nand_chip *chip, int chipnr)
  *
  * Returns 0 for success or negative error code otherwise.
  */
-static int nand_init_data_interface(struct nand_chip *chip)
+static int nand_choose_data_interface(struct nand_chip *chip)
 {
 	int modes, mode, ret;
 
@@ -5969,8 +5969,8 @@  static int nand_scan_tail(struct nand_chip *chip)
 	if (!mtd->bitflip_threshold)
 		mtd->bitflip_threshold = DIV_ROUND_UP(mtd->ecc_strength * 3, 4);
 
-	/* Initialize the ->data_interface field. */
-	ret = nand_init_data_interface(chip);
+	/* Find the fastest data interface for this chip */
+	ret = nand_choose_data_interface(chip);
 	if (ret)
 		goto err_nanddev_cleanup;

[v7,11/28] mtd: rawnand: Rename nand_init_data_interface()

Commit Message

Comments

Patch