From patchwork Mon May 4 09:42:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= X-Patchwork-Id: 1282364 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20170209 header.b=ZW4OgVTr; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=YAPUKxvx; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49FyZy6yt9z9sSW for ; Mon, 4 May 2020 19:43:05 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=K76TL4VJgJOSeufVCWFVHp3kXZkv/7uaWIqT/GPlr0g=; b=ZW4OgVTrQPcS4v bmKrYfnMf7UHz+2I+uY4+jqTjUKE3Q4T+IyW1kPT4F1iV8p6FhOtVm0qYhXg4N/BX6P+vHxn4FkzL vZIT0G9gsgh/QvHFd6bK3qmA5gD+Z5VmdDnyIcKgS01hRiJG4Hmy2wTYp98F8Lrw+RvrvLuxoQABn jz7kb3pa9hiAXD4FOIPjVtreHpFbsPDWAavBRv44ImZ1phASEkOX403lkPLmwJRoEe1Xql/SFNOqj O9Yb6loM8OCcRSokyqqy6JlJCvvL9K+o6ii7+FpYpK7qIQJti9oWtePg+wPq9f4w08NajeoYxNL2C aoa+MfGb+umWx6J9RFoA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVXcr-0005Ka-7D; Mon, 04 May 2020 09:43:01 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVXco-0005K3-Om for linux-mtd@lists.infradead.org; Mon, 04 May 2020 09:43:00 +0000 Received: by mail-wr1-x442.google.com with SMTP id d15so20127114wrx.3 for ; Mon, 04 May 2020 02:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2PePijgL48hP/OTqwgfZQihDqRN1L4nqpcMBBw+8WKI=; b=YAPUKxvx+4km4cbaUEcywVQhHgIxiSBOQ5OVl/vRzJ2S6bE1gnc9gFa6K9CkC5yi1W iQ3S//xRpTSHs2QzUeHCRYVICFmDr/vYtuG/M9t3sjfgWZP51vzjw1KnQz00w6JOoUAE yZeo0P/Yz9vYxE+9sFoOStkJ4Im/FxmrR4w9D2fKGURQtgPrPDDfcByfXjyKFGARcOe8 ETk+bSbup5WIH0xyOLUOcIsdzWKGyC4uaMESxI9WvAtBW1sWajmCduk7qp8sF9lInF4x vHKN6VME3dq7701qfMTr33lCNKfSApD7gDWBTXbjYSi1Zdg5CfV2+maidl81rMD0zJUY FxBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2PePijgL48hP/OTqwgfZQihDqRN1L4nqpcMBBw+8WKI=; b=q7JsgHONW95Mw9DVVQL4wSW6OBvJH76t5CT7RRGiO47KCFy3vL9WuF+57XdvcUDI3w wTbTJVTwJqv+E6hFRDrVLamPIqJLeeyOuFrF2YvenOKTj9B3AmMHBj4TiANew9ZJruB9 WCBJbwPvcsohRpmxaZNvNB6rXXbH5WwwDSgDhDTzvFC157IWxO1cwoTBwo7teSN8iy1t hgOowspT8ruuYwycg7uUm8Y2QVlmivAc8pOLX3ayoyo7HttSy9nW2aR+mOTYlbb7z1VM MnwO28Q3nOV6kYuM6+zegyDpYa7j9kc1jiyTbHB0nGhUG0w8RnCNbtVtbS11mXe2cCKc IK7Q== X-Gm-Message-State: AGi0PuauwLN6AqUm/rOyqVOBmwEyjWPg89VDGDBTVRag1/1qbklaPBLA 9UKByZjoJWTvrvh4ZYRDW+4= X-Google-Smtp-Source: APiQypK+dr+ELxw+9DPmzTETNW0ltDp0Q8pW07j0x7GzYI+R7bAmqMx+tn87tLGhzxVjL+7zMe/gfA== X-Received: by 2002:adf:f34e:: with SMTP id e14mr18325177wrp.193.1588585376769; Mon, 04 May 2020 02:42:56 -0700 (PDT) Received: from skynet.lan (246.red-83-44-9.dynamicip.rima-tde.net. [83.44.9.246]) by smtp.gmail.com with ESMTPSA id f63sm12349892wma.47.2020.05.04.02.42.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2020 02:42:56 -0700 (PDT) From: =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= To: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, s.hauer@pengutronix.de, masonccyang@mxic.com.tw, boris.brezillon@collabora.com, christophe.kerello@st.com, stefan@agner.ch, piotrs@cadence.com, devik@eaxlabs.cz, tglx@linutronix.de, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] nand: raw: use write_oob_raw for MTD_OPS_AUTO_OOB mode Date: Mon, 4 May 2020 11:42:53 +0200 Message-Id: <20200504094253.2741109-1-noltari@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200504_024258_806753_58426876 X-CRM114-Status: GOOD ( 11.83 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [noltari[at]gmail.com] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Some NAND controllers change the ECC bytes when OOB is written with ECC enabled. This is a problem in brcmnand, since adding JFFS2 cleanmarkers after the page has been erased will change the ECC bytes to 0 and the controller will think the block is bad. It can be fixed by using write_oob_raw, which ensures ECC is disabled. Signed-off-by: Álvaro Fernández Rojas --- drivers/mtd/nand/raw/nand_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c index c24e5e2ba130..755d25200520 100644 --- a/drivers/mtd/nand/raw/nand_base.c +++ b/drivers/mtd/nand/raw/nand_base.c @@ -488,7 +488,7 @@ static int nand_do_write_oob(struct nand_chip *chip, loff_t to, nand_fill_oob(chip, ops->oobbuf, ops->ooblen, ops); - if (ops->mode == MTD_OPS_RAW) + if (ops->mode == MTD_OPS_AUTO_OOB || ops->mode == MTD_OPS_RAW) status = chip->ecc.write_oob_raw(chip, page & chip->pagemask); else status = chip->ecc.write_oob(chip, page & chip->pagemask);