diff mbox series

[1/2] mtd: spi-nor: Uniformize the return value in spi_nor_*_ready()

Message ID 20200421063129.244466-1-tudor.ambarus@microchip.com
State Accepted
Delegated to: Ambarus Tudor
Headers show
Series [1/2] mtd: spi-nor: Uniformize the return value in spi_nor_*_ready() | expand

Commit Message

Tudor Ambarus April 21, 2020, 6:31 a.m. UTC 
From: Tudor Ambarus <tudor.ambarus@microchip.com>

spi_nor_ready() returns 1 if ready, 0 if not ready and -errono on errors.
Do the same in all the spi_nor_*_ready() children.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
 drivers/mtd/spi-nor/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Raghavendra, Vignesh April 28, 2020, 12:06 p.m. UTC | #1 
On 21/04/20 12:01 pm, Tudor.Ambarus@microchip.com wrote:
> From: Tudor Ambarus <tudor.ambarus@microchip.com>
> 
> spi_nor_ready() returns 1 if ready, 0 if not ready and -errono on errors.

s/-errono/-errno

With that:

Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>

> Do the same in all the spi_nor_*_ready() children.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
>  drivers/mtd/spi-nor/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index cc68ea84318e..9dcc53bda8b0 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -640,7 +640,7 @@ static int spi_nor_fsr_ready(struct spi_nor *nor)
>  		return -EIO;
>  	}
>  
> -	return nor->bouncebuf[0] & FSR_READY;
> +	return !!(nor->bouncebuf[0] & FSR_READY);
>  }
>  
>  /**
>
Tudor Ambarus April 29, 2020, 6:48 a.m. UTC | #2 
On Tuesday, April 28, 2020 3:06:19 PM EEST Vignesh Raghavendra wrote:
> > From: Tudor Ambarus <tudor.ambarus@microchip.com>
> > 
> > spi_nor_ready() returns 1 if ready, 0 if not ready and -errono on errors.
> 
> s/-errono/-errno
> 
> With that:
> 
> Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>

Fixed the typo and applied. Cheers.

> 
> > Do the same in all the spi_nor_*_ready() children.
> > 
> > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> > ---
> > drivers/mtd/spi-nor/core.c | 2 +-
diff mbox series

Patch

diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
index cc68ea84318e..9dcc53bda8b0 100644
--- a/drivers/mtd/spi-nor/core.c
+++ b/drivers/mtd/spi-nor/core.c
@@ -640,7 +640,7 @@  static int spi_nor_fsr_ready(struct spi_nor *nor)
 		return -EIO;
 	}
 
-	return nor->bouncebuf[0] & FSR_READY;
+	return !!(nor->bouncebuf[0] & FSR_READY);
 }
 
 /**